Change OnOff revision to 5 (XML). Update all impacted .zap files. #26524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Matter 1.2 has added a new FeatureMap value to the OnOff cluster, which has also resulted in the cluster revision being incremented. Subsequent tests that are based on the Spec value for Revision are now failing. Solution: Update the XML template for OnOff to add the Feature flag and increment the revision. Run the new update script to reflect this change in all .zap files. Testing: Updated XML and updated the .zap via script. Also regen'd all. Rebuild Chiptool and AllClusters. Verify via a read that the cluster-version for OnOff is now 5 (from 4) in AllClusters.
|
|
|
PR #26524: Size comparison from ac16417 to c1ea768 Increases (3 builds for bl702, cc32xx)
Decreases (4 builds for bl602, bl702, cc13x2_26x2, nrfconnect)
Full report (21 builds for bl602, bl702, cc13x2_26x2, cc32xx, k32w, linux, mbed, nrfconnect)
|
bzbarsky-apple
approved these changes
May 11, 2023
pullapprove
bot
requested review from
amitnj,
arkq,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs and
jmartinez-silabs
|
PR #26524: Size comparison from c7d9a11 to bc5e795 Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (2 builds for cc32xx, mbed)
|
|
PR #26524: Size comparison from c7d9a11 to dd6d19d Increases (3 builds for cc32xx, linux, nrfconnect)
Decreases (1 build for cc32xx)
Full report (12 builds for cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
|
PR #26524: Size comparison from c7d9a11 to 24a59ed Increases (2 builds for cc32xx, qpg)
Decreases (1 build for cc32xx)
Full report (4 builds for cc32xx, mbed, qpg)
|
|
PR #26524: Size comparison from c7d9a11 to a66a1e8 Increases (27 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, telink)
Decreases (27 builds for bl702l, cc32xx, cyw30739, k32w, linux, psoc6, telink)
Full report (56 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #26524: Size comparison from 5d2beb7 to 0a3575a Increases (16 builds for bl702, bl702l, cc32xx, esp32, linux, psoc6, telink)
Decreases (11 builds for bl602, bl702, bl702l, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #26524: Size comparison from edbdf8a to 686607e Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (4 builds for cc32xx, mbed, qpg)
|
|
PR #26524: Size comparison from edbdf8a to 3e05252 Increases (14 builds for bl702, bl702l, cc32xx, k32w, linux, psoc6, telink)
Decreases (14 builds for bl602, bl702, bl702l, cc32xx, qpg, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #26524: Size comparison from d9a6f2e to 69a4a04 Increases (14 builds for bl702, bl702l, cc32xx, cyw30739, linux, psoc6, telink)
Decreases (15 builds for bl602, bl702, cc32xx, cyw30739, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Jul 18, 2023
erwinpan1
pushed a commit
to erwinpan1/connectedhomeip
that referenced
this pull request
Jul 21, 2023
…oject-chip#26524) Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26469
Problem:
Matter 1.2 has added a new FeatureMap value to the OnOff cluster, which has also resulted in the cluster revision being incremented. Subsequent tests that are based on the Spec value for Revision are now failing.
Solution:
Update the XML template for OnOff to add the Feature flag and increment the revision. Run the new update script to reflect this change in all .zap files.
Testing:
Updated XML and updated the .zap via script. Also regen'd all. Rebuild Chiptool and AllClusters. Verify via a read that the cluster-version for OnOff is now 5 (from 4) in AllClusters.