Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ICD] Creation of ICDManager classes #26523

Merged
merged 29 commits into from
Jun 5, 2023
Merged

[ICD] Creation of ICDManager classes #26523

merged 29 commits into from
Jun 5, 2023

Conversation

mkardous-silabs
Copy link
Contributor

@mkardous-silabs mkardous-silabs commented May 11, 2023 •
edited
Loading

Description

Create files for the ICD Manager source code

Tests

It compiles locally

@mkardous-silabs mkardous-silabs added the icd Intermittently Connected Devices label May 11, 2023
andy31415
andy31415 reviewed Jun 2, 2023
View reviewed changes
src/app/tests/BUILD.gn Outdated Show resolved Hide resolved
@mkardous-silabs mkardous-silabs requested a review from andy31415 June 2, 2023 19:22
andy31415
andy31415 reviewed Jun 2, 2023
View reviewed changes
src/app/BUILD.gn Outdated Show resolved Hide resolved
andy31415
andy31415 reviewed Jun 2, 2023
View reviewed changes
src/app/tests/BUILD.gn Outdated Show resolved Hide resolved
@jmartinez-silabs jmartinez-silabs enabled auto-merge (squash) June 2, 2023 19:57
andy31415
andy31415 reviewed Jun 2, 2023
View reviewed changes
src/app/icd/BUILD.gn Outdated Show resolved Hide resolved
andy31415
andy31415 reviewed Jun 2, 2023
View reviewed changes
src/app/icd/BUILD.gn Outdated Show resolved Hide resolved
bzbarsky-apple
bzbarsky-apple reviewed Jun 2, 2023
View reviewed changes
src/app/icd/BUILD.gn Show resolved Hide resolved
src/app/icd/ICDEventManager.h Outdated Show resolved Hide resolved
src/app/icd/ICDEventManager.h Outdated Show resolved Hide resolved
src/app/icd/ICDEventManager.cpp Show resolved Hide resolved
src/app/icd/ICDManager.h Show resolved Hide resolved
src/app/icd/icd.gni Outdated Show resolved Hide resolved
src/app/icd/icd.gni Outdated Show resolved Hide resolved
andy31415
andy31415 reviewed Jun 2, 2023
View reviewed changes
src/app/icd/BUILD.gn Outdated Show resolved Hide resolved
andy31415
andy31415 reviewed Jun 2, 2023
View reviewed changes
src/app/BUILD.gn Outdated Show resolved Hide resolved
@mkardous-silabs mkardous-silabs force-pushed the feature/icd_manager_creation branch from 54e545d to 9e43929 Compare June 3, 2023 02:30
@github-actions
Copy link

github-actions bot commented Jun 5, 2023

PR #26523: Size comparison from 83ecf9c to 9e43929

Full report (1 build for mbed)
platform target config section 83ecf9c 9e43929 change % change
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2497608 2497608 0 0.0
.bss 216304 216304 0 0.0
.data 5144 5144 0 0.0
.text 1460292 1460292 0 0.0

@jmartinez-silabs jmartinez-silabs merged commit 9828293 into project-chip:master Jun 5, 2023
@mkardous-silabs mkardous-silabs deleted the feature/icd_manager_creation branch June 5, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple left review comments

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@selissia selissia Awaiting requested review from selissia

Assignees
No one assigned
Labels
app icd Intermittently Connected Devices review - approved tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mkardous-silabs @tcarmelveilleux @andy31415 @selissia @bzbarsky-apple @jmartinez-silabs