-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log session id in SecureSession::MoveToState. #26490
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:log-session-id
May 11, 2023
Merged
Log session id in SecureSession::MoveToState. #26490
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:log-session-id
May 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple and
lazarkov
May 10, 2023 20:47
pullapprove
bot
requested review from
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
May 10, 2023 20:47
PR #26490: Size comparison from 8a5b352 to 914e895 Increases (2 builds for qpg)
Full report (2 builds for qpg)
|
This is the only progress-level log in SecureSession, so without this if detail logging is disabled it's hard to make sense of what's going on with sessions.
bzbarsky-apple
force-pushed
the
log-session-id
branch
from
May 11, 2023 00:27
914e895
to
e1c67d3
Compare
PR #26490: Size comparison from bf14d4a to e1c67d3 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
tehampson
approved these changes
May 11, 2023
jmartinez-silabs
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the only progress-level log in SecureSession, so without this if detail logging is disabled it's hard to make sense of what's going on with sessions.