Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log session id in SecureSession::MoveToState. #26490

Merged
merged 1 commit into from
May 11, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

This is the only progress-level log in SecureSession, so without this if detail logging is disabled it's hard to make sense of what's going on with sessions.

@github-actions
Copy link

PR #26490: Size comparison from 8a5b352 to 914e895

Increases (2 builds for qpg)
platform target config section 8a5b352 914e895 change % change
qpg lighting-app qpg6105+debug (read/write) 1169624 1169632 8 0.0
.text 616724 616732 8 0.0
lock-app qpg6105+debug (read/write) 1139492 1139500 8 0.0
.text 586592 586600 8 0.0
Full report (2 builds for qpg)
platform target config section 8a5b352 914e895 change % change
qpg lighting-app qpg6105+debug (read/write) 1169624 1169632 8 0.0
.bss 99632 99632 0 0.0
.data 856 856 0 0.0
.text 616724 616732 8 0.0
lock-app qpg6105+debug (read/write) 1139492 1139500 8 0.0
.bss 94824 94824 0 0.0
.data 856 856 0 0.0
.text 586592 586600 8 0.0

This is the only progress-level log in SecureSession, so without this if detail logging
is disabled it's hard to make sense of what's going on with sessions.
@github-actions
Copy link

PR #26490: Size comparison from bf14d4a to e1c67d3

Increases (1 build for cc32xx)
platform target config section bf14d4a e1c67d3 change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 605002 605018 16 0.0
.debug_frame 342080 342084 4 0.0
.debug_info 19674627 19674634 7 0.0
.rodata 104314 104322 8 0.0
.text 498564 498572 8 0.0
Full report (1 build for cc32xx)
platform target config section bf14d4a e1c67d3 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 605002 605018 16 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 957619 957619 0 0.0
.debug_aranges 101232 101232 0 0.0
.debug_frame 342080 342084 4 0.0
.debug_info 19674627 19674634 7 0.0
.debug_line 2671903 2671903 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1491139 1491139 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94412 94412 0 0.0
.debug_str 3131828 3131828 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104314 104322 8 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 483089 483089 0 0.0
.symtab 287232 287232 0 0.0
.text 498564 498572 8 0.0

@bzbarsky-apple bzbarsky-apple merged commit 0b4fba2 into project-chip:master May 11, 2023
@bzbarsky-apple bzbarsky-apple deleted the log-session-id branch May 11, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants