-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrfconnect] Added the Device Appearance attribute to factory data #26473
Merged
kkasperczyk-no
merged 1 commit into
project-chip:master
from
ArekBalysNordic:add_device_apperance
May 16, 2023
Merged
[nrfconnect] Added the Device Appearance attribute to factory data #26473
kkasperczyk-no
merged 1 commit into
project-chip:master
from
ArekBalysNordic:add_device_apperance
May 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
nrf connect
platform
scripts
labels
May 10, 2023
ArekBalysNordic
force-pushed
the
add_device_apperance
branch
from
May 10, 2023 08:38
8e3e640
to
097034c
Compare
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
May 10, 2023 08:38
ArekBalysNordic
force-pushed
the
add_device_apperance
branch
2 times, most recently
from
May 10, 2023 08:56
a2d6646
to
c4da0f8
Compare
PR #26473: Size comparison from 4f081a5 to c4da0f8 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
ArekBalysNordic
force-pushed
the
add_device_apperance
branch
from
May 10, 2023 09:40
c4da0f8
to
48bcc11
Compare
PR #26473: Size comparison from 4f081a5 to 48bcc11 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
ArekBalysNordic
force-pushed
the
add_device_apperance
branch
from
May 10, 2023 10:43
48bcc11
to
f87317e
Compare
PR #26473: Size comparison from 4f081a5 to f87317e Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
andy31415
approved these changes
May 10, 2023
bzbarsky-apple
requested changes
May 11, 2023
scripts/tools/nrfconnect/generate_nrfconnect_chip_factory_data.py
Outdated
Show resolved
Hide resolved
ArekBalysNordic
force-pushed
the
add_device_apperance
branch
from
May 11, 2023 08:35
f87317e
to
7986031
Compare
ArekBalysNordic
force-pushed
the
add_device_apperance
branch
from
May 11, 2023 08:38
7986031
to
f1ee10a
Compare
Damian-Nordic
approved these changes
May 11, 2023
PR #26473: Size comparison from bb3ce44 to f1ee10a Increases (1 build for cc32xx)
Decreases (1 build for qpg)
Full report (4 builds for cc32xx, mbed, qpg)
|
ArekBalysNordic
force-pushed
the
add_device_apperance
branch
3 times, most recently
from
May 11, 2023 09:32
4a60810
to
0fcc289
Compare
bzbarsky-apple
approved these changes
May 11, 2023
LuDuda
approved these changes
May 12, 2023
The appearance attribute of the Basic Information cluster has been added to the Factory Data set. That field allows for defining the visible finish of the product's external case finish method, and color hue. - The attribute has been added to the factory data provider and the Factory Data Parser. - The appearance field has been described in the factory data guide.
ArekBalysNordic
force-pushed
the
add_device_apperance
branch
from
May 12, 2023 13:55
0fcc289
to
c95ec29
Compare
PR #26473: Size comparison from bbff46a to c95ec29 Increases (3 builds for efr32, nrfconnect, psoc6)
Decreases (7 builds for cc13x2_26x2, cc32xx, nrfconnect, psoc6, qpg)
Full report (54 builds for cc13x2_26x2, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
config
documentation
Improvements or additions to documentation
nrf connect
platform
review - approved
scripts
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The appearance attribute of the Basic Information cluster has been added to the Factory Data set.
That field allows for defining the visible finish of the product's external case finish method, and color hue.
The attribute has been added to the factory data provider and the Factory Data Parser.
The appearance field has been described in the factory data guide.