Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented Json to Tlv and Tlv to Json Converter in Kotlin #26458

Merged
merged 1 commit into from
May 10, 2023
Merged

Implemented Json to Tlv and Tlv to Json Converter in Kotlin #26458

merged 1 commit into from
May 10, 2023

Conversation

emargolis
Copy link
Contributor

Note that NOT all TLV configurations are supported by the current implementation. Here is the list of limitations:

  • TLV Lists are not supported
  • Multi-Dimensional TLV Arrays are not supported
  • All elements of an array MUST be of the same type
  • The top level TLV element MUST be a single structure with AnonymousTag
  • The following tags are supported: - AnonymousTag are used only with TLV Arrays elements or a top-level structure - ContextSpecificTag are used only with TLV Structure elements - CommonProfileTag are used only with TLV Structure elements
  • Infinity Float/Double values are not supported

@emargolis emargolis force-pushed the emargolis/feature/kotlin-json-to-tlv-to-json-converter branch from ff2b6d2 to 46395b7 Compare May 9, 2023 20:37
@github-actions
Copy link

github-actions bot commented May 9, 2023

PR #26458: Size comparison from 7b5ecb2 to 46395b7

Decreases (2 builds for bl602, bl702)
platform target config section 7b5ecb2 46395b7 change % change
bl602 lighting-app bl602 (read/write) 1354998 1354990 -8 -0.0
.text 1035978 1035976 -2 -0.0
bl702 lighting-app bl702+rpc .debug_info 45848902 45848901 -1 -0.0
.text 1038096 1038094 -2 -0.0
Full report (9 builds for bl602, bl702, cc32xx, linux, qpg)
platform target config section 7b5ecb2 46395b7 change % change
bl602 lighting-app bl602 (read/write) 1354998 1354990 -8 -0.0
.bss 87886 87886 0 0.0
.data 9648 9648 0 0.0
.text 1035978 1035976 -2 -0.0
bl602+rpc (read/write) 1401266 1401266 0 0.0
.bss 95934 95934 0 0.0
.data 10040 10040 0 0.0
.text 1067334 1067334 0 0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1185759 1185759 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 67585 67585 0 0.0
.bss_psram 24368 24368 0 0.0
.comment 48 48 0 0.0
.data 3952 3952 0 0.0
.debug_abbrev 1550204 1550204 0 0.0
.debug_aranges 132944 132944 0 0.0
.debug_frame 488804 488804 0 0.0
.debug_info 40943088 40943088 0 0.0
.debug_line 5301455 5301455 0 0.0
.debug_loc 3424613 3424613 0 0.0
.debug_ranges 372344 372344 0 0.0
.debug_str 3708223 3708223 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106304 106304 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 580786 580786 0 0.0
.symtab 175264 175264 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 965470 965470 0 0.0
bl702+rpc 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1273555 1273555 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 75633 75633 0 0.0
.bss_psram 24768 24768 0 0.0
.comment 48 48 0 0.0
.data 4504 4504 0 0.0
.debug_abbrev 1706954 1706954 0 0.0
.debug_aranges 141224 141224 0 0.0
.debug_frame 516776 516776 0 0.0
.debug_info 45848902 45848901 -1 -0.0
.debug_line 5716360 5716360 0 0.0
.debug_loc 3626917 3626917 0 0.0
.debug_ranges 397648 397648 0 0.0
.debug_str 4133328 4133328 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 120144 120144 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 641456 641456 0 0.0
.symtab 193600 193600 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 1038096 1038094 -2 -0.0
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 605002 605002 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 957619 957619 0 0.0
.debug_aranges 101232 101232 0 0.0
.debug_frame 342080 342080 0 0.0
.debug_info 19674627 19674627 0 0.0
.debug_line 2671903 2671903 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1491139 1491139 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94412 94412 0 0.0
.debug_str 3131828 3131828 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104314 104314 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 483089 483089 0 0.0
.symtab 287232 287232 0 0.0
.text 498564 498564 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12258652 12258652 0 0.0
(read/write) 746696 746696 0 0.0
.bss 34392 34392 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 688336 688336 0 0.0
.dynamic 560 560 0 0.0
.got 15752 15752 0 0.0
.init 24 24 0 0.0
.init_array 216 216 0 0.0
.rodata 570096 570096 0 0.0
.text 9915812 9915812 0 0.0
thermostat-no-ble arm64 (read only) 2528308 2528308 0 0.0
(read/write) 145816 145816 0 0.0
.bss 56392 56392 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 78048 78048 0 0.0
.dynamic 560 560 0 0.0
.got 5472 5472 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 130136 130136 0 0.0
.text 2133440 2133440 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1169616 1169616 0 0.0
.bss 99632 99632 0 0.0
.data 856 856 0 0.0
.text 616716 616716 0 0.0
lock-app qpg6105+debug (read/write) 1139484 1139484 0 0.0
.bss 94824 94824 0 0.0
.data 856 856 0 0.0
.text 586584 586584 0 0.0

@emargolis
Implemented Json to Tlv and Tlv to Json Converter in Kotlin
f68541d 
Note that NOT all TLV configurations are supported by the current implementation. Here is the list of limitations:
   - TLV Lists are not supported
   - Multi-Dimensional TLV Arrays are not supported
   - All elements of an array MUST be of the same type
   - The top level TLV element MUST be a single structure with AnonymousTag
   - The following tags are supported:
       - AnonymousTag are used only with TLV Arrays elements or a top-level structure
       - ContextSpecificTag are used only with TLV Structure elements
       - CommonProfileTag are used only with TLV Structure elements
   - Infinity Float/Double values are not supported
@emargolis emargolis force-pushed the emargolis/feature/kotlin-json-to-tlv-to-json-converter branch from 46395b7 to f68541d Compare May 10, 2023 00:23
@github-actions
Copy link

PR #26458: Size comparison from 7b5ecb2 to f68541d

Decreases (1 build for cc32xx)
platform target config section 7b5ecb2 f68541d change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19674627 19674626 -1 -0.0
Full report (2 builds for cc32xx, mbed)
platform target config section 7b5ecb2 f68541d change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 605002 605002 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 957619 957619 0 0.0
.debug_aranges 101232 101232 0 0.0
.debug_frame 342080 342080 0 0.0
.debug_info 19674627 19674626 -1 -0.0
.debug_line 2671903 2671903 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1491139 1491139 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94412 94412 0 0.0
.debug_str 3131828 3131828 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104314 104314 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 483089 483089 0 0.0
.symtab 287232 287232 0 0.0
.text 498564 498564 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2495056 2495056 0 0.0
.bss 216304 216304 0 0.0
.data 5144 5144 0 0.0
.text 1457740 1457740 0 0.0

@andy31415 andy31415 merged commit 60866e8 into project-chip:master May 10, 2023
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this pull request May 10, 2023
@bzbarsky-apple
Revert "Implemented Json to Tlv and Tlv to Json Converter in Kotlin (p…
fab113f 
…roject-chip#26458)"

This reverts commit 60866e8.

project-chip#26458 was merged with
failing CI, and the failure is in the files the PR added.  CI is now permanently
failing.
@bzbarsky-apple bzbarsky-apple mentioned this pull request May 10, 2023
Merged
emargolis pushed a commit that referenced this pull request May 11, 2023
@bzbarsky-apple
Revert "Implemented Json to Tlv and Tlv to Json Converter in Kotlin (#…
bf14d4a 
…26458)" (#26492)

This reverts commit 60866e8.

#26458 was merged with
failing CI, and the failure is in the files the PR added.  CI is now permanently
failing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
controller examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emargolis @andy31415