Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix many more pytype changes for matter_idl #26371

Merged

Conversation

andy31415
Copy link
Contributor

@andy31415 andy31415 commented May 4, 2023

  • start using isinstance instead of type== (this is what pytype likes)
  • Fixed a bunch of nullable checks
  • corrected a few return types
  • fixed bugs on property calls instead of access (for byte counts and sizing)

@github-actions
Copy link

github-actions bot commented May 4, 2023

PR #26371: Size comparison from de1c64a to ca27de0

Increases (1 build for cc32xx)
platform target config section de1c64a ca27de0 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19522697 19522698 1 0.0
Full report (1 build for cc32xx)
platform target config section de1c64a ca27de0 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 604866 604866 0 0.0
(read/write) 204156 204156 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197568 197568 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 957005 957005 0 0.0
.debug_aranges 101104 101104 0 0.0
.debug_frame 341416 341416 0 0.0
.debug_info 19522697 19522698 1 0.0
.debug_line 2666219 2666219 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1488771 1488771 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94291 94291 0 0.0
.debug_str 3100491 3100491 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104346 104346 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 482872 482872 0 0.0
.symtab 287120 287120 0 0.0
.text 498396 498396 0 0.0

@github-actions
Copy link

github-actions bot commented May 4, 2023

PR #26371: Size comparison from de1c64a to 0e85d78

Increases (1 build for cc32xx)
platform target config section de1c64a 0e85d78 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19522697 19522698 1 0.0
Full report (1 build for cc32xx)
platform target config section de1c64a 0e85d78 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 604866 604866 0 0.0
(read/write) 204156 204156 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197568 197568 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 957005 957005 0 0.0
.debug_aranges 101104 101104 0 0.0
.debug_frame 341416 341416 0 0.0
.debug_info 19522697 19522698 1 0.0
.debug_line 2666219 2666219 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1488771 1488771 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94291 94291 0 0.0
.debug_str 3100491 3100491 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104346 104346 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 482872 482872 0 0.0
.symtab 287120 287120 0 0.0
.text 498396 498396 0 0.0

@andy31415 andy31415 merged commit a59ffbd into project-chip:master May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants