-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort JSON Alphabetically #26327
Sort JSON Alphabetically #26327
Conversation
PR #26327: Size comparison from fa505f6 to 0668cd0 Full report (1 build for cc32xx)
|
PR #26327: Size comparison from fa505f6 to 76a6882 Full report (1 build for cc32xx)
|
In order to keep this JSON file sorted over time, there has to be a CI task which will enforce that, otherwise it will degrade over time |
I thought the same! Then I thought we probably don't want to plain sort all json files alphabetically. Then the CI tool would be required to have some kind of list of files which should be sorted and then we would end up having to add a new json file in potentially many places just like you have to do with cluster definition xml files today. This seemed a bit too much for this purpose. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably OK, but in practice this will break all the time unless you add a lint for this.
For now that lint could just lint this one file.
PR #26327: Size comparison from 6c0c5ea to 1680e5f Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
📖 Description
This PR only sorts
src/app/zap_cluster_list.json
alphabetically. New entries could be done at any point of the list and then VSCode or another IDE or tool could then sort it again. This should increase uniformity and maintainability of the codebase by letting a machine sort things rather than human best effort.🔎 Details
In VSCode the command would be
JSON: Sort Document