Try next IP address when sending first session establishment message fails. #26308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fails. If DNS-SD discovery comes back with an IP that is not routable for some reason, or if there os some other synchronous error when trying to kick off session establishment, move on to the next IP (just like we would for an async session establishment error), instead of just aborting the session establishment process altogether. The change in SetUpCodePairer::ConnectToDiscoveredDevice just moves on to the next element in our list, if any. The change in OperationalSessionSetup::UpdateDeviceData adds the TryNextResult call, but also restructures things to have early returns instead of deep nesting of ifs. Fixes project-chip#26307
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no and
ksperling-apple
pullapprove
bot
requested review from
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mrjerryjohns,
msandstedt,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
tehampson
approved these changes
May 1, 2023
woody-apple
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If DNS-SD discovery comes back with an IP that is not routable for some reason, or if there os some other synchronous error when trying to kick off session establishment, move on to the next IP (just like we would for an async session establishment error), instead of just aborting the session establishment process altogether.
The change in SetUpCodePairer::ConnectToDiscoveredDevice just moves on to the next element in our list, if any.
The change in OperationalSessionSetup::UpdateDeviceData adds the TryNextResult call, but also restructures things to have early returns instead of deep nesting of ifs.
Fixes #26307