-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use work helper with CASE handle sigma3 #26300
Merged
mlepage-google
merged 2 commits into
project-chip:master
from
mlepage-google:async-handlesigma3-workhelper
May 1, 2023
Merged
Use work helper with CASE handle sigma3 #26300
mlepage-google
merged 2 commits into
project-chip:master
from
mlepage-google:async-handlesigma3-workhelper
May 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WorkHelper was introduced to help with CASESession::SendSigma3. Now use it to help with CASESession::HandleSigma3. Part of issue project-chip#26280.
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple and
lazarkov
April 28, 2023 15:56
pullapprove
bot
requested review from
msandstedt,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
April 28, 2023 15:56
PR #26300: Size comparison from 77d72a8 to 5a01f6b Increases above 0.2%:
Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
mlepage-google
assigned mlepage-google and bzbarsky-apple and unassigned mlepage-google
Apr 28, 2023
bzbarsky-apple
approved these changes
Apr 29, 2023
andy31415
approved these changes
May 1, 2023
PR #26300: Size comparison from 77d72a8 to 4445d27 Increases (4 builds for mbed, nrfconnect)
Full report (4 builds for mbed, nrfconnect)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WorkHelper was introduced to help with CASESession::SendSigma3. Now use it to help with CASESession::HandleSigma3.
Part of issue #26280.