Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use work helper with CASE handle sigma3 #26300

Conversation

mlepage-google
Copy link
Contributor

WorkHelper was introduced to help with CASESession::SendSigma3. Now use it to help with CASESession::HandleSigma3.

Part of issue #26280.

WorkHelper was introduced to help with CASESession::SendSigma3.
Now use it to help with CASESession::HandleSigma3.

Part of issue project-chip#26280.
@github-actions
Copy link

PR #26300: Size comparison from 77d72a8 to 5a01f6b

Increases above 0.2%:

platform target config section 77d72a8 5a01f6b change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_str 3059490 3081523 22033 0.7
.strtab 481887 485135 3248 0.7
.symtab 287248 287952 704 0.2
Increases (1 build for cc32xx)
platform target config section 77d72a8 5a01f6b change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 602714 603514 800 0.1
.debug_aranges 103664 103792 128 0.1
.debug_frame 350552 350992 440 0.1
.debug_info 19521972 19537458 15486 0.1
.debug_line 2682751 2684446 1695 0.1
.debug_loclists 1506147 1509070 2923 0.2
.debug_rnglists 96278 96391 113 0.1
.debug_str 3059490 3081523 22033 0.7
.rodata 104250 104282 32 0.0
.strtab 481887 485135 3248 0.7
.symtab 287248 287952 704 0.2
.text 496340 497108 768 0.2
Decreases (1 build for cc32xx)
platform target config section 77d72a8 5a01f6b change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_abbrev 956984 956937 -47 -0.0
Full report (1 build for cc32xx)
platform target config section 77d72a8 5a01f6b change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 602714 603514 800 0.1
(read/write) 204156 204156 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197568 197568 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 956984 956937 -47 -0.0
.debug_aranges 103664 103792 128 0.1
.debug_frame 350552 350992 440 0.1
.debug_info 19521972 19537458 15486 0.1
.debug_line 2682751 2684446 1695 0.1
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1506147 1509070 2923 0.2
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 96278 96391 113 0.1
.debug_str 3059490 3081523 22033 0.7
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104250 104282 32 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 481887 485135 3248 0.7
.symtab 287248 287952 704 0.2
.text 496340 497108 768 0.2

@github-actions
Copy link

github-actions bot commented May 1, 2023

PR #26300: Size comparison from 77d72a8 to 4445d27

Increases (4 builds for mbed, nrfconnect)
platform target config section 77d72a8 4445d27 change % change
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2494568 2495016 448 0.0
.text 1457252 1457700 448 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1175616 1176396 780 0.1
rodata 132864 132892 28 0.0
text 806424 807176 752 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1120852 1121584 732 0.1
rodata 109684 109712 28 0.0
text 775816 776512 696 0.1
all-clusters-app nrf7002dk_nrf5340_cpuapp (read/write) 1435216 1435932 716 0.0
rodata 228880 228908 28 0.0
text 776960 777648 688 0.1
Full report (4 builds for mbed, nrfconnect)
platform target config section 77d72a8 4445d27 change % change
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2494568 2495016 448 0.0
.bss 216296 216296 0 0.0
.data 5144 5144 0 0.0
.text 1457252 1457700 448 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1175616 1176396 780 0.1
bss 155593 155593 0 0.0
rodata 132864 132892 28 0.0
text 806424 807176 752 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1120852 1121584 732 0.1
bss 154749 154749 0 0.0
rodata 109684 109712 28 0.0
text 775816 776512 696 0.1
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1435216 1435932 716 0.0
bss 135333 135333 0 0.0
rodata 228880 228908 28 0.0
text 776960 777648 688 0.1

@mlepage-google mlepage-google merged commit d53080d into project-chip:master May 1, 2023
@mlepage-google mlepage-google deleted the async-handlesigma3-workhelper branch May 1, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants