Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Disconnect RPC for ESP 32 #26231

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

tehampson
Copy link
Contributor

@tehampson tehampson commented Apr 24, 2023

This fixes Disconnect RPC, by actually clearing the wifi station provision. Without this the device simply reconnects to wifi after disconnection.

Additionally PR #26180 added assert on the task ownership of the chip Stack lock on some SystemLayer timer calls. This PR fix the assert on SystemLayer().ScheduleWork call by acquiring the chipStack Lock before the call

Test:

  • rpcs.chip.rpc.WiFi.Connect(ssid=b'<omitted>', security_type=0, secret=b'<omitted>' // Confirmed we connected to specified AP
  • rpcs.chip.rpc.WiFi.Disconnect() // Confirmed that this disconnected properly from the AP

@github-actions
Copy link

PR #26231: Size comparison from 6025455 to a77e49a

Increases (1 build for cc32xx)
platform target config section 6025455 a77e49a change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19489249 19489251 2 0.0
Full report (3 builds for cc32xx, qpg)
platform target config section 6025455 a77e49a change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 601114 601114 0 0.0
(read/write) 204132 204132 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197544 197544 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 956756 956756 0 0.0
.debug_aranges 103416 103416 0 0.0
.debug_frame 349704 349704 0 0.0
.debug_info 19489249 19489251 2 0.0
.debug_line 2678035 2678035 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1501882 1501882 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 96008 96008 0 0.0
.debug_str 3024877 3024877 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104170 104170 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 477531 477531 0 0.0
.symtab 285936 285936 0 0.0
.text 494824 494824 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1163968 1163968 0 0.0
.bss 99616 99616 0 0.0
.data 856 856 0 0.0
.text 611068 611068 0 0.0
lock-app qpg6105+debug (read/write) 1133328 1133328 0 0.0
.bss 94768 94768 0 0.0
.data 852 852 0 0.0
.text 580424 580424 0 0.0

@tehampson tehampson merged commit d8b703f into project-chip:master Apr 25, 2023
@tehampson tehampson deleted the fix-disconnect-rpc-for-esp32 branch April 25, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants