[Android] Fix EventLoop issue when commissioner restart #26216
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is a problem that the EventLoop terminates as soon as it starts when the Android platform-based commissioner is restarted. Restarting commissioner means calling the following methods in order.
For reference, this commissioner is not implemented as a singleton.
Change overview
mShouldRunEventLoop
is set tofalse
by calling "shutdownCommissioning()" method. In this state, to reinitialize the commissioner and restart the EventLoop, call the "new ChipDeviceController()" constructor. The EventLoop then terminates as soon as it starts.This change sets
mShouldRunEventLoop
totrue
when initializing the EventLoop, fixing an issue where the EventLoop terminates as soon as it starts when the commissioner restarts.Testing
Restart the Android platform-based commissioner.