ExchangeCtx: Fix issue with response timer cancellation #26215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
pullapprove
bot
requested review from
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #26215: Size comparison from de0dfcf to 1d13c0b Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
wqx6
force-pushed
the
fix_cancel_response_timer_issue
branch
from
1d13c0b to
69d020d
Compare
|
PR #26215: Size comparison from fe07225 to 69d020d Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
bzbarsky-apple
approved these changes
Apr 26, 2023
wqx6
force-pushed
the
fix_cancel_response_timer_issue
branch
from
85459f7 to
732ef22
Compare
|
PR #26215: Size comparison from c2a28c8 to 732ef22 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
pidarped
reviewed
Apr 27, 2023
pidarped
approved these changes
Apr 27, 2023
yunhanw-google
approved these changes
Apr 28, 2023
Damian-Nordic
pushed a commit
to Damian-Nordic/connectedhomeip
that referenced
this pull request
Jun 1, 2023
project-chip#26215) * ExchangeCtx: Fix issue with response timer cancellation * Add a boolean to record whether the message starts the reponse timer Cherry-picked from: 98ead72
hawkhan
pushed a commit
to Ayla-Professional-Service/csa_matter
that referenced
this pull request
Dec 20, 2023
…#26215) * ExchangeCtx: Fix issue with response timer cancellation * Add a boolean to record whether the message starts the reponse timer
maciejbaczmanski
pushed a commit
to maciejbaczmanski/connectedhomeip
that referenced
this pull request
Jul 15, 2024
project-chip#26215) * ExchangeCtx: Fix issue with response timer cancellation * Add a boolean to record whether the message starts the reponse timer Cherry-picked from: 98ead72
maciejbaczmanski
pushed a commit
to maciejbaczmanski/connectedhomeip
that referenced
this pull request
Jul 15, 2024
…cellation (project-chip#26215)" This reverts commit 86739f8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an ExchangeContext sends a message that requires a response, a response timer is started. If it subsequently fails to send another message that does not require a response, the previously-started response timer will be cancelled. However, this timer should not be cancelled, as we need to wait for the response to the previous message.
In this PR, we have modified the condition for cancelling the response timer to
messageStartResponseTimer. This means that the response timer will only be cancelled if the exchangeContext fails to send the message that starts the response timer.Additionally, this PR restricts the conditions under which
CancelResponseTimer()is called in other parts of the code.