-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32: Move the BLE deinit after BLE connection is closed, post commissioning #26183
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
dhrishi:esp32/fix_ble_deinit
Apr 25, 2023
Merged
ESP32: Move the BLE deinit after BLE connection is closed, post commissioning #26183
bzbarsky-apple
merged 1 commit into
project-chip:master
from
dhrishi:esp32/fix_ble_deinit
Apr 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple and
lazarkov
April 20, 2023 15:56
pullapprove
bot
requested review from
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
April 20, 2023 15:56
PR #26183: Size comparison from a14e6fb to 6630bd9 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
dhrishi
force-pushed
the
esp32/fix_ble_deinit
branch
2 times, most recently
from
April 20, 2023 16:10
ea9bb8a
to
e7fd721
Compare
PR #26183: Size comparison from a14e6fb to e7fd721 Full report (1 build for cc32xx)
|
bzbarsky-apple
approved these changes
Apr 20, 2023
chshu
approved these changes
Apr 21, 2023
dhrishi
force-pushed
the
esp32/fix_ble_deinit
branch
from
April 21, 2023 08:21
e7fd721
to
7b7782a
Compare
dhrishi
force-pushed
the
esp32/fix_ble_deinit
branch
from
April 21, 2023 08:25
7b7782a
to
06d8373
Compare
PR #26183: Size comparison from f3f7ecd to 06d8373 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
@bzbarsky-apple @andy31415 Can we merge this? |
@dhrishi There are unresolved conversations. |
I've resolved the same. It is the restyler that made the change. If undone, the CI fails as mentioned above |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The BLE deinit is done in kCommissioningComplete event. In some cases, it might happen that BLE connection close is not received from the commissioner but stil it tries to free BLE memory
Solution
Perform deinit when BLE connection is closed with atleast one fabric being active
Tests
Successful commissioning followed by reclaiming the BLE memory