-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ScheduleLambda to schedule work on Matter stack task #26177
Conversation
PR #26177: Size comparison from b187c3e to 62f418f Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
PR #26177: Size comparison from 7b8b8d8 to 5fb7a0f Increases (5 builds for bl602, bl702, cc13x2_26x2, qpg)
Decreases (1 build for cc13x2_26x2)
Full report (17 builds for bl602, bl702, cc13x2_26x2, k32w, mbed, qpg)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, conditional on:
- Auditing that nothing in ScheduleLambda before the ScheduleWork call touches any shared state.
- Filing an issue to correct the documentation to match reality.
PR #26177: Size comparison from 4f081a5 to f154480 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine as long as the CancelTimer callers are not expecting it to take effect immediately...
4774b5a
to
c23bda9
Compare
Indeed, and I've put "this->mFunctionTimerActive = False" inside lambda with the intent that it can be used to check when the timer has actually been cancelled. |
Created new issue to correct documentation: #26538 |
PR #26177: Size comparison from a3b4005 to c23bda9 Increases (2 builds for qpg)
Decreases (1 build for nrfconnect)
Full report (8 builds for linux, mbed, nrfconnect, qpg)
|
c23bda9
to
f130ac4
Compare
PR #26177: Size comparison from 176b0e4 to f130ac4 Increases (3 builds for esp32, psoc6)
Decreases (3 builds for esp32, nrfconnect, psoc6)
Full report (30 builds for cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6)
|
1a01f22
to
0d92158
Compare
PR #26177: Size comparison from a33249d to 0d92158 Increases (5 builds for bl602, bl702, esp32)
Full report (13 builds for bl602, bl702, esp32, k32w, mbed, nrfconnect)
|
0d92158
to
6511eb3
Compare
PR #26177: Size comparison from 5f1a60b to 6511eb3 Increases (4 builds for bl602, nrfconnect, qpg)
Decreases (1 build for bl702)
Full report (13 builds for bl602, bl702, k32w, mbed, nrfconnect, qpg)
|
6511eb3
to
166b00f
Compare
PR #26177: Size comparison from 64bf867 to 166b00f Increases (9 builds for bl602, bl702, efr32, psoc6, telink)
Decreases (6 builds for telink)
Full report (37 builds for bl602, bl702, cyw30739, efr32, linux, mbed, nrfconnect, psoc6, telink)
|
166b00f
to
2e4aabd
Compare
PR #26177: Size comparison from ca83f16 to 2e4aabd Decreases (3 builds for esp32, nrfconnect, psoc6)
Full report (23 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6)
|
Use ScheduleLambda in several places to schedule work on Matter stack for better synchronization.