Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Silabs] Unify silabs device data provider #26107

Conversation

jepenven-silabs
Copy link
Contributor

@jepenven-silabs jepenven-silabs commented Apr 14, 2023

Duplicated code once again. Factory data hack for the 917 can now be removed since 917 is supported by commander.

@github-actions
Copy link

PR #26107: Size comparison from a202465 to 85067a9

Full report (1 build for cc32xx)
platform target config section a202465 85067a9 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643081 643081 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933224 933224 0 0.0
.debug_aranges 87760 87760 0 0.0
.debug_frame 302028 302028 0 0.0
.debug_info 20327053 20327053 0 0.0
.debug_line 2687476 2687476 0 0.0
.debug_loc 2838789 2838789 0 0.0
.debug_ranges 288040 288040 0 0.0
.debug_str 3042053 3042053 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104393 104393 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377625 377625 0 0.0
.symtab 256832 256832 0 0.0
.text 536568 536568 0 0.0

@github-actions
Copy link

PR #26107: Size comparison from a202465 to 4fc45f4

Increases (1 build for cc32xx)
platform target config section a202465 4fc45f4 change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 643081 643249 168 0.0
.debug_aranges 87760 87792 32 0.0
.debug_frame 302028 302140 112 0.0
.debug_info 20327053 20328412 1359 0.0
.debug_line 2687476 2687890 414 0.0
.debug_loc 2838789 2838930 141 0.0
.debug_ranges 288040 288072 32 0.0
.debug_str 3042053 3042155 102 0.0
.rodata 104393 104401 8 0.0
.strtab 377625 377963 338 0.1
.symtab 256832 256976 144 0.1
.text 536568 536728 160 0.0
Full report (1 build for cc32xx)
platform target config section a202465 4fc45f4 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643081 643249 168 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933224 933224 0 0.0
.debug_aranges 87760 87792 32 0.0
.debug_frame 302028 302140 112 0.0
.debug_info 20327053 20328412 1359 0.0
.debug_line 2687476 2687890 414 0.0
.debug_loc 2838789 2838930 141 0.0
.debug_ranges 288040 288072 32 0.0
.debug_str 3042053 3042155 102 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104393 104401 8 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377625 377963 338 0.1
.symtab 256832 256976 144 0.1
.text 536568 536728 160 0.0

@jepenven-silabs jepenven-silabs force-pushed the silabs_refactor_device_data_provider branch from 4fc45f4 to a2843a0 Compare April 17, 2023 14:37
@github-actions
Copy link

PR #26107: Size comparison from 5cdb0a5 to a2843a0

Full report (1 build for cc32xx)
platform target config section 5cdb0a5 a2843a0 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643249 643249 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933224 933224 0 0.0
.debug_aranges 87792 87792 0 0.0
.debug_frame 302140 302140 0 0.0
.debug_info 20328411 20328411 0 0.0
.debug_line 2687890 2687890 0 0.0
.debug_loc 2838930 2838930 0 0.0
.debug_ranges 288072 288072 0 0.0
.debug_str 3042155 3042155 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104401 104401 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377963 377963 0 0.0
.symtab 256976 256976 0 0.0
.text 536728 536728 0 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants