-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Unify silabs device data provider #26107
Merged
jepenven-silabs
merged 2 commits into
project-chip:master
from
jepenven-silabs:silabs_refactor_device_data_provider
Apr 17, 2023
Merged
[Silabs] Unify silabs device data provider #26107
jepenven-silabs
merged 2 commits into
project-chip:master
from
jepenven-silabs:silabs_refactor_device_data_provider
Apr 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepenven-silabs
force-pushed
the
silabs_refactor_device_data_provider
branch
from
April 14, 2023 18:25
d9ed16e
to
85067a9
Compare
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kcoppock
April 14, 2023 18:25
pullapprove
bot
requested review from
mlepage-google,
msandstedt,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
April 14, 2023 18:25
jmartinez-silabs
approved these changes
Apr 14, 2023
PR #26107: Size comparison from a202465 to 85067a9 Full report (1 build for cc32xx)
|
bzbarsky-apple
approved these changes
Apr 14, 2023
PR #26107: Size comparison from a202465 to 4fc45f4 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
jepenven-silabs
force-pushed
the
silabs_refactor_device_data_provider
branch
from
April 17, 2023 14:37
4fc45f4
to
a2843a0
Compare
PR #26107: Size comparison from 5cdb0a5 to a2843a0 Full report (1 build for cc32xx)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicated code once again.
Factory data hack for the 917 can now be removed since 917 is supported by commander.