[Chef] Fix compile -a doesn't work on ESP32 #26095

erwinpan1 · 2023-04-14T01:59:09Z

with chef.py --automated_test_stamp we can assign timestamp as software version string when compiling chef sample device. However, this failed on ESP32. On ESP32, I found that it uses PROJECT_VER to overwrite CHIP_DEVICE_CONFIG_DEVICE_SOFTWARE_VERSION_STRING, so I set it in the esp32's CMakeLists.txt

The root cause is the function [ConfigurationManagerImpl::GetSoftwareVersionString](CHIP_ERROR ConfigurationManagerImpl::GetSoftwareVersionString(char * buf, size_t bufSize)) it calls esp_ota_get_app_description which uses PROJECT_VER in CMakeFile as the version string.

github-actions · 2023-04-14T02:19:10Z

PR #26095: Size comparison from 62974a0 to aa8f4f9

Increases (1 build for cc32xx)

platform	target	config	section	`62974a0`	`aa8f4f9`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20326060	20326061	1	0.0

Full report (1 build for cc32xx)

platform	target	config	section	`62974a0`	`aa8f4f9`	change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	643081	643081	0
			(read/write)	203848	203848	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197248	197248	0
			.comment	194	194	0
			.data	1480	1480	0
			.debug_abbrev	933224	933224	0
			.debug_aranges	87760	87760	0
			.debug_frame	302028	302028	0
			.debug_info	20326060	20326061	1
			.debug_line	`2687403`	`2687403`	0
			.debug_loc	2838361	2838361	0
			.debug_ranges	288040	288040	0
			.debug_str	3042379	3042379	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	104393	104393	0
			.shstrtab	232	232	0
			.stab	204	204	0
			.stabstr	441	441	0
			.stack	2048	2048	0
			.strtab	377626	377626	0
			.symtab	256832	256832	0
			.text	536568	536568	0

andy31415 · 2023-04-14T16:34:24Z

@erwinpan1 !!!!!!!!!! Please delete the instructions below and replace with PR description ...

github-actions · 2023-04-17T00:31:09Z

PR #26095: Size comparison from 2e4064e to 7a452b7

Decreases (1 build for cc32xx)

platform	target	config	section	2e4064e1	`7a452b7`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20328412	20328410	-2	-0.0

Full report (4 builds for cc32xx, mbed, qpg)

platform	target	config	section	2e4064e1	`7a452b7`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0	0.0
			(read only)	643249	643249	0	0.0
			(read/write)	203848	203848	0	0.0
			.ARM.attributes	44	44	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	197248	197248	0	0.0
			.comment	194	194	0	0.0
			.data	1480	1480	0	0.0
			.debug_abbrev	933224	933224	0	0.0
			.debug_aranges	87792	87792	0	0.0
			.debug_frame	302140	302140	0	0.0
			.debug_info	20328412	20328410	-2	-0.0
			.debug_line	2687890	2687890	0	0.0
			.debug_loc	2838930	2838930	0	0.0
			.debug_ranges	288072	288072	0	0.0
			.debug_str	3042155	3042155	0	0.0
			.ramVecs	780	780	0	0.0
			.resetVecs	64	64	0	0.0
			.rodata	104401	104401	0	0.0
			.shstrtab	232	232	0	0.0
			.stab	204	204	0	0.0
			.stabstr	441	441	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	377963	377963	0	0.0
			.symtab	256976	256976	0	0.0
			.text	536728	536728	0	0.0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	`2466336`	`2466336`	0	0.0
			.bss	215960	215960	0	0.0
			.data	5888	5888	0	0.0
			.text	1428980	1428980	0	0.0
qpg	lighting-app	qpg6105+debug	(read/write)	1166704	1166704	0	0.0
			.bss	99308	99308	0	0.0
			.data	856	856	0	0.0
			.text	613804	613804	0	0.0
	lock-app	qpg6105+debug	(read/write)	1136776	1136776	0	0.0
			.bss	94452	94452	0	0.0
			.data	860	860	0	0.0
			.text	583872	583872	0	0.0

examples/chef/esp32/CMakeLists.txt

examples/chef/chef.py

github-actions · 2023-04-17T16:37:45Z

PR #26095: Size comparison from 5cdb0a5 to 638ffab

Increases (1 build for nrfconnect)

platform	target	config	section	`5cdb0a5`	`638ffab`	change	% change
nrfconnect	all-clusters-app	nrf7002dk_nrf5340_cpuapp	text	775784	775788	4	0.0

Decreases (1 build for nrfconnect)

platform	target	config	section	`5cdb0a5`	`638ffab`	change	% change
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	text	804836	804832	-4	-0.0

Full report (7 builds for cc32xx, mbed, nrfconnect, qpg)

platform	target	config	section	`5cdb0a5`	`638ffab`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0	0.0
			(read only)	643249	643249	0	0.0
			(read/write)	203848	203848	0	0.0
			.ARM.attributes	44	44	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	197248	197248	0	0.0
			.comment	194	194	0	0.0
			.data	1480	1480	0	0.0
			.debug_abbrev	933224	933224	0	0.0
			.debug_aranges	87792	87792	0	0.0
			.debug_frame	302140	302140	0	0.0
			.debug_info	20328411	20328411	0	0.0
			.debug_line	2687890	2687890	0	0.0
			.debug_loc	2838930	2838930	0	0.0
			.debug_ranges	288072	288072	0	0.0
			.debug_str	3042155	3042155	0	0.0
			.ramVecs	780	780	0	0.0
			.resetVecs	64	64	0	0.0
			.rodata	104401	104401	0	0.0
			.shstrtab	232	232	0	0.0
			.stab	204	204	0	0.0
			.stabstr	441	441	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	377963	377963	0	0.0
			.symtab	256976	256976	0	0.0
			.text	536728	536728	0	0.0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	`2466336`	`2466336`	0	0.0
			.bss	215960	215960	0	0.0
			.data	5888	5888	0	0.0
			.text	1428980	1428980	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read only)	4	4	0	0.0
			(read/write)	`1173892`	`1173892`	0	0.0
			bss	155557	155557	0	0.0
			rodata	132740	132740	0	0.0
			text	804836	804832	-4	-0.0
	all-clusters-minimal-app	nrf52840dk_nrf52840	(read only)	4	4	0	0.0
			(read/write)	1119140	1119140	0	0.0
			bss	154713	154713	0	0.0
			rodata	109556	109556	0	0.0
			text	774228	774228	0	0.0
	all-clusters-app	nrf7002dk_nrf5340_cpuapp	(read only)	4	4	0	0.0
			(read/write)	1433952	1433952	0	0.0
			bss	135297	135297	0	0.0
			rodata	228784	228784	0	0.0
			text	775784	775788	4	0.0
qpg	lighting-app	qpg6105+debug	(read/write)	1166704	1166704	0	0.0
			.bss	99308	99308	0	0.0
			.data	856	856	0	0.0
			.text	613804	613804	0	0.0
	lock-app	qpg6105+debug	(read/write)	1136776	1136776	0	0.0
			.bss	94452	94452	0	0.0
			.data	860	860	0	0.0
			.text	583872	583872	0	0.0

github-actions · 2023-04-19T06:40:11Z

PR #26095: Size comparison from b8368a1 to 2c70856

Full report (1 build for cc32xx)

platform	target	config	section	`b8368a1`	`2c70856`
cc32xx	lock	CC3235SF_LAUNCHXL		0	0
			(read only)	643249	643249
			(read/write)	203848	203848
			.ARM.attributes	44	44
			.ARM.exidx	8	8
			.bss	197248	197248
			.comment	194	194
			.data	1480	1480
			.debug_abbrev	933224	933224
			.debug_aranges	87792	87792
			.debug_frame	302140	302140
			.debug_info	20330829	20330829
			.debug_line	`2687904`	`2687904`
			.debug_loc	`2838960`	`2838960`
			.debug_ranges	288072	288072
			.debug_str	3042335	3042335
			.ramVecs	780	780
			.resetVecs	64	64
			.rodata	104401	104401
			.shstrtab	232	232
			.stab	204	204
			.stabstr	441	441
			.stack	2048	2048
			.strtab	377963	377963
			.symtab	256976	256976
			.text	536728	536728

with `chef.py --automated_test_stamp` we can assign timestamp as software version string when compiling chef sample device. However, this failed on ESP32. On ESP32, I found that it uses PROJECT_VER to overwrite CHIP_DEVICE_CONFIG_DEVICE_SOFTWARE_VERSION_STRING, so I set it in the esp32's CMakeLists.txt

github-actions bot added the examples label Apr 14, 2023

erwinpan1 force-pushed the master branch from 62183b6 to aa8f4f9 Compare April 14, 2023 01:59

pullapprove bot requested review from sharadb-amazon, tecimovic, turon, vijs, vivien-apple, woody-apple, xylophone21, younghak-hwang, yufengwangca and yunhanw-google April 14, 2023 02:00

pullapprove bot added the review - pending label Apr 14, 2023

erwinpan1 force-pushed the master branch from aa8f4f9 to 7a452b7 Compare April 17, 2023 00:10

tcarmelveilleux reviewed Apr 17, 2023

View reviewed changes

examples/chef/esp32/CMakeLists.txt Show resolved Hide resolved

tcarmelveilleux reviewed Apr 17, 2023

View reviewed changes

examples/chef/chef.py Outdated Show resolved Hide resolved

erwinpan1 force-pushed the master branch from 7a452b7 to 89c6baf Compare April 17, 2023 15:51

tcarmelveilleux approved these changes Apr 18, 2023

View reviewed changes

erwinpan1 force-pushed the master branch from 638ffab to 2c70856 Compare April 19, 2023 06:29

erwinpan1 added 3 commits April 20, 2023 13:07

chef.py set default sw_ver_string from "v1.0" to""

76bf2f3

Add comment in examples/chef/esp32/CMakeLists.txt

0d93920

erwinpan1 force-pushed the master branch from 2c70856 to 0d93920 Compare April 20, 2023 05:07

chshu approved these changes Apr 20, 2023

View reviewed changes

pullapprove bot added review - approved and removed review - pending labels Apr 20, 2023

andy31415 merged commit 2eaf956 into project-chip:master Apr 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Chef] Fix compile -a doesn't work on ESP32 #26095

[Chef] Fix compile -a doesn't work on ESP32 #26095

erwinpan1 commented Apr 14, 2023 •

edited

Loading

github-actions bot commented Apr 14, 2023

andy31415 commented Apr 14, 2023

github-actions bot commented Apr 17, 2023

github-actions bot commented Apr 17, 2023

github-actions bot commented Apr 19, 2023

[Chef] Fix compile -a doesn't work on ESP32 #26095

[Chef] Fix compile -a doesn't work on ESP32 #26095

Conversation

erwinpan1 commented Apr 14, 2023 • edited Loading

github-actions bot commented Apr 14, 2023

andy31415 commented Apr 14, 2023

github-actions bot commented Apr 17, 2023

github-actions bot commented Apr 17, 2023

github-actions bot commented Apr 19, 2023

erwinpan1 commented Apr 14, 2023 •

edited

Loading