Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] fix README.md of CHIP controller (Android CHIPTool link) #26050

Conversation

jannisgaertner
Copy link
Contributor

Problem:
Link to Android chip-tool in src/controller/README.md was wrong.

Fix:
Changed link in from [../android/CHIPTool](../android/CHIPTool) to [../../examples/android/CHIPTool](../../examples/android/CHIPTool).

Changed android CHIPTool link in src/controller/README.md from ../android/CHIPTool to ../../examples/android/CHIPTool
@CLAassistant
Copy link

CLAassistant commented Apr 11, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

PR #26050: Size comparison from 507fc52 to 03e420a

Increases (1 build for cc32xx)
platform target config section 507fc52 03e420a change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20303340 20303341 1 0.0
Full report (1 build for cc32xx)
platform target config section 507fc52 03e420a change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642945 642945 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933129 933129 0 0.0
.debug_aranges 87616 87616 0 0.0
.debug_frame 301352 301352 0 0.0
.debug_info 20303340 20303341 1 0.0
.debug_line 2679963 2679963 0 0.0
.debug_loc 2824782 2824782 0 0.0
.debug_ranges 286208 286208 0 0.0
.debug_str 3039557 3039557 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104353 104353 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377533 377533 0 0.0
.symtab 256800 256800 0 0.0
.text 536472 536472 0 0.0

@andy31415
Copy link
Contributor

@jannisgaertner could you run restyle (e.g. ./scripts/helpers/restyle-diff.sh or using the instructions from the restyled check)?

@github-actions
Copy link

PR #26050: Size comparison from 00e5976 to 318eeb2

Full report (1 build for cc32xx)
platform target config section 00e5976 318eeb2 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642953 642953 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933129 933129 0 0.0
.debug_aranges 87616 87616 0 0.0
.debug_frame 301352 301352 0 0.0
.debug_info 20303347 20303347 0 0.0
.debug_line 2679969 2679969 0 0.0
.debug_loc 2824782 2824782 0 0.0
.debug_ranges 286208 286208 0 0.0
.debug_str 3039567 3039567 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104353 104353 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377533 377533 0 0.0
.symtab 256800 256800 0 0.0
.text 536480 536480 0 0.0

@andy31415 andy31415 merged commit a2d1596 into project-chip:master May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants