-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Documentation] fix README.md of CHIP controller (Android CHIPTool link) #26050
Merged
andy31415
merged 3 commits into
project-chip:master
from
jannisgaertner:chipcontroller-documentation-android-link
May 8, 2023
Merged
[Documentation] fix README.md of CHIP controller (Android CHIPTool link) #26050
andy31415
merged 3 commits into
project-chip:master
from
jannisgaertner:chipcontroller-documentation-android-link
May 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed android CHIPTool link in src/controller/README.md from ../android/CHIPTool to ../../examples/android/CHIPTool
PR #26050: Size comparison from 507fc52 to 03e420a Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
andy31415
approved these changes
Apr 11, 2023
@jannisgaertner could you run restyle (e.g. |
bzbarsky-apple
approved these changes
Apr 11, 2023
PR #26050: Size comparison from 00e5976 to 318eeb2 Full report (1 build for cc32xx)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Link to Android chip-tool in src/controller/README.md was wrong.
Fix:
Changed link in from
[../android/CHIPTool](../android/CHIPTool)
to[../../examples/android/CHIPTool](../../examples/android/CHIPTool)
.