Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[darwin] Update BLEScannerDelegate interface to have both a add and a… #26001

Merged
merged 1 commit into from
Apr 18, 2023
Merged

[darwin] Update BLEScannerDelegate interface to have both a add and a… #26001

merged 1 commit into from
Apr 18, 2023

Conversation

vivien-apple
Copy link
Contributor

… remove method

Problem

There is no mechanism to know when a peripheral has been removed.

@vivien-apple vivien-apple self-assigned this Apr 6, 2023
@vivien-apple vivien-apple force-pushed the Darwin_UpdateBleScannerDelegate branch 2 times, most recently from d1fc182 to 7578f02 Compare April 11, 2023 10:23
@github-actions
Copy link

PR #26001: Size comparison from ed5ebd2 to 7578f02

Full report (3 builds for cc32xx, qpg)
platform target config section ed5ebd2 7578f02 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642945 642945 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933129 933129 0 0.0
.debug_aranges 87616 87616 0 0.0
.debug_frame 301352 301352 0 0.0
.debug_info 20303341 20303341 0 0.0
.debug_line 2679963 2679963 0 0.0
.debug_loc 2824782 2824782 0 0.0
.debug_ranges 286208 286208 0 0.0
.debug_str 3039557 3039557 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104353 104353 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377533 377533 0 0.0
.symtab 256800 256800 0 0.0
.text 536472 536472 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1153624 1153624 0 0.0
.bss 97404 97404 0 0.0
.data 852 852 0 0.0
.text 600720 600720 0 0.0
lock-app qpg6105+debug (read/write) 1122240 1122240 0 0.0
.bss 92540 92540 0 0.0
.data 856 856 0 0.0
.text 569340 569340 0 0.0

@vivien-apple vivien-apple force-pushed the Darwin_UpdateBleScannerDelegate branch from 7578f02 to 942ed7f Compare April 12, 2023 10:19
@github-actions
Copy link

PR #26001: Size comparison from d85124e to 942ed7f

Decreases (1 build for cc32xx)
platform target config section d85124e 942ed7f change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20303347 20303346 -1 -0.0
Full report (1 build for cc32xx)
platform target config section d85124e 942ed7f change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642953 642953 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933129 933129 0 0.0
.debug_aranges 87616 87616 0 0.0
.debug_frame 301352 301352 0 0.0
.debug_info 20303347 20303346 -1 -0.0
.debug_line 2679969 2679969 0 0.0
.debug_loc 2824782 2824782 0 0.0
.debug_ranges 286208 286208 0 0.0
.debug_str 3039567 3039567 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104353 104353 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377533 377533 0 0.0
.symtab 256800 256800 0 0.0
.text 536480 536480 0 0.0

@vivien-apple vivien-apple force-pushed the Darwin_UpdateBleScannerDelegate branch from 942ed7f to 65fa8d8 Compare April 12, 2023 13:13
@github-actions
Copy link

PR #26001: Size comparison from daa30ec to 65fa8d8

Full report (1 build for cc32xx)
platform target config section daa30ec1 65fa8d8 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642953 642953 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933129 933129 0 0.0
.debug_aranges 87616 87616 0 0.0
.debug_frame 301352 301352 0 0.0
.debug_info 20303347 20303347 0 0.0
.debug_line 2679969 2679969 0 0.0
.debug_loc 2824782 2824782 0 0.0
.debug_ranges 286208 286208 0 0.0
.debug_str 3039567 3039567 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104353 104353 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377533 377533 0 0.0
.symtab 256800 256800 0 0.0
.text 536480 536480 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 19909ce into project-chip:master Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@arkq arkq Awaiting requested review from arkq

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees

@vivien-apple vivien-apple

Labels
darwin examples platform review - approved tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vivien-apple @andy31415 @bzbarsky-apple