Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add operational resolution retries in OperationalSessionSetup. #25991

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Add operational resolution retries in OperationalSessionSetup. #25991

merged 1 commit into from
Apr 7, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

Apparently some border routers are broken and don't actually do the "multicast" part of mDNS right, leading to resolve failures if the advertisement is not available during the initial unicast-response probe. Work around that by retrying operational discovery a few times during commissioning.

@github-actions github-actions bot added the app label Apr 5, 2023
@bzbarsky-apple bzbarsky-apple force-pushed the add-operational-resolve-retries branch from 3fea0ec to 6d967cf Compare April 5, 2023 20:59
@github-actions
Copy link

github-actions bot commented Apr 5, 2023 •
edited
Loading

PR #25991: Size comparison from 6d35975 to 6d967cf

Increases (31 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, k32w, linux, mbed, psoc6, qpg)
platform target config section 6d35975 6d967cf change % change
bl602 lighting-app bl602 (read/write) 1355210 1355418 208 0.0
.text 1029830 1029976 146 0.0
bl602+rpc (read/write) 1400382 1400590 208 0.0
.text 1060510 1060656 146 0.0
bl702 lighting-app bl702 (read/write) 1183687 1183895 208 0.0
.debug_abbrev 1551688 1551698 10 0.0
.debug_aranges 133944 133952 8 0.0
.debug_frame 492632 492672 40 0.0
.debug_info 40755237 40755532 295 0.0
.debug_line 5298432 5298830 398 0.0
.debug_loc 3433903 3433986 83 0.0
.debug_ranges 374376 374408 32 0.0
.debug_str 3593197 3593348 151 0.0
.rodata 105664 105728 64 0.1
.strtab 572622 572733 111 0.0
.symtab 173744 173760 16 0.0
.text 957740 957884 144 0.0
bl702+rpc (read/write) 1275171 1275379 208 0.0
.debug_abbrev 1703908 1703918 10 0.0
.debug_aranges 142304 142312 8 0.0
.debug_frame 520800 520840 40 0.0
.debug_info 45402318 45402614 296 0.0
.debug_line 5704695 5705093 398 0.0
.debug_loc 3632905 3632961 56 0.0
.debug_ranges 398376 398408 32 0.0
.debug_str 3997864 3998015 151 0.0
.rodata 119888 119952 64 0.1
.strtab 634432 634543 111 0.0
.symtab 192368 192384 16 0.0
.text 1033756 1033902 146 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 680695 680799 104 0.0
.text 593364 593468 104 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643967 644071 104 0.0
.text 566840 566944 104 0.0
lock-ftd LP_CC2652R7 (read only) 678071 678175 104 0.0
.text 601904 602008 104 0.0
lock-mtd LP_CC2652R7 (read only) 664299 664483 184 0.0
.rodata 102507 102571 64 0.1
.text 561312 561432 120 0.0
pump-app LP_CC2652R7 (read only) 690747 690923 176 0.0
.rodata 89747 89811 64 0.1
.text 600520 600632 112 0.0
pump-controller-app LP_CC2652R7 (read only) 675635 675827 192 0.0
.rodata 85499 85563 64 0.1
.text 589656 589784 128 0.0
shell LP_CC2652R7 (read only) 673558 673662 104 0.0
.text 587936 588040 104 0.0
cc32xx lock CC3235SF_LAUNCHXL (read only) 642737 642945 208 0.0
.debug_abbrev 933099 933109 10 0.0
.debug_aranges 87608 87616 8 0.0
.debug_frame 301328 301352 24 0.0
.debug_info 20302986 20303337 351 0.0
.debug_line 2679748 2679952 204 0.0
.debug_loc 2824679 2824781 102 0.0
.debug_ranges 286200 286208 8 0.0
.debug_str 3039406 3039557 151 0.0
.rodata 104289 104353 64 0.1
.strtab 377422 377533 111 0.0
.symtab 256768 256800 32 0.0
.text 536328 536472 144 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 533506 533626 120 0.0
.app_xip_area 414076 414196 120 0.0
lock cyw930739m2evb_01 (read/write) 537882 538002 120 0.0
.app_xip_area 413164 413284 120 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 554766 554870 104 0.0
.app_xip_area 436096 436200 104 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1017712 1017904 192 0.0
.text 836864 837056 192 0.0
BRD4187C (read/write) 1025324 1025500 176 0.0
.text 838752 838928 176 0.0
lock-app BRD4161A+wf200 (read/write) 1070728 1070840 112 0.0
.text 895424 895536 112 0.0
window-app BRD4187C (read/write) 1141548 1141740 192 0.0
.text 970652 970844 192 0.0
k32w contact k32w0+release (read/write) 673736 673864 128 0.0
.text 574580 574708 128 0.0
light k32w0+release (read/write) 672860 673004 144 0.0
.text 574052 574196 144 0.0
lock k32w0+release (read/write) 627588 627716 128 0.0
.text 547168 547296 128 0.0
linux chip-tool-ipv6only arm64 (read only) 12113692 12114348 656 0.0
.rodata 566156 566220 64 0.0
.text 9785268 9785860 592 0.0
thermostat-no-ble arm64 (read only) 2500492 2501148 656 0.0
.rodata 129400 129464 64 0.0
.text 2108784 2109376 592 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2465472 2465664 192 0.0
.text 1428116 1428308 192 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1760444 1760636 192 0.0
.debug_abbrev 1259797 1259807 10 0.0
.debug_aranges 111816 111824 8 0.0
.debug_frame 376196 376228 32 0.0
.debug_info 28088661 28088995 334 0.0
.debug_line 3822069 3822303 234 0.0
.debug_loc 3723184 3723272 88 0.0
.debug_ranges 368016 368048 32 0.0
.debug_str 3550474 3550625 151 0.0
.strtab 582791 582902 111 0.0
.symtab 426640 426672 32 0.0
.text 1559552 1559744 192 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1700484 1700676 192 0.0
.debug_abbrev 1241661 1241671 10 0.0
.debug_aranges 110968 110976 8 0.0
.debug_frame 378280 378312 32 0.0
.debug_info 27548067 27548402 335 0.0
.debug_line 3825472 3825706 234 0.0
.debug_loc 3705254 3705342 88 0.0
.debug_ranges 365864 365896 32 0.0
.debug_str 3536400 3536551 151 0.0
.strtab 541993 542104 111 0.0
.symtab 411456 411488 32 0.0
.text 1500400 1500592 192 0.0
light cy8ckit_062s2_43012 (read/write) 1614212 1614420 208 0.0
.debug_abbrev 1076959 1076969 10 0.0
.debug_aranges 103176 103184 8 0.0
.debug_frame 348560 348592 32 0.0
.debug_info 22906491 22906824 333 0.0
.debug_line 3376393 3376627 234 0.0
.debug_loc 3380061 3380149 88 0.0
.debug_ranges 324400 324432 32 0.0
.debug_str 3335079 3335230 151 0.0
.strtab 477080 477191 111 0.0
.symtab 379088 379120 32 0.0
.text 1422392 1422600 208 0.0
lock cy8ckit_062s2_43012 (read/write) 1671364 1671572 208 0.0
.debug_abbrev 1079191 1079201 10 0.0
.debug_aranges 103576 103584 8 0.0
.debug_frame 350300 350332 32 0.0
.debug_info 23157847 23158179 332 0.0
.debug_line 3378118 3378352 234 0.0
.debug_loc 3403928 3404016 88 0.0
.debug_ranges 327000 327032 32 0.0
.debug_str 3353596 3353747 151 0.0
.strtab 480477 480588 111 0.0
.symtab 381280 381312 32 0.0
.text 1451768 1451976 208 0.0
qpg lighting-app qpg6105+debug (read/write) 1153432 1153616 184 0.0
.text 600528 600712 184 0.0
lock-app qpg6105+debug (read/write) 1122048 1122240 192 0.0
.text 569148 569340 192 0.0
Decreases (6 builds for cc13x2_26x2)
platform target config section 6d35975 6d967cf change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 170560 170456 -104 -0.1
lock-ftd LP_CC2652R7 (read/write) 170648 170544 -104 -0.1
lock-mtd LP_CC2652R7 (read/write) 179580 179396 -184 -0.1
pump-app LP_CC2652R7 (read/write) 158716 158540 -176 -0.1
pump-controller-app LP_CC2652R7 (read/write) 173964 173772 -192 -0.1
shell LP_CC2652R7 (read/write) 179768 179664 -104 -0.1
Full report (31 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, k32w, linux, mbed, psoc6, qpg)
platform target config section 6d35975 6d967cf change % change
bl602 lighting-app bl602 (read/write) 1355210 1355418 208 0.0
.bss 94778 94778 0 0.0
.data 9776 9776 0 0.0
.text 1029830 1029976 146 0.0
bl602+rpc (read/write) 1400382 1400590 208 0.0
.bss 102826 102826 0 0.0
.data 10168 10168 0 0.0
.text 1060510 1060656 146 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1183687 1183895 208 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 70721 70721 0 0.0
.bss_psram 24368 24368 0 0.0
.comment 48 48 0 0.0
.data 4088 4088 0 0.0
.debug_abbrev 1551688 1551698 10 0.0
.debug_aranges 133944 133952 8 0.0
.debug_frame 492632 492672 40 0.0
.debug_info 40755237 40755532 295 0.0
.debug_line 5298432 5298830 398 0.0
.debug_loc 3433903 3433986 83 0.0
.debug_ranges 374376 374408 32 0.0
.debug_str 3593197 3593348 151 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 105664 105728 64 0.1
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 572622 572733 111 0.0
.symtab 173744 173760 16 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
957740 957884 144 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1275171 1275379 208 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 78769 78769 0 0.0
.bss_psram 24768 24768 0 0.0
.comment 48 48 0 0.0
.data 4648 4648 0 0.0
.debug_abbrev 1703908 1703918 10 0.0
.debug_aranges 142304 142312 8 0.0
.debug_frame 520800 520840 40 0.0
.debug_info 45402318 45402614 296 0.0
.debug_line 5704695 5705093 398 0.0
.debug_loc 3632905 3632961 56 0.0
.debug_ranges 398376 398408 32 0.0
.debug_str 3997864 3998015 151 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 119888 119952 64 0.1
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 634432 634543 111 0.0
.symtab 192368 192384 16 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1033756 1033902 146 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 680695 680799 104 0.0
(read/write) 170560 170456 -104 -0.1
.bss 80948 80948 0 0.0
.data 3352 3352 0 0.0
.rodata 87015 87015 0 0.0
.text 593364 593468 104 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643967 644071 104 0.0
(read/write) 157616 157616 0 0.0
.bss 80148 80148 0 0.0
.data 3352 3352 0 0.0
.rodata 76807 76807 0 0.0
.text 566840 566944 104 0.0
lock-ftd LP_CC2652R7 (read only) 678071 678175 104 0.0
(read/write) 170648 170544 -104 -0.1
.bss 78500 78500 0 0.0
.data 3316 3316 0 0.0
.rodata 75687 75687 0 0.0
.text 601904 602008 104 0.0
lock-mtd LP_CC2652R7 (read only) 664299 664483 184 0.0
(read/write) 179580 179396 -184 -0.1
.bss 73660 73660 0 0.0
.data 3316 3316 0 0.0
.rodata 102507 102571 64 0.1
.text 561312 561432 120 0.0
pump-app LP_CC2652R7 (read only) 690747 690923 176 0.0
(read/write) 158716 158540 -176 -0.1
.bss 78476 78476 0 0.0
.data 3280 3280 0 0.0
.rodata 89747 89811 64 0.1
.text 600520 600632 112 0.0
pump-controller-app LP_CC2652R7 (read only) 675635 675827 192 0.0
(read/write) 173964 173772 -192 -0.1
.bss 78612 78612 0 0.0
.data 3304 3304 0 0.0
.rodata 85499 85563 64 0.1
.text 589656 589784 128 0.0
shell LP_CC2652R7 (read only) 673558 673662 104 0.0
(read/write) 179768 179664 -104 -0.1
.bss 83020 83020 0 0.0
.data 3348 3348 0 0.0
.rodata 85310 85310 0 0.0
.text 587936 588040 104 0.0
cc32xx lock CC3235SF_LAUNCHXL (read only) 642737 642945 208 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933099 933109 10 0.0
.debug_aranges 87608 87616 8 0.0
.debug_frame 301328 301352 24 0.0
.debug_info 20302986 20303337 351 0.0
.debug_line 2679748 2679952 204 0.0
.debug_loc 2824679 2824781 102 0.0
.debug_ranges 286200 286208 8 0.0
.debug_str 3039406 3039557 151 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104289 104353 64 0.1
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377422 377533 111 0.0
.symtab 256768 256800 32 0.0
.text 0 0 0 0.0
536328 536472 144 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 533506 533626 120 0.0
.app_xip_area 414076 414196 120 0.0
.bss 61848 61848 0 0.0
.data 740 740 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 537882 538002 120 0.0
.app_xip_area 413164 413284 120 0.0
.bss 67128 67128 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 554766 554870 104 0.0
.app_xip_area 436096 436200 104 0.0
.bss 61136 61136 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1017712 1017904 192 0.0
.bss 178700 178700 0 0.0
.data 2128 2128 0 0.0
.text 836864 837056 192 0.0
BRD4187C (read/write) 1025324 1025500 176 0.0
.bss 159200 159200 0 0.0
.data 2776 2776 0 0.0
.text 838752 838928 176 0.0
lock-app BRD4161A+wf200 (read/write) 1070728 1070840 112 0.0
.bss 173140 173140 0 0.0
.data 2144 2144 0 0.0
.text 895424 895536 112 0.0
window-app BRD4187C (read/write) 1141548 1141740 192 0.0
.bss 143632 143632 0 0.0
.data 2668 2668 0 0.0
.text 970652 970844 192 0.0
k32w contact k32w0+release (read/write) 673736 673864 128 0.0
.bss 65532 65532 0 0.0
.data 2224 2224 0 0.0
.text 574580 574708 128 0.0
light k32w0+release (read/write) 672860 673004 144 0.0
.bss 65196 65196 0 0.0
.data 2212 2212 0 0.0
.text 574052 574196 144 0.0
lock k32w0+release (read/write) 627588 627716 128 0.0
.bss 63268 63268 0 0.0
.data 2136 2136 0 0.0
.text 547168 547296 128 0.0
linux chip-tool-ipv6only arm64 (read only) 12113692 12114348 656 0.0
(read/write) 742616 742616 0 0.0
.bss 34392 34392 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 684496 684496 0 0.0
.dynamic 560 560 0 0.0
.got 15504 15504 0 0.0
.init 24 24 0 0.0
.init_array 216 216 0 0.0
.rodata 566156 566220 64 0.0
.text 9785268 9785860 592 0.0
thermostat-no-ble arm64 (read only) 2500492 2501148 656 0.0
(read/write) 145192 145192 0 0.0
.bss 56344 56344 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 77648 77648 0 0.0
.dynamic 560 560 0 0.0
.got 5360 5360 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 129400 129464 64 0.0
.text 2108784 2109376 592 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2465472 2465664 192 0.0
.bss 215964 215964 0 0.0
.data 5880 5880 0 0.0
.text 1428116 1428308 192 0.0
psoc6 all-clusters cy8ckit_062s2_43012 0 0 0 0.0
(read only) 840840 840840 0 0.0
(read/write) 1760444 1760636 192 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189864 189864 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2640 2640 0 0.0
.debug_abbrev 1259797 1259807 10 0.0
.debug_aranges 111816 111824 8 0.0
.debug_frame 376196 376228 32 0.0
.debug_info 28088661 28088995 334 0.0
.debug_line 3822069 3822303 234 0.0
.debug_loc 3723184 3723272 88 0.0
.debug_ranges 368016 368048 32 0.0
.debug_str 3550474 3550625 151 0.0
.heap 840840 840840 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 582791 582902 111 0.0
.symtab 426640 426672 32 0.0
.text 1559552 1559744 192 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 0 0 0 0.0
(read only) 841648 841648 0 0.0
(read/write) 1700484 1700676 192 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189064 189064 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2632 2632 0 0.0
.debug_abbrev 1241661 1241671 10 0.0
.debug_aranges 110968 110976 8 0.0
.debug_frame 378280 378312 32 0.0
.debug_info 27548067 27548402 335 0.0
.debug_line 3825472 3825706 234 0.0
.debug_loc 3705254 3705342 88 0.0
.debug_ranges 365864 365896 32 0.0
.debug_str 3536400 3536551 151 0.0
.heap 841648 841648 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 541993 542104 111 0.0
.symtab 411456 411488 32 0.0
.text 1500400 1500592 192 0.0
.zero.table 8 8 0 0.0
light cy8ckit_062s2_43012 0 0 0 0.0
(read only) 849912 849912 0 0.0
(read/write) 1614212 1614420 208 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180968 180968 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1076959 1076969 10 0.0
.debug_aranges 103176 103184 8 0.0
.debug_frame 348560 348592 32 0.0
.debug_info 22906491 22906824 333 0.0
.debug_line 3376393 3376627 234 0.0
.debug_loc 3380061 3380149 88 0.0
.debug_ranges 324400 324432 32 0.0
.debug_str 3335079 3335230 151 0.0
.heap 849912 849912 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 477080 477191 111 0.0
.symtab 379088 379120 32 0.0
.text 1422392 1422600 208 0.0
.zero.table 8 8 0 0.0
lock cy8ckit_062s2_43012 0 0 0 0.0
(read only) 822136 822136 0 0.0
(read/write) 1671364 1671572 208 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208728 208728 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2480 2480 0 0.0
.debug_abbrev 1079191 1079201 10 0.0
.debug_aranges 103576 103584 8 0.0
.debug_frame 350300 350332 32 0.0
.debug_info 23157847 23158179 332 0.0
.debug_line 3378118 3378352 234 0.0
.debug_loc 3403928 3404016 88 0.0
.debug_ranges 327000 327032 32 0.0
.debug_str 3353596 3353747 151 0.0
.heap 822136 822136 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 480477 480588 111 0.0
.symtab 381280 381312 32 0.0
.text 1451768 1451976 208 0.0
.zero.table 8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1153432 1153616 184 0.0
.bss 97404 97404 0 0.0
.data 852 852 0 0.0
.text 600528 600712 184 0.0
lock-app qpg6105+debug (read/write) 1122048 1122240 192 0.0
.bss 92540 92540 0 0.0
.data 856 856 0 0.0
.text 569148 569340 192 0.0

@bzbarsky-apple
Add operational resolution retries in OperationalSessionSetup.
7b5f0b6 
Apparently some border routers are broken and don't actually do the "multicast"
part of mDNS right, leading to resolve failures if the advertisement is not
available during the initial unicast-response probe.  Work around that by
retrying operational discovery a few times during commissioning.
@bzbarsky-apple bzbarsky-apple force-pushed the add-operational-resolve-retries branch from 6d967cf to 7b5f0b6 Compare April 6, 2023 17:10
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

PR #25991: Size comparison from efaf3aa to 7b5f0b6

Increases (1 build for cc32xx)
platform target config section efaf3aa 7b5f0b6 change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 642745 642945 200 0.0
.debug_abbrev 933099 933109 10 0.0
.debug_aranges 87608 87616 8 0.0
.debug_frame 301328 301352 24 0.0
.debug_info 20302987 20303337 350 0.0
.debug_line 2679748 2679952 204 0.0
.debug_loc 2824679 2824781 102 0.0
.debug_ranges 286200 286208 8 0.0
.debug_str 3039406 3039557 151 0.0
.rodata 104289 104353 64 0.1
.strtab 377422 377533 111 0.0
.symtab 256768 256800 32 0.0
.text 536336 536472 136 0.0
Full report (1 build for cc32xx)
platform target config section efaf3aa 7b5f0b6 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642745 642945 200 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933099 933109 10 0.0
.debug_aranges 87608 87616 8 0.0
.debug_frame 301328 301352 24 0.0
.debug_info 20302987 20303337 350 0.0
.debug_line 2679748 2679952 204 0.0
.debug_loc 2824679 2824781 102 0.0
.debug_ranges 286200 286208 8 0.0
.debug_str 3039406 3039557 151 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104289 104353 64 0.1
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377422 377533 111 0.0
.symtab 256768 256800 32 0.0
.text 536336 536472 136 0.0

@bzbarsky-apple bzbarsky-apple merged commit bdfe291 into project-chip:master Apr 7, 2023
@bzbarsky-apple bzbarsky-apple deleted the add-operational-resolve-retries branch April 7, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitnj amitnj Awaiting requested review from amitnj

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @jmartinez-silabs @jtung-apple