-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] : Cleanup and applying coding guideline on Silabs code #25977
Merged
andy31415
merged 10 commits into
project-chip:master
from
sharad-patil24:feature/coding_standard
Apr 13, 2023
Merged
[Silabs] : Cleanup and applying coding guideline on Silabs code #25977
andy31415
merged 10 commits into
project-chip:master
from
sharad-patil24:feature/coding_standard
Apr 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #25977: Size comparison from a8096b1 to 3d9e0b5 Full report (1 build for cc32xx)
|
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kcoppock
April 5, 2023 10:50
pullapprove
bot
requested review from
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
April 5, 2023 10:50
PR #25977: Size comparison from f0f8931 to 49a510a Increases above 0.2%:
Increases (10 builds for cc13x2_26x2, telink)
Decreases (48 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (50 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #25977: Size comparison from ed5ebd2 to 395e4ca Full report (1 build for cc32xx)
|
jmartinez-silabs
approved these changes
Apr 11, 2023
mkardous-silabs
approved these changes
Apr 11, 2023
PR #25977: Size comparison from ed5ebd2 to 2eb7b4f Increases (1 build for cc32xx)
Decreases (1 build for qpg)
Full report (4 builds for cc32xx, mbed, qpg)
|
sharad-patil24
force-pushed
the
feature/coding_standard
branch
from
April 11, 2023 18:17
2eb7b4f
to
9b8710e
Compare
PR #25977: Size comparison from 9f4cbc6 to 9b8710e Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
andy31415
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first PR in the series of PR's to cleanup and Update our code to follow coding style guideline provided for Silabs.
In this PR we focused on the necessary ( Must do ) things.