-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tv-casting-app: Implementing FabricDelegate to update cache on FabricIndex removal #25972
Merged
chrisdecenzo
merged 2 commits into
project-chip:master
from
sharadb-amazon:rmv-fab-20230404
Apr 5, 2023
Merged
tv-casting-app: Implementing FabricDelegate to update cache on FabricIndex removal #25972
chrisdecenzo
merged 2 commits into
project-chip:master
from
sharadb-amazon:rmv-fab-20230404
Apr 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharadb-amazon
force-pushed
the
rmv-fab-20230404
branch
from
April 4, 2023 17:53
6396cff
to
e6a1ccb
Compare
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock and
kkasperczyk-no
April 4, 2023 17:54
pullapprove
bot
requested review from
lpbeliveau-silabs,
LuDuda,
mlepage-google,
msandstedt,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
April 4, 2023 17:54
PR #25972: Size comparison from a8096b1 to e6a1ccb Increases (1 build for cc32xx)
Full report (3 builds for cc32xx, qpg)
|
chrisdecenzo
approved these changes
Apr 4, 2023
examples/tv-casting-app/tv-casting-common/src/PersistenceManager.cpp
Outdated
Show resolved
Hide resolved
…etting its objects to zeroes
PR #25972: Size comparison from a8096b1 to 21b9097 Increases (7 builds for bl702, cc13x2_26x2, cyw30739, k32w, psoc6)
Decreases (4 builds for bl602, cc13x2_26x2, efr32, psoc6)
Full report (34 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
hawk248
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25971
Change summary
Testing
Tested using the Android tv-casting-app with the linux tv-app and following the steps to repro in the issue above.