Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make matter IDL generate more cases where attributes have default values #25948

Merged
merged 8 commits into from
Apr 5, 2023
Merged

Make matter IDL generate more cases where attributes have default values #25948

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2e17619
Set default value in IDL for nullable defaults even if they are zero
andy31415 Apr 3, 2023
cf7d3f1
Regen all
andy31415 Apr 3, 2023
d905921
Even looser default value config for IDLs
andy31415 Apr 3, 2023
4a349d8
Regen all
andy31415 Apr 3, 2023
dbdaa5f
Regen all
andy31415 Apr 3, 2023
ad0c1a0
Zap regen - ran from vscode image this time
andy31415 Apr 3, 2023
1361748
Update helper back to use_cluster_attributes
andy31415 Apr 3, 2023
0e880f6
Add back the if included logic
andy31415 Apr 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
603 changes: 302 additions & 301 deletions examples/all-clusters-app/all-clusters-common/all-clusters-app.matter
View file
Open in desktop

Large diffs are not rendered by default.

386 changes: 193 additions & 193 deletions examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.matter
View file
Open in desktop

Large diffs are not rendered by default.

235 changes: 119 additions & 116 deletions examples/bridge-app/bridge-common/bridge-app.matter
View file
Open in desktop

Large diffs are not rendered by default.

268 changes: 137 additions & 131 deletions examples/chef/devices/noip_rootnode_dimmablelight_bCwGYSDpoe.matter
View file
Open in desktop

Large diffs are not rendered by default.

100 changes: 53 additions & 47 deletions examples/chef/devices/rootnode_colortemperaturelight_hbUnzYVeyn.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1431,7 +1431,10 @@ endpoint 0 {

server cluster Groups {
ram attribute nameSupport;
ram attribute featureMap;
callback attribute generatedCommandList;
callback attribute acceptedCommandList;
callback attribute attributeList;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 3;
}

Expand All @@ -1440,7 +1443,10 @@ endpoint 0 {
callback attribute serverList;
callback attribute clientList;
callback attribute partsList;
ram attribute featureMap;
callback attribute generatedCommandList;
callback attribute acceptedCommandList;
callback attribute attributeList;
ram attribute featureMap default = 0;
callback attribute clusterRevision default = 1;
}

Expand All @@ -1453,7 +1459,7 @@ endpoint 0 {
callback attribute targetsPerAccessControlEntry;
callback attribute accessControlEntriesPerFabric;
callback attribute attributeList;
ram attribute featureMap;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 1;
}

Expand All @@ -1468,20 +1474,20 @@ endpoint 0 {
callback attribute productID;
persist attribute nodeLabel;
callback attribute location default = "XX";
callback attribute hardwareVersion;
callback attribute hardwareVersion default = 0;
callback attribute hardwareVersionString;
callback attribute softwareVersion;
callback attribute softwareVersion default = 0;
callback attribute softwareVersionString;
callback attribute manufacturingDate default = "20210614123456ZZ";
callback attribute partNumber;
callback attribute productURL;
callback attribute productLabel;
callback attribute serialNumber;
persist attribute localConfigDisabled;
persist attribute localConfigDisabled default = 0;
ram attribute reachable default = 1;
callback attribute uniqueID;
callback attribute capabilityMinima;
ram attribute featureMap;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 1;
}

Expand All @@ -1491,17 +1497,17 @@ endpoint 0 {
emits event DownloadError;
callback attribute defaultOTAProviders;
ram attribute updatePossible default = 1;
ram attribute updateState;
ram attribute updateStateProgress;
ram attribute featureMap;
ram attribute updateState default = 0;
ram attribute updateStateProgress default = 0;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 1;
}

server cluster GeneralCommissioning {
ram attribute breadcrumb;
ram attribute breadcrumb default = 0x0000000000000000;
callback attribute basicCommissioningInfo;
callback attribute regulatoryConfig;
callback attribute locationCapability;
callback attribute regulatoryConfig default = 0;
callback attribute locationCapability default = 0;
callback attribute supportsConcurrentConnection default = 1;
ram attribute featureMap default = 6;
ram attribute clusterRevision default = 0x0001;
Expand All @@ -1521,39 +1527,39 @@ endpoint 0 {
}

server cluster DiagnosticLogs {
ram attribute featureMap;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 1;
}

server cluster GeneralDiagnostics {
emits event BootReason;
callback attribute networkInterfaces;
callback attribute rebootCount;
callback attribute upTime;
callback attribute totalOperationalHours;
callback attribute rebootCount default = 0x0000;
callback attribute upTime default = 0x0000000000000000;
callback attribute totalOperationalHours default = 0x00000000;
callback attribute bootReason;
callback attribute activeHardwareFaults;
callback attribute activeRadioFaults;
callback attribute activeNetworkFaults;
callback attribute testEventTriggersEnabled;
ram attribute featureMap;
callback attribute testEventTriggersEnabled default = false;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 0x0001;
}

server cluster SoftwareDiagnostics {
callback attribute threadMetrics;
callback attribute currentHeapFree;
callback attribute currentHeapUsed;
callback attribute currentHeapHighWatermark;
callback attribute currentHeapFree default = 0x0000000000000000;
callback attribute currentHeapUsed default = 0x0000000000000000;
callback attribute currentHeapHighWatermark default = 0x0000000000000000;
ram attribute featureMap default = 1;
ram attribute clusterRevision default = 0x0001;
}

server cluster AdministratorCommissioning {
callback attribute windowStatus;
callback attribute windowStatus default = 0;
callback attribute adminFabricIndex default = 1;
callback attribute adminVendorId;
ram attribute featureMap;
callback attribute adminVendorId default = 0;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 0x0001;
}

Expand All @@ -1564,7 +1570,7 @@ endpoint 0 {
callback attribute commissionedFabrics;
callback attribute trustedRootCertificates;
callback attribute currentFabricIndex;
ram attribute featureMap;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 0x0001;
}

Expand All @@ -1573,20 +1579,20 @@ endpoint 0 {
callback attribute groupTable;
callback attribute maxGroupsPerFabric;
callback attribute maxGroupKeysPerFabric;
ram attribute featureMap;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 1;
}
}
endpoint 1 {
device type anonymousEndpointType = 268, version 1;

server cluster Identify {
ram attribute identifyTime;
ram attribute identifyType;
ram attribute identifyTime default = 0x0;
ram attribute identifyType default = 0x0;
callback attribute generatedCommandList;
callback attribute acceptedCommandList;
callback attribute attributeList;
ram attribute featureMap;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 4;
}

Expand All @@ -1595,33 +1601,33 @@ endpoint 1 {
callback attribute generatedCommandList;
callback attribute acceptedCommandList;
callback attribute attributeList;
ram attribute featureMap;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 3;
}

server cluster OnOff {
ram attribute onOff;
ram attribute onOff default = 0;
ram attribute globalSceneControl default = 1;
ram attribute onTime;
ram attribute offWaitTime;
ram attribute onTime default = 0;
ram attribute offWaitTime default = 0;
ram attribute startUpOnOff;
callback attribute generatedCommandList;
callback attribute acceptedCommandList;
callback attribute attributeList;
ram attribute featureMap;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 4;
}

server cluster LevelControl {
ram attribute currentLevel;
ram attribute remainingTime;
ram attribute options;
ram attribute currentLevel default = 0x00;
ram attribute remainingTime default = 0x0000;
ram attribute options default = 0x00;
ram attribute onLevel;
ram attribute startUpCurrentLevel;
callback attribute generatedCommandList;
callback attribute acceptedCommandList;
callback attribute attributeList;
ram attribute featureMap;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 5;
}

Expand All @@ -1633,15 +1639,15 @@ endpoint 1 {
callback attribute generatedCommandList;
callback attribute acceptedCommandList;
callback attribute attributeList;
ram attribute featureMap;
ram attribute clusterRevision default = 1;
ram attribute featureMap default = 0;
callback attribute clusterRevision default = 1;
andy31415 marked this conversation as resolved.
Show resolved Hide resolved
}

server cluster ColorControl {
ram attribute remainingTime;
ram attribute remainingTime default = 0x0000;
ram attribute colorTemperatureMireds default = 0x00FA;
ram attribute colorMode default = 0x01;
ram attribute options;
ram attribute options default = 0x00;
ram attribute numberOfPrimaries;
ram attribute primary1X;
ram attribute primary1Y;
Expand All @@ -1661,17 +1667,17 @@ endpoint 1 {
ram attribute primary6X;
ram attribute primary6Y;
ram attribute primary6Intensity;
ram attribute enhancedCurrentHue;
ram attribute enhancedCurrentHue default = 0x0000;
ram attribute enhancedColorMode default = 0x01;
ram attribute colorCapabilities;
ram attribute colorTempPhysicalMinMireds;
ram attribute colorCapabilities default = 0x0000;
ram attribute colorTempPhysicalMinMireds default = 0x0000;
ram attribute colorTempPhysicalMaxMireds default = 0xFEFF;
ram attribute coupleColorTempToLevelMinMireds;
ram attribute startUpColorTemperatureMireds;
callback attribute generatedCommandList;
callback attribute acceptedCommandList;
callback attribute attributeList;
ram attribute featureMap;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 5;
}
}
Expand Down
Loading