Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Telink Zephyr main branch (get rid of maintaining special Zephyr branch) #25940

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

andriy-bilynskyy
Copy link
Contributor

Change overview

Update the Telink BLEManagerImpl module
Update the Telink ThreadStackManagerImpl module
Update telink image to 0.6.52 (use Telink main Zephyr branch)
Testing

Tested manually with chip-tool.

Steps:

Run: $ chip-tool pairing ble-thread <...>
Wait till success
Run: $ chip-tool onoff on ${NODE_ID }1
Wait till success
Run: $ chip-tool onoff off ${NODE_ID }1
Wait till success

@pullapprove pullapprove bot added the telink label Apr 3, 2023
@andriy-bilynskyy andriy-bilynskyy changed the title Telink develop Switch to Telink Zephyr main branch (get rid of maintaining special Zephyr branch) Apr 3, 2023
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

PR #25940: Size comparison from 7ccd5d4 to 71f1c20

Increases (1 build for cc32xx)
platform target config section 7ccd5d4 71f1c20 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20310330 20310331 1 0.0
Full report (1 build for cc32xx)
platform target config section 7ccd5d4 71f1c20 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645825 645825 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933102 933102 0 0.0
.debug_aranges 87704 87704 0 0.0
.debug_frame 301596 301596 0 0.0
.debug_info 20310330 20310331 1 0.0
.debug_line 2681125 2681125 0 0.0
.debug_loc 2827568 2827568 0 0.0
.debug_ranges 286448 286448 0 0.0
.debug_str 3041144 3041144 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105953 105953 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380543 380543 0 0.0
.symtab 257472 257472 0 0.0
.text 537752 537752 0 0.0

@andriy-bilynskyy
Copy link
Contributor Author

Please review this PR its touches only Telink vendor and focused on getting rid of special Zephyr branch for Matter project switching to main one (Due to resources it's difficult to maintain special branch)

@andy31415 andy31415 merged commit 7c2e7db into project-chip:master Apr 5, 2023
@s07641069 s07641069 deleted the telink-develop branch April 5, 2023 12:49
@Kxuan
Copy link
Contributor

Kxuan commented Apr 13, 2023

Hi @andriy-bilynskyy
It seems this PR breaks BLE advertising.

Devices are unable to be commissioned, since there is no BLE packet sent.

Do you have any idea to fix it?

@andriy-bilynskyy
Copy link
Contributor Author

On which platform have you observed the issue? All merged files are relative only to Telink. Telink nightly CI tests (includung BLE) are OK as I know.

@Kxuan
Copy link
Contributor

Kxuan commented Apr 13, 2023

@andriy-bilynskyy Yes. telink platform.
All log messages seems normal. And it do shows log messages like "CHIPoBLE advertising started".

But acturally, devices does not send BLE advertisement packets.

@andriy-bilynskyy
Copy link
Contributor Author

In that case please create ticket with your case details (used commit hashes, zephyr hash if yo are not using docker, sample app you are using, changes in configs). Because mainly it works as I already told all commissioning tests on our CI are passed.

@andriy-bilynskyy
Copy link
Contributor Author

BTW: if you are using docker please change it's version. Commit introduces new docker version. With old docker it definitely not working.

@Kxuan
Copy link
Contributor

Kxuan commented Apr 13, 2023

Thanks @andriy-bilynskyy .

After updating zephyr, it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants