Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Darwin] add commissioning callback (read Commissioning Info, commissioningComplete add deviceId) #25832

Merged
merged 39 commits into from
Apr 26, 2023
Merged

[Darwin] add commissioning callback (read Commissioning Info, commissioningComplete add deviceId) #25832

merged 39 commits into from
Apr 26, 2023

Conversation

joonhaengHeo
Copy link
Contributor

For improve User scenario when commissioning,
Add readCommissioningInfo and commissioningComplete callback.

  1. readCommissioningInfo : Can check vendorId, productId when commissioning (can get deviceInfo from DCL)
  2. commissioningComplete : Need not saving deviceID before commissioning.

@github-actions
Copy link

PR #25832: Size comparison from fe07225 to 3748b1a

Increases (1 build for cc32xx)
platform target config section fe07225 3748b1a change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19489250 19489251 1 0.0
Full report (1 build for cc32xx)
platform target config section fe07225 3748b1a change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 601114 601114 0 0.0
(read/write) 204132 204132 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197544 197544 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 956756 956756 0 0.0
.debug_aranges 103416 103416 0 0.0
.debug_frame 349704 349704 0 0.0
.debug_info 19489250 19489251 1 0.0
.debug_line 2678035 2678035 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1501882 1501882 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 96008 96008 0 0.0
.debug_str 3024877 3024877 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104170 104170 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 477531 477531 0 0.0
.symtab 285936 285936 0 0.0
.text 494824 494824 0 0.0

bzbarsky-apple
bzbarsky-apple reviewed Apr 25, 2023
View reviewed changes
src/darwin/CHIPTool/CHIPTool/View Controllers/QRCode/QRCodeViewController.m Outdated Show resolved Hide resolved
src/darwin/CHIPTool/CHIPTool/View Controllers/QRCode/QRCodeViewController.m Outdated Show resolved Hide resolved
src/darwin/Framework/CHIP/MTRDeviceControllerDelegate.h Outdated Show resolved Hide resolved
src/darwin/Framework/CHIP/MTRDeviceControllerDelegate.h Outdated Show resolved Hide resolved
src/darwin/Framework/CHIP/MTRDeviceControllerDelegate.h Outdated Show resolved Hide resolved
src/darwin/Framework/CHIP/MTRDeviceControllerDelegate.h Outdated Show resolved Hide resolved
src/darwin/Framework/CHIP/MTRDeviceControllerDelegate.h Outdated Show resolved Hide resolved
src/darwin/Framework/CHIP/MTRDeviceControllerDelegateBridge.mm Outdated Show resolved Hide resolved
src/darwin/Framework/CHIP/MTRDeviceControllerDelegateBridge.mm Outdated Show resolved Hide resolved
src/darwin/Framework/CHIP/MTRDeviceControllerDelegateBridge.mm Outdated Show resolved Hide resolved
joonhaengHeo and others added 14 commits April 26, 2023 07:54
@joonhaengHeo @bzbarsky-apple
Update src/darwin/Framework/CHIP/MTRDeviceControllerDelegate.h
7966406 
Co-authored-by: Boris Zbarsky <[email protected]>
@joonhaengHeo @bzbarsky-apple
Update src/darwin/Framework/CHIP/MTRDeviceControllerDelegate.h
fe0347f 
Co-authored-by: Boris Zbarsky <[email protected]>
@joonhaengHeo @bzbarsky-apple
Update src/darwin/Framework/CHIP/MTRDeviceControllerDelegateBridge.mm
483429a 
Co-authored-by: Boris Zbarsky <[email protected]>
@joonhaengHeo @bzbarsky-apple
Update src/darwin/Framework/CHIP/MTRDeviceControllerDelegate.h
ebf5811 
Co-authored-by: Boris Zbarsky <[email protected]>
@joonhaengHeo @bzbarsky-apple
Update src/darwin/Framework/CHIP/MTRDeviceControllerDelegateBridge.mm
a728d54 
Co-authored-by: Boris Zbarsky <[email protected]>
@joonhaengHeo @bzbarsky-apple
Update src/darwin/Framework/CHIP/MTRDeviceControllerDelegateBridge.mm
462ea5f 
Co-authored-by: Boris Zbarsky <[email protected]>
@joonhaengHeo @bzbarsky-apple
Update src/darwin/Framework/CHIP/MTRDeviceControllerDelegate.h
a802c30 
Co-authored-by: Boris Zbarsky <[email protected]>
@joonhaengHeo @bzbarsky-apple
Update src/darwin/Framework/CHIP/MTRDeviceControllerDelegate.h
7059d24 
Co-authored-by: Boris Zbarsky <[email protected]>
@joonhaengHeo @bzbarsky-apple
Update src/darwin/Framework/CHIP/MTRDeviceControllerDelegate.h
6cfa412 
Co-authored-by: Boris Zbarsky <[email protected]>
@joonhaengHeo
modify for changing variable name
e82a92d
@joonhaengHeo
Merge branch 'darwin_add_commissioning_callback' of github.com:joonha…
8f750bf 
…engHeo/connectedhomeip into darwin_add_commissioning_callback
@joonhaengHeo
restyle
430cb9f
@joonhaengHeo
restyle-2
e5d49b9
@joonhaengHeo
Merge branch 'master' into darwin_add_commissioning_callback
8a1b216
@github-actions
Copy link

PR #25832: Size comparison from c2a28c8 to 8a1b216

Full report (1 build for cc32xx)
platform target config section c2a28c8 8a1b216 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 601114 601114 0 0.0
(read/write) 204132 204132 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197544 197544 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 956756 956756 0 0.0
.debug_aranges 103416 103416 0 0.0
.debug_frame 349704 349704 0 0.0
.debug_info 19489250 19489250 0 0.0
.debug_line 2678035 2678035 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1501882 1501882 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 96008 96008 0 0.0
.debug_str 3024877 3024877 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104170 104170 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 477531 477531 0 0.0
.symtab 285936 285936 0 0.0
.text 494824 494824 0 0.0

@bzbarsky-apple
Copy link
Contributor

Fast-tracking platform-specific change with platform owner review.

@github-actions
Copy link

PR #25832: Size comparison from c2a28c8 to 346f7d6

Full report (1 build for cc32xx)
platform target config section c2a28c8 346f7d6 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 601114 601114 0 0.0
(read/write) 204132 204132 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197544 197544 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 956756 956756 0 0.0
.debug_aranges 103416 103416 0 0.0
.debug_frame 349704 349704 0 0.0
.debug_info 19489250 19489250 0 0.0
.debug_line 2678035 2678035 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1501882 1501882 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 96008 96008 0 0.0
.debug_str 3024877 3024877 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104170 104170 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 477531 477531 0 0.0
.symtab 285936 285936 0 0.0
.text 494824 494824 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 7bbb240 into project-chip:master Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
darwin fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joonhaengHeo @bzbarsky-apple