Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telink] Add Bridge example app demo #25798

Merged
merged 19 commits into from
Apr 11, 2023

Conversation

interfer
Copy link
Contributor

Problem

  • These changes add new Telink app example

Change overview

  • Added Bridge App example (4 Lights and a Temperature Sensor)

Testing
Tested manually with chip-tool.

Steps:

  • Run: $ chip-tool pairing ble-thread <...>
  • Wait till success

@CLAassistant
Copy link

CLAassistant commented Mar 23, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

PR #25798: Size comparison from a6dc62c to e27b5b4

Increases (1 build for cc32xx)
platform target config section a6dc62c e27b5b4 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20239633 20239635 2 0.0
Full report (1 build for cc32xx)
platform target config section a6dc62c e27b5b4 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645825 645825 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930286 930286 0 0.0
.debug_aranges 87400 87400 0 0.0
.debug_frame 300336 300336 0 0.0
.debug_info 20239633 20239635 2 0.0
.debug_line 2661958 2661958 0 0.0
.debug_loc 2806731 2806731 0 0.0
.debug_ranges 283424 283424 0 0.0
.debug_str 3027815 3027815 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380469 380469 0 0.0
.symtab 257408 257408 0 0.0
.text 537712 537712 0 0.0

Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But now are the spec-required ClusterRevision attributes even present? I don't see them in the cluster declarations, and I don't see values being produced for them...

@interfer
Copy link
Contributor Author

interfer commented Apr 4, 2023

@bzbarsky-apple good point, thanks, added ClusterRevision attribute to clusters

@interfer interfer requested a review from bzbarsky-apple April 4, 2023 12:33
@interfer interfer requested a review from bzbarsky-apple April 6, 2023 06:20
examples/bridge-app/telink/src/AppTask.cpp Outdated Show resolved Hide resolved
examples/bridge-app/telink/src/AppTask.cpp Outdated Show resolved Hide resolved
examples/bridge-app/telink/src/AppTask.cpp Outdated Show resolved Hide resolved
@interfer interfer requested a review from bzbarsky-apple April 10, 2023 07:13
@github-actions
Copy link

PR #25798: Size comparison from 03cb5e3 to 5ee5f5d

Decreases (1 build for cc32xx)
platform target config section 03cb5e3 5ee5f5d change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20303341 20303340 -1 -0.0
Full report (1 build for cc32xx)
platform target config section 03cb5e3 5ee5f5d change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642945 642945 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933129 933129 0 0.0
.debug_aranges 87616 87616 0 0.0
.debug_frame 301352 301352 0 0.0
.debug_info 20303341 20303340 -1 -0.0
.debug_line 2679963 2679963 0 0.0
.debug_loc 2824782 2824782 0 0.0
.debug_ranges 286208 286208 0 0.0
.debug_str 3039557 3039557 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104353 104353 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377533 377533 0 0.0
.symtab 256800 256800 0 0.0
.text 536472 536472 0 0.0

@andy31415 andy31415 merged commit 27d9f12 into project-chip:master Apr 11, 2023
@s07641069 s07641069 deleted the bridge-app-demo branch April 12, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants