Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop generating weakly-typed enums for the color loop enum types. #25790

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Stop generating weakly-typed enums for the color loop enum types. #25790

merged 2 commits into from
Mar 23, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

NOTE: Only the first changeset is manually written.

@github-actions
Copy link

PR #25790: Size comparison from 2ea6746 to 93d83d7

Increases (1 build for cc32xx)
platform target config section 2ea6746 93d83d7 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_str 3027534 3028773 1239 0.0
Decreases (1 build for cc32xx)
platform target config section 2ea6746 93d83d7 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20251230 20240103 -11127 -0.1
.debug_line 2661959 2661957 -2 -0.0
.debug_loc 2806733 2806716 -17 -0.0
Full report (2 builds for cc32xx, mbed)
platform target config section 2ea6746 93d83d7 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645825 645825 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930286 930286 0 0.0
.debug_aranges 87400 87400 0 0.0
.debug_frame 300336 300336 0 0.0
.debug_info 20251230 20240103 -11127 -0.1
.debug_line 2661959 2661957 -2 -0.0
.debug_loc 2806733 2806716 -17 -0.0
.debug_ranges 283424 283424 0 0.0
.debug_str 3027534 3028773 1239 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380469 380469 0 0.0
.symtab 257408 257408 0 0.0
.text 537712 537712 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2468552 2468552 0 0.0
.bss 215964 215964 0 0.0
.data 5880 5880 0 0.0
.text 1431196 1431196 0 0.0

@bzbarsky-apple bzbarsky-apple marked this pull request as draft March 22, 2023 21:41
@bzbarsky-apple bzbarsky-apple force-pushed the color-loop-strong-enums branch from 93d83d7 to 5d70af1 Compare March 22, 2023 21:55
@bzbarsky-apple bzbarsky-apple marked this pull request as ready for review March 22, 2023 21:55
@github-actions
Copy link

PR #25790: Size comparison from 9829096 to 5d70af1

Increases (1 build for cc32xx)
platform target config section 9829096 5d70af1 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_str 3027534 3027815 281 0.0
Decreases (1 build for cc32xx)
platform target config section 9829096 5d70af1 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20251231 20239633 -11598 -0.1
.debug_line 2661959 2661958 -1 -0.0
.debug_loc 2806733 2806731 -2 -0.0
Full report (1 build for cc32xx)
platform target config section 9829096 5d70af1 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645825 645825 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930286 930286 0 0.0
.debug_aranges 87400 87400 0 0.0
.debug_frame 300336 300336 0 0.0
.debug_info 20251231 20239633 -11598 -0.1
.debug_line 2661959 2661958 -1 -0.0
.debug_loc 2806733 2806731 -2 -0.0
.debug_ranges 283424 283424 0 0.0
.debug_str 3027534 3027815 281 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380469 380469 0 0.0
.symtab 257408 257408 0 0.0
.text 537712 537712 0 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the color-loop-strong-enums branch from 5d70af1 to b5f2658 Compare March 22, 2023 23:46
@github-actions
Copy link

PR #25790: Size comparison from e214d1e to b5f2658

Increases (1 build for cc32xx)
platform target config section e214d1e b5f2658 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_str 3027534 3027815 281 0.0
Decreases (1 build for cc32xx)
platform target config section e214d1e b5f2658 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20251230 20239634 -11596 -0.1
.debug_line 2661959 2661958 -1 -0.0
.debug_loc 2806733 2806731 -2 -0.0
Full report (1 build for cc32xx)
platform target config section e214d1e b5f2658 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645825 645825 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930286 930286 0 0.0
.debug_aranges 87400 87400 0 0.0
.debug_frame 300336 300336 0 0.0
.debug_info 20251230 20239634 -11596 -0.1
.debug_line 2661959 2661958 -1 -0.0
.debug_loc 2806733 2806731 -2 -0.0
.debug_ranges 283424 283424 0 0.0
.debug_str 3027534 3027815 281 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380469 380469 0 0.0
.symtab 257408 257408 0 0.0
.text 537712 537712 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit a6dc62c into project-chip:master Mar 23, 2023
@bzbarsky-apple bzbarsky-apple deleted the color-loop-strong-enums branch March 23, 2023 05:54
@mkardous-silabs mkardous-silabs mentioned this pull request Apr 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @andy31415 @jmartinez-silabs