-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failsafe extension when we have a device attestation delegate. #25787
Merged
jmartinez-silabs
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-device-attestation-failsafe-handling
Mar 22, 2023
Merged
Fix failsafe extension when we have a device attestation delegate. #25787
jmartinez-silabs
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-device-attestation-failsafe-handling
Mar 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no and
ksperling-apple
March 22, 2023 17:08
pullapprove
bot
requested review from
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
March 22, 2023 17:09
jtung-apple
approved these changes
Mar 22, 2023
The boolean test in ExtendArmFailSafeForDeviceAttestation was backwards, so there were two failure cases: 1. If we had a delegate but FailSafeExpiryTimeoutSecs() returned NullOptional, we would skip extending the fail-safe (expected), but set failSafeSkipped to _false_, and so not actually make our "continue commissioning" callback. 2. If we had a delegate and FailSafeExpiryTimeoutSecs() returned a too-small value, we would also skip resetting the fail-safe, but end up setting failSafeSkipped to false, and hence again failing to make our "continue commissioning" callback. The fix is to reverse the sense of the "do we need to call back immediately" boolean, to make it a little clearer what the logic flow is here, and then check it appropriately.
bzbarsky-apple
force-pushed
the
fix-device-attestation-failsafe-handling
branch
from
March 22, 2023 17:20
5754370
to
7596377
Compare
PR #25787: Size comparison from 6be032d to 7596377 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
andy31415
approved these changes
Mar 22, 2023
woody-apple
approved these changes
Mar 22, 2023
jmartinez-silabs
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The boolean test in ExtendArmFailSafeForDeviceAttestation was backwards, so there were two failure cases:
If we had a delegate but FailSafeExpiryTimeoutSecs() returned NullOptional, we would skip extending the fail-safe (expected), but set failSafeSkipped to false, and so not actually make our "continue commissioning" callback.
If we had a delegate and FailSafeExpiryTimeoutSecs() returned a too-small value, we would also skip resetting the fail-safe, but end up setting failSafeSkipped to false, and hence again failing to make our "continue commissioning" callback.
The fix is to reverse the sense of the "do we need to call back immediately" boolean, to make it a little clearer what the logic flow is here, and then check it appropriately.