Enable EndpointIterator to target search single group ID #25758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running RR_1_1 test where we stress test by using max of everything on every fabric, it was found that each iterator step could take up to 21ms. For a large enough group table ReadGroupTable was taking more then 5 second. By targeting the group id for which we want to iterator over endpoints we can reduce time `ReadGroupTable` for large tables by an order of magnitude.
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
|
PR #25758: Size comparison from 8425d28 to a957528 Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
bzbarsky-apple
approved these changes
Mar 21, 2023
src/app/clusters/group-key-mgmt-server/group-key-mgmt-server.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Boris Zbarsky <[email protected]>
Damian-Nordic
approved these changes
Mar 22, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…p#25758) * Enable EndpointIterator to target search single group ID Running RR_1_1 test where we stress test by using max of everything on every fabric, it was found that each iterator step could take up to 21ms. For a large enough group table ReadGroupTable was taking more then 5 second. By targeting the group id for which we want to iterator over endpoints we can reduce time `ReadGroupTable` for large tables by an order of magnitude. * Added comment * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> * Restyle --------- Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running RR_1_1 test where we stress test by using max of everything on every fabric, it was found that each iterator step could take up to 21ms. For a large enough group table ReadGroupTable was taking more then 5 second. By targeting the group id for which we want to iterator over endpoints we can reduce time
ReadGroupTablefor large tables by an order of magnitude.This is one of the 4 PR that will be required to address #25532