-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a longer backoff for CASE retries. #25736
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:include-Sigma2-timeout-in-CASE-retries
Mar 17, 2023
Merged
Use a longer backoff for CASE retries. #25736
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:include-Sigma2-timeout-in-CASE-retries
Mar 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a common failure mode for Thread devices where the commissioner sends Sigma1 prior to sending CommissioningComplete, the commissionee responds, but the Sigma2 (and all its retries) never reach the commissioner. When this happens, our existing CASE retries do not help because they happen too quickly: the commissionee is waiting for Sigma3, and will ignore Sigma1 messages until it gets the Sigma3 or times out. To address this, include the time it would take the commissionee to time out in our CASE retry delay for every other retry. This allows us to retry quickly once, then give the commissionee time to start listening again, then retry quickly one or two times (depending on how many retries were requested), etc.
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
March 17, 2023 17:33
pullapprove
bot
requested review from
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
March 17, 2023 17:33
PR #25736: Size comparison from bbb8e93 to 55d3f52 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
nivi-apple
approved these changes
Mar 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
andy31415
approved these changes
Mar 17, 2023
woody-apple
approved these changes
Mar 17, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
We have a common failure mode for Thread devices where the commissioner sends Sigma1 prior to sending CommissioningComplete, the commissionee responds, but the Sigma2 (and all its retries) never reach the commissioner. When this happens, our existing CASE retries do not help because they happen too quickly: the commissionee is waiting for Sigma3, and will ignore Sigma1 messages until it gets the Sigma3 or times out. To address this, include the time it would take the commissionee to time out in our CASE retry delay for every other retry. This allows us to retry quickly once, then give the commissionee time to start listening again, then retry quickly one or two times (depending on how many retries were requested), etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a common failure mode for Thread devices where the commissioner sends Sigma1 prior to sending CommissioningComplete, the commissionee responds, but the Sigma2 (and all its retries) never reach the commissioner.
When this happens, our existing CASE retries do not help because they happen too quickly: the commissionee is waiting for Sigma3, and will ignore Sigma1 messages until it gets the Sigma3 or times out.
To address this, include the time it would take the commissionee to time out in our CASE retry delay for every other retry. This allows us to retry quickly once, then give the commissionee time to start listening again, then retry quickly one or two times (depending on how many retries were requested), etc.