Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to use an IPV4 address #25668

Merged
merged 2 commits into from
Mar 18, 2023
Merged

Default to use an IPV4 address #25668

merged 2 commits into from
Mar 18, 2023

Conversation

cliffamzn
Copy link
Contributor

@cliffamzn cliffamzn commented Mar 13, 2023 •
edited
Loading

On some devices it appears that the commissioner may not have an appropriate IPV6 address and attempts to send a user directed commissioning request to a device using its IPV6 address.

Its a bit unclear how this situation happens but in theory it could occur. In most cases this should be safe to default to an ipv4 address if it is available.

The implementation of the user directed commissioning server does something similar.

In the test setup we had, an iOS device was acting as the commissionee (sending the UDC packet). One interface (the loop back) has both an IPv6 and IPv4 address, the WiFi interface however only had an IPv4 address.
We observed the iOS device attempting to send the UDC packet back over the IPv6 address to the commissioner but tracing over wireshark showed no packets being sent.

This setup could only be reproduced with one particular travel router and the same scenario could not be reproduced on other setups.

@github-actions
Copy link

github-actions bot commented Mar 13, 2023 •
edited
Loading

PR #25668: Size comparison from d04e396 to 8dc3883

Increases (6 builds for bl702, cc13x2_26x2, nrfconnect, psoc6)
platform target config section d04e396 8dc3883 change % change
bl702 lighting-app bl702+rpc .debug_info 45459757 45459759 2 0.0
.text 1034790 1034794 4 0.0
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 664971 664979 8 0.0
.text 560912 560920 8 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 773792 773796 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27950283 27950284 1 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 27495547 27495548 1 0.0
lock cy8ckit_062s2_43012 .debug_info 23099440 23099441 1 0.0
Decreases (3 builds for cc13x2_26x2, efr32)
platform target config section d04e396 8dc3883 change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read/write) 178908 178900 -8 -0.0
efr32 lighting-app BRD4187C (read/write) 1014500 1014492 -8 -0.0
.text 838872 838864 -8 -0.0
lock-app BRD4161A+wf200 (read/write) 1080748 1080740 -8 -0.0
.text 904888 904880 -8 -0.0
Full report (34 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
platform target config section d04e396 8dc3883 change % change
bl602 lighting-app bl602 (read/write) 1356586 1356586 0 0.0
.bss 94842 94842 0 0.0
.data 9744 9744 0 0.0
.text 1028960 1028960 0 0.0
bl602+rpc (read/write) 1402010 1402010 0 0.0
.bss 102890 102890 0 0.0
.data 10136 10136 0 0.0
.text 1059894 1059894 0 0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1188811 1188811 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 70113 70113 0 0.0
.bss_psram 26048 26048 0 0.0
.comment 48 48 0 0.0
.data 4072 4072 0 0.0
.debug_abbrev 1556799 1556799 0 0.0
.debug_aranges 134584 134584 0 0.0
.debug_frame 493292 493292 0 0.0
.debug_info 40833254 40833254 0 0.0
.debug_line 5294914 5294914 0 0.0
.debug_loc 3426988 3426988 0 0.0
.debug_ranges 373512 373512 0 0.0
.debug_str 3588010 3588010 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 108032 108032 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 577184 577184 0 0.0
.symtab 174224 174224 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 959450 959450 0 0.0
bl702+rpc 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1279479 1279479 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 78161 78161 0 0.0
.bss_psram 26320 26320 0 0.0
.comment 48 48 0 0.0
.data 4616 4616 0 0.0
.debug_abbrev 1708914 1708914 0 0.0
.debug_aranges 142912 142912 0 0.0
.debug_frame 521236 521236 0 0.0
.debug_info 45459757 45459759 2 0.0
.debug_line 5700257 5700257 0 0.0
.debug_loc 3624963 3624963 0 0.0
.debug_ranges 397512 397512 0 0.0
.debug_str 3992199 3992199 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 122240 122240 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 638509 638509 0 0.0
.symtab 192720 192720 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 1034790 1034794 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 681871 681871 0 0.0
(read/write) 169384 169384 0 0.0
.bss 80948 80948 0 0.0
.data 3352 3352 0 0.0
.rodata 88583 88583 0 0.0
.text 592972 592972 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 645183 645183 0 0.0
(read/write) 157616 157616 0 0.0
.bss 80148 80148 0 0.0
.data 3352 3352 0 0.0
.rodata 78455 78455 0 0.0
.text 566408 566408 0 0.0
lock-ftd LP_CC2652R7 (read only) 679015 679015 0 0.0
(read/write) 169704 169704 0 0.0
.bss 78500 78500 0 0.0
.data 3316 3316 0 0.0
.rodata 76775 76775 0 0.0
.text 601760 601760 0 0.0
lock-mtd LP_CC2652R7 (read only) 664971 664979 8 0.0
(read/write) 178908 178900 -8 -0.0
.bss 73660 73660 0 0.0
.data 3316 3316 0 0.0
.rodata 103579 103579 0 0.0
.text 560912 560920 8 0.0
pump-app LP_CC2652R7 (read only) 692075 692075 0 0.0
(read/write) 157388 157388 0 0.0
.bss 78476 78476 0 0.0
.data 3280 3280 0 0.0
.rodata 91067 91067 0 0.0
.text 600528 600528 0 0.0
pump-controller-app LP_CC2652R7 (read only) 677011 677011 0 0.0
(read/write) 172588 172588 0 0.0
.bss 78612 78612 0 0.0
.data 3304 3304 0 0.0
.rodata 86939 86939 0 0.0
.text 589592 589592 0 0.0
shell LP_CC2652R7 (read only) 673310 673310 0 0.0
(read/write) 180016 180016 0 0.0
.bss 83020 83020 0 0.0
.data 3348 3348 0 0.0
.rodata 85486 85486 0 0.0
.text 587512 587512 0 0.0
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645097 645097 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87384 87384 0 0.0
.debug_frame 300248 300248 0 0.0
.debug_info 20245939 20245939 0 0.0
.debug_line 2660971 2660971 0 0.0
.debug_loc 2804896 2804896 0 0.0
.debug_ranges 283168 283168 0 0.0
.debug_str 3026947 3026947 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 379204 379204 0 0.0
.symtab 256912 256912 0 0.0
.text 536984 536984 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 589034 589034 0 0.0
.app_xip_area 465644 465644 0 0.0
.bss 65832 65832 0 0.0
.data 740 740 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 593290 593290 0 0.0
.app_xip_area 464604 464604 0 0.0
.bss 71120 71120 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 553606 553606 0 0.0
.app_xip_area 435808 435808 0 0.0
.bss 60280 60280 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1028364 1028364 0 0.0
.bss 179356 179356 0 0.0
.data 2052 2052 0 0.0
.text 846936 846936 0 0.0
BRD4187C (read/write) 1014500 1014492 -8 -0.0
.bss 148336 148336 0 0.0
.data 2696 2696 0 0.0
.text 838872 838864 -8 -0.0
lock-app BRD4161A+wf200 (read/write) 1080748 1080740 -8 -0.0
.bss 173772 173772 0 0.0
.data 2068 2068 0 0.0
.text 904888 904880 -8 -0.0
window-app BRD4187C (read/write) 1131268 1131268 0 0.0
.bss 132760 132760 0 0.0
.data 2588 2588 0 0.0
.text 971324 971324 0 0.0
k32w contact k32w0+release (read/write) 674176 674176 0 0.0
.bss 65532 65532 0 0.0
.data 2224 2224 0 0.0
.text 575020 575020 0 0.0
light k32w0+release (read/write) 673220 673220 0 0.0
.bss 65196 65196 0 0.0
.data 2212 2212 0 0.0
.text 574412 574412 0 0.0
lock k32w0+release (read/write) 627708 627708 0 0.0
.bss 63268 63268 0 0.0
.data 2136 2136 0 0.0
.text 547288 547288 0 0.0
linux chip-tool-ipv6only arm64 (read only) 1217145 1217145 0 0.0
(read/write) 733432 733432 0 0.0
.bss 34296 34296 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 675528 675528 0 0.0
.dynamic 560 560 0 0.0
.got 15392 15392 0 0.0
.init 24 24 0 0.0
.init_array 216 216 0 0.0
.rodata 588876 588876 0 0.0
.text 9841988 9841988 0 0.0
thermostat-no-ble arm64 (read only) 2523340 2523340 0 0.0
(read/write) 145240 145240 0 0.0
.bss 56344 56344 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 77696 77696 0 0.0
.dynamic 560 560 0 0.0
.got 5368 5368 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150920 150920 0 0.0
.text 2110032 2110032 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2468104 2468104 0 0.0
.bss 215964 215964 0 0.0
.data 5880 5880 0 0.0
.text 1430748 1430748 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1173368 1173368 0 0.0
bss 155557 155557 0 0.0
rodata 132648 132648 0 0.0
text 804400 804400 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1433388 1433388 0 0.0
bss 135297 135297 0 0.0
rodata 228700 228700 0 0.0
text 775316 775316 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1118616 1118616 0 0.0
bss 154713 154713 0 0.0
rodata 109464 109464 0 0.0
text 773792 773796 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 0 0 0 0.0
(read only) 840840 840840 0 0.0
(read/write) 1763412 1763412 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189864 189864 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2640 2640 0 0.0
.debug_abbrev 1253692 1253692 0 0.0
.debug_aranges 111512 111512 0 0.0
.debug_frame 374848 374848 0 0.0
.debug_info 27950283 27950284 1 0.0
.debug_line 3795927 3795927 0 0.0
.debug_loc 3701608 3701608 0 0.0
.debug_ranges 364976 364976 0 0.0
.debug_str 3536579 3536579 0 0.0
.heap 840840 840840 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 582647 582647 0 0.0
.symtab 426336 426336 0 0.0
.text 1562520 1562520 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 0 0 0 0.0
(read only) 841648 841648 0 0.0
(read/write) 1703764 1703764 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189064 189064 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2632 2632 0 0.0
.debug_abbrev 1239025 1239025 0 0.0
.debug_aranges 110744 110744 0 0.0
.debug_frame 377184 377184 0 0.0
.debug_info 27495547 27495548 1 0.0
.debug_line 3803426 3803426 0 0.0
.debug_loc 3684809 3684809 0 0.0
.debug_ranges 362912 362912 0 0.0
.debug_str 3523701 3523701 0 0.0
.heap 841648 841648 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 541953 541953 0 0.0
.symtab 411168 411168 0 0.0
.text 1503680 1503680 0 0.0
.zero.table 8 8 0 0.0
light cy8ckit_062s2_43012 0 0 0 0.0
(read only) 849912 849912 0 0.0
(read/write) 1617188 1617188 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180968 180968 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1074362 1074362 0 0.0
.debug_aranges 102952 102952 0 0.0
.debug_frame 347468 347468 0 0.0
.debug_info 22847381 22847381 0 0.0
.debug_line 3355967 3355967 0 0.0
.debug_loc 3359807 3359807 0 0.0
.debug_ranges 321448 321448 0 0.0
.debug_str 3322496 3322496 0 0.0
.heap 849912 849912 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 478079 478079 0 0.0
.symtab 379200 379200 0 0.0
.text 1425368 1425368 0 0.0
.zero.table 8 8 0 0.0
lock cy8ckit_062s2_43012 0 0 0 0.0
(read only) 822136 822136 0 0.0
(read/write) 1674148 1674148 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208728 208728 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2480 2480 0 0.0
.debug_abbrev 1076326 1076326 0 0.0
.debug_aranges 103352 103352 0 0.0
.debug_frame 349200 349200 0 0.0
.debug_info 23099440 23099441 1 0.0
.debug_line 3358353 3358353 0 0.0
.debug_loc 3383657 3383657 0 0.0
.debug_ranges 324048 324048 0 0.0
.debug_str 3341022 3341022 0 0.0
.heap 822136 822136 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 481542 481542 0 0.0
.symtab 381392 381392 0 0.0
.text 1454552 1454552 0 0.0
.zero.table 8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1153428 1153428 0 0.0
.bss 100076 100076 0 0.0
.data 852 852 0 0.0
.text 600524 600524 0 0.0
lock-app qpg6105+debug (read/write) 1120100 1120100 0 0.0
.bss 96468 96468 0 0.0
.data 864 864 0 0.0
.text 567200 567200 0 0.0

@cliffamzn cliffamzn force-pushed the ipv4 branch 3 times, most recently from 50f3754 to 4185cd5 Compare March 14, 2023 03:18
@github-actions
Copy link

PR #25668: Size comparison from 1ce3a1e to 4185cd5

Decreases (1 build for cc32xx)
platform target config section 1ce3a1e 4185cd5 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20245969 20245968 -1 -0.0
Full report (1 build for cc32xx)
platform target config section 1ce3a1e 4185cd5 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645489 645489 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87384 87384 0 0.0
.debug_frame 300248 300248 0 0.0
.debug_info 20245969 20245968 -1 -0.0
.debug_line 2660979 2660979 0 0.0
.debug_loc 2804893 2804893 0 0.0
.debug_ranges 283168 283168 0 0.0
.debug_str 3026947 3026947 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106009 106009 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380271 380271 0 0.0
.symtab 257312 257312 0 0.0
.text 537360 537360 0 0.0

@github-actions
Copy link

PR #25668: Size comparison from fa2e709 to 6203fd5

Decreases (1 build for cc32xx)
platform target config section fa2e709 6203fd5 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20245969 20245968 -1 -0.0
Full report (1 build for cc32xx)
platform target config section fa2e709 6203fd5 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645489 645489 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87384 87384 0 0.0
.debug_frame 300248 300248 0 0.0
.debug_info 20245969 20245968 -1 -0.0
.debug_line 2660979 2660979 0 0.0
.debug_loc 2804911 2804911 0 0.0
.debug_ranges 283168 283168 0 0.0
.debug_str 3026947 3026947 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106009 106009 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380271 380271 0 0.0
.symtab 257312 257312 0 0.0
.text 537360 537360 0 0.0

@github-actions
Copy link

PR #25668: Size comparison from 0c5d81d to 917d926

Full report (1 build for cc32xx)
platform target config section 0c5d81d 917d926 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645489 645489 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87384 87384 0 0.0
.debug_frame 300248 300248 0 0.0
.debug_info 20245969 20245969 0 0.0
.debug_line 2660979 2660979 0 0.0
.debug_loc 2804911 2804911 0 0.0
.debug_ranges 283168 283168 0 0.0
.debug_str 3026947 3026947 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106009 106009 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380271 380271 0 0.0
.symtab 257312 257312 0 0.0
.text 537360 537360 0 0.0

@github-actions
Copy link

github-actions bot commented Mar 14, 2023 •
edited
Loading

PR #25668: Size comparison from e778a03 to 930683f

Increases (1 build for psoc6)
platform target config section e778a03 930683f change % change
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27951257 27951258 1 0.0
Decreases (5 builds for bl602, bl702, efr32, psoc6)
platform target config section e778a03 930683f change % change
bl602 lighting-app bl602+rpc .text 1059896 1059892 -4 -0.0
bl702 lighting-app bl702 .debug_info 40833272 40833271 -1 -0.0
.text 959452 959450 -2 -0.0
bl702+rpc .debug_info 45459776 45459775 -1 -0.0
.text 1034794 1034792 -2 -0.0
efr32 lighting-app BRD4187C (read/write) 1014508 1014500 -8 -0.0
.text 838880 838872 -8 -0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 23099471 23099470 -1 -0.0
Full report (31 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, k32w, linux, mbed, psoc6, qpg)
platform target config section e778a03 930683f change % change
bl602 lighting-app bl602 (read/write) 1356586 1356586 0 0.0
.bss 94842 94842 0 0.0
.data 9744 9744 0 0.0
.text 1028960 1028960 0 0.0
bl602+rpc (read/write) 1402010 1402010 0 0.0
.bss 102890 102890 0 0.0
.data 10136 10136 0 0.0
.text 1059896 1059892 -4 -0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1188811 1188811 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 70113 70113 0 0.0
.bss_psram 26048 26048 0 0.0
.comment 48 48 0 0.0
.data 4072 4072 0 0.0
.debug_abbrev 1556799 1556799 0 0.0
.debug_aranges 134584 134584 0 0.0
.debug_frame 493292 493292 0 0.0
.debug_info 40833272 40833271 -1 -0.0
.debug_line 5294996 5294996 0 0.0
.debug_loc 3426764 3426764 0 0.0
.debug_ranges 373512 373512 0 0.0
.debug_str 3588025 3588025 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 108032 108032 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 577184 577184 0 0.0
.symtab 174224 174224 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
959452 959450 -2 -0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1279479 1279479 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 78161 78161 0 0.0
.bss_psram 26320 26320 0 0.0
.comment 48 48 0 0.0
.data 4616 4616 0 0.0
.debug_abbrev 1708914 1708914 0 0.0
.debug_aranges 142912 142912 0 0.0
.debug_frame 521236 521236 0 0.0
.debug_info 45459776 45459775 -1 -0.0
.debug_line 5700339 5700339 0 0.0
.debug_loc 3624755 3624755 0 0.0
.debug_ranges 397512 397512 0 0.0
.debug_str 3992214 3992214 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 122240 122240 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 638509 638509 0 0.0
.symtab 192720 192720 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1034794 1034792 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 682055 682055 0 0.0
(read/write) 169200 169200 0 0.0
.bss 80948 80948 0 0.0
.data 3352 3352 0 0.0
.rodata 88551 88551 0 0.0
.text 593188 593188 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 645367 645367 0 0.0
(read/write) 157616 157616 0 0.0
.bss 80148 80148 0 0.0
.data 3352 3352 0 0.0
.rodata 78423 78423 0 0.0
.text 566624 566624 0 0.0
lock-ftd LP_CC2652R7 (read only) 679215 679215 0 0.0
(read/write) 169504 169504 0 0.0
.bss 78500 78500 0 0.0
.data 3316 3316 0 0.0
.rodata 76791 76791 0 0.0
.text 601944 601944 0 0.0
lock-mtd LP_CC2652R7 (read only) 665179 665179 0 0.0
(read/write) 178700 178700 0 0.0
.bss 73660 73660 0 0.0
.data 3316 3316 0 0.0
.rodata 103595 103595 0 0.0
.text 561104 561104 0 0.0
pump-app LP_CC2652R7 (read only) 692043 692043 0 0.0
(read/write) 157420 157420 0 0.0
.bss 78476 78476 0 0.0
.data 3280 3280 0 0.0
.rodata 91019 91019 0 0.0
.text 600544 600544 0 0.0
pump-controller-app LP_CC2652R7 (read only) 676979 676979 0 0.0
(read/write) 172620 172620 0 0.0
.bss 78612 78612 0 0.0
.data 3304 3304 0 0.0
.rodata 86891 86891 0 0.0
.text 589608 589608 0 0.0
shell LP_CC2652R7 (read only) 673494 673494 0 0.0
(read/write) 179832 179832 0 0.0
.bss 83020 83020 0 0.0
.data 3348 3348 0 0.0
.rodata 85454 85454 0 0.0
.text 587728 587728 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (read only) 645489 645489 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87384 87384 0 0.0
.debug_frame 300248 300248 0 0.0
.debug_info 20245968 20245968 0 0.0
.debug_line 2660979 2660979 0 0.0
.debug_loc 2804911 2804911 0 0.0
.debug_ranges 283168 283168 0 0.0
.debug_str 3026947 3026947 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106009 106009 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380271 380271 0 0.0
.symtab 257312 257312 0 0.0
.text 0 0 0 0.0
537360 537360 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 589050 589050 0 0.0
.app_xip_area 465660 465660 0 0.0
.bss 65832 65832 0 0.0
.data 740 740 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 593306 593306 0 0.0
.app_xip_area 464620 464620 0 0.0
.bss 71120 71120 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 553606 553606 0 0.0
.app_xip_area 435808 435808 0 0.0
.bss 60280 60280 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1028380 1028380 0 0.0
.bss 179356 179356 0 0.0
.data 2052 2052 0 0.0
.text 846952 846952 0 0.0
BRD4187C (read/write) 1014508 1014500 -8 -0.0
.bss 148336 148336 0 0.0
.data 2696 2696 0 0.0
.text 838880 838872 -8 -0.0
lock-app BRD4161A+wf200 (read/write) 1080924 1080924 0 0.0
.bss 173772 173772 0 0.0
.data 2068 2068 0 0.0
.text 905064 905064 0 0.0
window-app BRD4187C (read/write) 1131268 1131268 0 0.0
.bss 132760 132760 0 0.0
.data 2588 2588 0 0.0
.text 971324 971324 0 0.0
k32w contact k32w0+release (read/write) 674176 674176 0 0.0
.bss 65532 65532 0 0.0
.data 2224 2224 0 0.0
.text 575020 575020 0 0.0
light k32w0+release (read/write) 673220 673220 0 0.0
.bss 65196 65196 0 0.0
.data 2212 2212 0 0.0
.text 574412 574412 0 0.0
lock k32w0+release (read/write) 627924 627924 0 0.0
.bss 63268 63268 0 0.0
.data 2136 2136 0 0.0
.text 547504 547504 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12174332 12174332 0 0.0
(read/write) 733432 733432 0 0.0
.bss 34296 34296 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 675528 675528 0 0.0
.dynamic 560 560 0 0.0
.got 15392 15392 0 0.0
.init 24 24 0 0.0
.init_array 216 216 0 0.0
.rodata 589420 589420 0 0.0
.text 9844324 9844324 0 0.0
thermostat-no-ble arm64 (read only) 2523340 2523340 0 0.0
(read/write) 145240 145240 0 0.0
.bss 56344 56344 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 77696 77696 0 0.0
.dynamic 560 560 0 0.0
.got 5368 5368 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150920 150920 0 0.0
.text 2110032 2110032 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2468312 2468312 0 0.0
.bss 215964 215964 0 0.0
.data 5880 5880 0 0.0
.text 1430956 1430956 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 0 0 0 0.0
(read only) 840840 840840 0 0.0
(read/write) 1763812 1763812 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189864 189864 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2640 2640 0 0.0
.debug_abbrev 1253731 1253731 0 0.0
.debug_aranges 111512 111512 0 0.0
.debug_frame 374852 374852 0 0.0
.debug_info 27951257 27951258 1 0.0
.debug_line 3796001 3796001 0 0.0
.debug_loc 3701501 3701501 0 0.0
.debug_ranges 364976 364976 0 0.0
.debug_str 3536796 3536796 0 0.0
.heap 840840 840840 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 583714 583714 0 0.0
.symtab 426736 426736 0 0.0
.text 1562920 1562920 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 0 0 0 0.0
(read only) 841648 841648 0 0.0
(read/write) 1704148 1704148 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189064 189064 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2632 2632 0 0.0
.debug_abbrev 1239064 1239064 0 0.0
.debug_aranges 110744 110744 0 0.0
.debug_frame 377188 377188 0 0.0
.debug_info 27496521 27496521 0 0.0
.debug_line 3803500 3803500 0 0.0
.debug_loc 3684704 3684704 0 0.0
.debug_ranges 362912 362912 0 0.0
.debug_str 3523918 3523918 0 0.0
.heap 841648 841648 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 543020 543020 0 0.0
.symtab 411568 411568 0 0.0
.text 1504064 1504064 0 0.0
.zero.table 8 8 0 0.0
light cy8ckit_062s2_43012 0 0 0 0.0
(read only) 849912 849912 0 0.0
(read/write) 1617204 1617204 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180968 180968 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1074362 1074362 0 0.0
.debug_aranges 102952 102952 0 0.0
.debug_frame 347468 347468 0 0.0
.debug_info 22847402 22847402 0 0.0
.debug_line 3355991 3355991 0 0.0
.debug_loc 3359603 3359603 0 0.0
.debug_ranges 321448 321448 0 0.0
.debug_str 3322511 3322511 0 0.0
.heap 849912 849912 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 478079 478079 0 0.0
.symtab 379200 379200 0 0.0
.text 1425384 1425384 0 0.0
.zero.table 8 8 0 0.0
lock cy8ckit_062s2_43012 0 0 0 0.0
(read only) 822136 822136 0 0.0
(read/write) 1674148 1674148 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208728 208728 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2480 2480 0 0.0
.debug_abbrev 1076326 1076326 0 0.0
.debug_aranges 103352 103352 0 0.0
.debug_frame 349204 349204 0 0.0
.debug_info 23099471 23099470 -1 -0.0
.debug_line 3358361 3358361 0 0.0
.debug_loc 3383657 3383657 0 0.0
.debug_ranges 324048 324048 0 0.0
.debug_str 3341022 3341022 0 0.0
.heap 822136 822136 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 481542 481542 0 0.0
.symtab 381392 381392 0 0.0
.text 1454552 1454552 0 0.0
.zero.table 8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1153444 1153444 0 0.0
.bss 100076 100076 0 0.0
.data 852 852 0 0.0
.text 600540 600540 0 0.0
lock-app qpg6105+debug (read/write) 1120300 1120300 0 0.0
.bss 96468 96468 0 0.0
.data 864 864 0 0.0
.text 567400 567400 0 0.0

cliffamzn and others added 2 commits March 16, 2023 12:07
@cliffamzn
Default to use an IPV4 address
3534469 
On some devices it appears that the commissioner may not have an
appropriate IPV6 address and attempts to send a user directed
commissioning request to a device using its IPV6 address.

Its a bit unclear how this situation happens but in theory it could
occur. In most cases this should be safe to default to an ipv4 address
if it is available.

The implementation of the user directed commissioning server does
something similar.
@cliffamzn
Expand on the error messaging to clarify ipv4 selection
ad98cf4
@github-actions
Copy link

PR #25668: Size comparison from 42a607c to ad98cf4

Decreases (1 build for cc32xx)
platform target config section 42a607c ad98cf4 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 2024602 20246023 -1 -0.0
Full report (1 build for cc32xx)
platform target config section 42a607c ad98cf4 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645489 645489 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930289 930289 0 0.0
.debug_aranges 87392 87392 0 0.0
.debug_frame 300284 300284 0 0.0
.debug_info 2024602 20246023 -1 -0.0
.debug_line 2661031 2661031 0 0.0
.debug_loc 2804874 2804874 0 0.0
.debug_ranges 283152 283152 0 0.0
.debug_str 3027037 3027037 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380331 380331 0 0.0
.symtab 257376 257376 0 0.0
.text 537376 537376 0 0.0

@yufengwangca yufengwangca merged commit 06273d7 into project-chip:master Mar 18, 2023
@cliffamzn cliffamzn deleted the ipv4 branch March 20, 2023 07:00
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@cliffamzn
Default to use an IPV4 address (project-chip#25668)
bc65cdb 
* Default to use an IPV4 address

On some devices it appears that the commissioner may not have an
appropriate IPV6 address and attempts to send a user directed
commissioning request to a device using its IPV6 address.

Its a bit unclear how this situation happens but in theory it could
occur. In most cases this should be safe to default to an ipv4 address
if it is available.

The implementation of the user directed commissioning server does
something similar.

* Expand on the error messaging to clarify ipv4 selection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple left review comments

@robszewczyk robszewczyk robszewczyk left review comments

@chrisdecenzo chrisdecenzo chrisdecenzo approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@sharadb-amazon sharadb-amazon sharadb-amazon approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cliffamzn @robszewczyk @sharadb-amazon @yufengwangca @chrisdecenzo @bzbarsky-apple