Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telink] Fix Factory Data build and handle it by CI #25655

Merged
merged 7 commits into from
Mar 16, 2023

Conversation

s07641069
Copy link
Contributor

Problem

Change overview

  • Fix factory data build with correct certs.
  • Handle building Lighting app with Factory Data feature by CI.

Testing

  • GitHub CI job "Build example Telink Lighting App with Factory Data" passed.

@github-actions
Copy link

PR #25655: Size comparison from bc8c9ec to 5362b60

Decreases (1 build for cc32xx)
platform target config section bc8c9ece 5362b60 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20275632 20275631 -1 -0.0
Full report (1 build for cc32xx)
platform target config section bc8c9ece 5362b60 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645097 645097 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87384 87384 0 0.0
.debug_frame 300248 300248 0 0.0
.debug_info 20275632 20275631 -1 -0.0
.debug_line 2660982 2660982 0 0.0
.debug_loc 2804957 2804957 0 0.0
.debug_ranges 283168 283168 0 0.0
.debug_str 3026158 3026158 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 379204 379204 0 0.0
.symtab 256912 256912 0 0.0
.text 536984 536984 0 0.0

@s07641069 s07641069 marked this pull request as draft March 13, 2023 13:38
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not noticing these uses of the DAC and PAI filenames...

@s07641069 s07641069 marked this pull request as ready for review March 14, 2023 13:27
@yufengwangca yufengwangca merged commit a82ea11 into project-chip:master Mar 16, 2023
@s07641069 s07641069 deleted the telink_factory_data_ci branch March 17, 2023 05:57
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
* [Telink] Fix factory data build with correct certs

* [Telink] Handle building Lighting app with Factory Data feature by CI

* [Telink] Add checkout_submodules for gn_gen

* [Telink] fix commands

* [Telink] Add BUILD_TYPE for ninja

* [Telink] Fix typo

* [Telink] Set correct path for find_program
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants