Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP32: Enable shell command for external platform feature #25648

Merged
merged 8 commits into from
Apr 1, 2023
Merged

ESP32: Enable shell command for external platform feature #25648

merged 8 commits into from
Apr 1, 2023

Conversation

abdulrehmanee12
Copy link
Contributor

Purpose
Enable shell command for external platform feature

Changes
Add new 'chip_shell_platform' argument in CmakeLists.txt
Add support for external platform in Build.gn

Test
Tested external platform example ''blemesh_bridge'' on ESP32-C3

@github-actions
Copy link

PR #25648: Size comparison from bc8c9ec to 8e7f432

Decreases (1 build for cc32xx)
platform target config section bc8c9ece 8e7f432 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20275632 20275630 -2 -0.0
Full report (1 build for cc32xx)
platform target config section bc8c9ece 8e7f432 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645097 645097 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87384 87384 0 0.0
.debug_frame 300248 300248 0 0.0
.debug_info 20275632 20275630 -2 -0.0
.debug_line 2660982 2660982 0 0.0
.debug_loc 2804957 2804957 0 0.0
.debug_ranges 283168 283168 0 0.0
.debug_str 3026158 3026158 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 379204 379204 0 0.0
.symtab 256912 256912 0 0.0
.text 536984 536984 0 0.0

@github-actions
Copy link

PR #25648: Size comparison from 1ce3a1e to 3e01d93

Full report (3 builds for cc32xx, qpg)
platform target config section 1ce3a1e 3e01d93 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645489 645489 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87384 87384 0 0.0
.debug_frame 300248 300248 0 0.0
.debug_info 20245969 20245969 0 0.0
.debug_line 2660979 2660979 0 0.0
.debug_loc 2804893 2804893 0 0.0
.debug_ranges 283168 283168 0 0.0
.debug_str 3026947 3026947 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106009 106009 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380271 380271 0 0.0
.symtab 257312 257312 0 0.0
.text 537360 537360 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1153444 1153444 0 0.0
.bss 100076 100076 0 0.0
.data 852 852 0 0.0
.text 600540 600540 0 0.0
lock-app qpg6105+debug (read/write) 1120300 1120300 0 0.0
.bss 96468 96468 0 0.0
.data 864 864 0 0.0
.text 567400 567400 0 0.0

@github-actions
Copy link

PR #25648: Size comparison from c1810b6 to e9d40ce

Decreases (1 build for cc32xx)
platform target config section c1810b6 e9d40ce change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20245969 20245968 -1 -0.0
Full report (2 builds for cc32xx, mbed)
platform target config section c1810b6 e9d40ce change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645489 645489 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87384 87384 0 0.0
.debug_frame 300248 300248 0 0.0
.debug_info 20245969 20245968 -1 -0.0
.debug_line 2660979 2660979 0 0.0
.debug_loc 2804911 2804911 0 0.0
.debug_ranges 283168 283168 0 0.0
.debug_str 3026947 3026947 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106009 106009 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380271 380271 0 0.0
.symtab 257312 257312 0 0.0
.text 537360 537360 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2468312 2468312 0 0.0
.bss 215964 215964 0 0.0
.data 5880 5880 0 0.0
.text 1430956 1430956 0 0.0

@github-actions
Copy link

PR #25648: Size comparison from 12bcb2c to f7a54b1

Full report (4 builds for cc32xx, mbed, qpg)
platform target config section 12bcb2c f7a54b1 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645489 645489 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87384 87384 0 0.0
.debug_frame 300248 300248 0 0.0
.debug_info 20245969 20245969 0 0.0
.debug_line 2660979 2660979 0 0.0
.debug_loc 2804911 2804911 0 0.0
.debug_ranges 283168 283168 0 0.0
.debug_str 3026947 3026947 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106009 106009 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380271 380271 0 0.0
.symtab 257312 257312 0 0.0
.text 537360 537360 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2468312 2468312 0 0.0
.bss 215964 215964 0 0.0
.data 5880 5880 0 0.0
.text 1430956 1430956 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1153444 1153444 0 0.0
.bss 100076 100076 0 0.0
.data 852 852 0 0.0
.text 600540 600540 0 0.0
lock-app qpg6105+debug (read/write) 1120300 1120300 0 0.0
.bss 96468 96468 0 0.0
.data 864 864 0 0.0
.text 567400 567400 0 0.0

@abdulrehmanee12 abdulrehmanee12 mentioned this pull request Mar 15, 2023
Closed
@github-actions
Copy link

PR #25648: Size comparison from 7a52877 to d1519bc

Increases (1 build for cc32xx)
platform target config section 7a52877 d1519bc change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20245968 20245969 1 0.0
Full report (2 builds for cc32xx, mbed)
platform target config section 7a52877 d1519bc change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645489 645489 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87384 87384 0 0.0
.debug_frame 300248 300248 0 0.0
.debug_info 20245968 20245969 1 0.0
.debug_line 2660979 2660979 0 0.0
.debug_loc 2804909 2804909 0 0.0
.debug_ranges 283168 283168 0 0.0
.debug_str 3026947 3026947 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106009 106009 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380271 380271 0 0.0
.symtab 257312 257312 0 0.0
.text 537360 537360 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2468312 2468312 0 0.0
.bss 215964 215964 0 0.0
.data 5880 5880 0 0.0
.text 1430956 1430956 0 0.0

@github-actions
Copy link

PR #25648: Size comparison from ec2ad41 to 05dbb07

Full report (1 build for cc32xx)
platform target config section ec2ad41 05dbb07 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645745 645745 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933102 933102 0 0.0
.debug_aranges 87704 87704 0 0.0
.debug_frame 301604 301604 0 0.0
.debug_info 20309905 20309905 0 0.0
.debug_line 2680953 2680953 0 0.0
.debug_loc 2827596 2827596 0 0.0
.debug_ranges 286376 286376 0 0.0
.debug_str 3041114 3041114 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105953 105953 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380555 380555 0 0.0
.symtab 257456 257456 0 0.0
.text 537672 537672 0 0.0

@yufengwangca yufengwangca merged commit 55ecc6e into project-chip:master Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wqx6 wqx6 wqx6 approved these changes

@shubhamdp shubhamdp shubhamdp approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@chshu chshu Awaiting requested review from chshu

Assignees
No one assigned
Labels
config lib review - approved shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@abdulrehmanee12 @shubhamdp @chshu @wqx6 @bzbarsky-apple @yufengwangca @restyled-commits