-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java] Add unit tests for TLV kotlin library #25639
Merged
yunhanw-google
merged 1 commit into
project-chip:master
from
yufengwangca:pr/kotlin/tlv_test
Mar 13, 2023
Merged
[Java] Add unit tests for TLV kotlin library #25639
yunhanw-google
merged 1 commit into
project-chip:master
from
yufengwangca:pr/kotlin/tlv_test
Mar 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock and
kkasperczyk-no
March 11, 2023 05:02
pullapprove
bot
requested review from
lpbeliveau-silabs,
LuDuda,
mrjerryjohns,
msandstedt,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
March 11, 2023 05:02
yunhanw-google
approved these changes
Mar 11, 2023
PR #25639: Size comparison from e1381bf to 3d5fc64 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
PR #25639: Size comparison from e1381bf to 0ba9524 Full report (1 build for cc32xx)
|
jmartinez-silabs
approved these changes
Mar 13, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
mwswartwout
pushed a commit
to mwswartwout/connectedhomeip
that referenced
this pull request
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit tests for TLV kotlin library
Fix: #25412
Currently, we need to run the unit test manually, we integrate the Java unit tests to CI in the follow-up PR
java -cp ./lib/third_party/connectedhomeip/src/controller/java/TlvReaderTest.jar:./lib/third_party/connectedhomeip/third_party/java_deps/junit-4.13.2.jar org.junit.runner.JUnitCore TlvReaderTest