Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing delay between UDC requests from 1000ms to 100ms #25635

Merged
merged 1 commit into from
Mar 11, 2023

Conversation

sharadb-amazon
Copy link
Contributor

Fixes #25634

Change summary

The Matter spec says it may send up to 4 retries (5 total) for UDC at least 100ms apart. However, so far the delay in the SDK for each request was 1 second - this delays the subsequent on-network commissioning process by 5+ seconds. This PR reduces that delay (per UDC request) to the minimum delay prescribed by the spec. This should help reduce the cumulative delay from 5 sec to 500ms.

Testing

Tested using the Android tv-casting-app sending UDC requests to the Linux tv-app. Observed that the requests are now sent just 100ms apart.

@github-actions
Copy link

PR #25635: Size comparison from 3c6bed3 to 29ffd4f

Decreases (1 build for cc32xx)
platform target config section 3c6bed3 29ffd4f change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20275631 20275630 -1 -0.0
Full report (1 build for cc32xx)
platform target config section 3c6bed3 29ffd4f change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645097 645097 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87384 87384 0 0.0
.debug_frame 300248 300248 0 0.0
.debug_info 20275631 20275630 -1 -0.0
.debug_line 2660982 2660982 0 0.0
.debug_loc 2804957 2804957 0 0.0
.debug_ranges 283168 283168 0 0.0
.debug_str 3026158 3026158 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 379204 379204 0 0.0
.symtab 256912 256912 0 0.0
.text 536984 536984 0 0.0

Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This runs more of a risk that a temporary network disruption will make the whole thing fail, but sure.

@sharadb-amazon sharadb-amazon merged commit e1381bf into project-chip:master Mar 11, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
mwswartwout pushed a commit to mwswartwout/connectedhomeip that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] UDC takes 4+ seconds
3 participants