Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESP32] Fix the wifi version returning WiFiVersionEnum::kA in case of error #25565

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

shubhamdp
Copy link
Contributor

Problem

Fixes #25544

Change Overview

  • If we do not find the wifi version then returning error.
  • Changed the magic numbers with enums in WiFiVersionEnum

Tests

  • Verified that correct value is being read using chip-tool.
  • Also, hardcoded the wifi version as kUnknownEnumValue and verified the value is null

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

PR #25565: Size comparison from 536a0d9 to 2990762

Decreases (1 build for cc32xx)
platform target config section 536a0d9 2990762 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20267387 20267386 -1 -0.0
Full report (1 build for cc32xx)
platform target config section 536a0d9 2990762 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644425 644425 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930235 930235 0 0.0
.debug_aranges 87344 87344 0 0.0
.debug_frame 300044 300044 0 0.0
.debug_info 20267387 20267386 -1 -0.0
.debug_line 2659771 2659771 0 0.0
.debug_loc 2802807 2802807 0 0.0
.debug_ranges 282960 282960 0 0.0
.debug_str 3024017 3024017 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256624 256624 0 0.0
.text 536372 536372 0 0.0

@shubhamdp
Copy link
Contributor Author

shubhamdp commented Mar 8, 2023

This will have a conflict with #25565. So, lets wait till that gets merge. I'll rebase this after that.

@shubhamdp shubhamdp force-pushed the esp32_wifi_version branch from 2990762 to 9d4d725 Compare March 8, 2023 14:32
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

PR #25565: Size comparison from 2086355 to 9d4d725

Full report (1 build for cc32xx)
platform target config section 2086355 9d4d725 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644425 644425 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930235 930235 0 0.0
.debug_aranges 87344 87344 0 0.0
.debug_frame 300044 300044 0 0.0
.debug_info 20267469 20267469 0 0.0
.debug_line 2659766 2659766 0 0.0
.debug_loc 2802853 2802853 0 0.0
.debug_ranges 282960 282960 0 0.0
.debug_str 3024079 3024079 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378571 378571 0 0.0
.symtab 256624 256624 0 0.0
.text 536372 536372 0 0.0

@yufengwangca yufengwangca merged commit de5cf94 into project-chip:master Mar 8, 2023
@shubhamdp shubhamdp deleted the esp32_wifi_version branch March 8, 2023 17:45
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
mwswartwout pushed a commit to mwswartwout/connectedhomeip that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESP32 GetWiFiVersionFromAPRecord has odd "default to 'a'" behavior
4 participants