Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up recommended nrf SDK revision to match chip-build images #25523

Closed
wants to merge 3 commits into from

Conversation

andy31415
Copy link
Contributor

#25428 bumped up docker image revision and #25456 started using the new images everywhere.

This fixes the recommended ncs revision for builds to match what dockerfiles contain.

@Damian-Nordic
Copy link
Contributor

hey, there's already #25432. We've just had to investigate some issues with unit tests, but I already figured it out so that PR should land soon.

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

PR #25523: Size comparison from fec6560 to 7b1edf6

Full report (1 build for cc32xx)
platform target config section fec6560 7b1edf6 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644425 644425 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930235 930235 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 300028 300028 0 0.0
.debug_info 2026706 2026706 0 0.0
.debug_line 2659698 2659698 0 0.0
.debug_loc 2802749 2802749 0 0.0
.debug_ranges 282952 282952 0 0.0
.debug_str 3023892 3023892 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256624 256624 0 0.0
.text 536372 536372 0 0.0

@andy31415
Copy link
Contributor Author

Closing - this is already covered by #25432

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

PR #25523: Size comparison from c14b011 to fd06b4d

Decreases (1 build for qpg)
platform target config section c14b011 fd06b4d change % change
qpg lighting-app qpg6105+debug (read/write) 1152020 1152012 -8 -0.0
.text 599116 599108 -8 -0.0
Full report (3 builds for cc32xx, qpg)
platform target config section c14b011 fd06b4d change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644425 644425 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930235 930235 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 300028 300028 0 0.0
.debug_info 20267066 20267066 0 0.0
.debug_line 2659698 2659698 0 0.0
.debug_loc 2802749 2802749 0 0.0
.debug_ranges 282952 282952 0 0.0
.debug_str 3023892 3023892 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256624 256624 0 0.0
.text 536372 536372 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1152020 1152012 -8 -0.0
.bss 99812 99812 0 0.0
.data 852 852 0 0.0
.text 599116 599108 -8 -0.0
lock-app qpg6105+debug (read/write) 1119084 1119084 0 0.0
.bss 96292 96292 0 0.0
.data 864 864 0 0.0
.text 566184 566184 0 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants