-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs]Rework KVS keymap implementation. #25503
Merged
bzbarsky-apple
merged 5 commits into
project-chip:master
from
jmartinez-silabs:kvsKeyMap_rework
Mar 7, 2023
Merged
[Silabs]Rework KVS keymap implementation. #25503
bzbarsky-apple
merged 5 commits into
project-chip:master
from
jmartinez-silabs:kvsKeyMap_rework
Mar 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anager to handle future migrations. Optimize baseApplication code
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmeg-sfy,
jtung-apple,
kcoppock and
kkasperczyk-no
March 6, 2023 22:27
pullapprove
bot
requested review from
msandstedt,
mspang,
nivi-apple,
pjzander-signify,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yunhanw-google
March 6, 2023 22:27
PR #25503: Size comparison from ce07f52 to 3abbbf6 Full report (1 build for cc32xx)
|
PR #25503: Size comparison from ce07f52 to 3bea7b3 Full report (1 build for cc32xx)
|
jepenven-silabs
approved these changes
Mar 7, 2023
yunhanw-google
approved these changes
Mar 7, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* Rework KVS keymap. Add a migration for the kvs changes and migrationManager to handle future migrations. Optimize baseApplication code * Restyled by whitespace * Restyled by clang-format * fix build for SED options * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues.
TC_RR_1.1 revealed a limitation with our kvs implementation. Testing the maximum number of fabrics and groups per fabric uses a high amount of keys to store. This caused our basic key mapping array, to utilize our nvm driver, to increase to size out of the capabilities of single object storage in our internal driver.
This PR mainly reworks our KVS Key map strategy to minimize the size of the keymap while also improving our total key count capacities.