-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java-matter-controller] Convert from java to kotlin phase II #25491
Merged
yunhanw-google
merged 2 commits into
project-chip:master
from
yufengwangca:pr/kotlin/pairing
Mar 8, 2023
Merged
[java-matter-controller] Convert from java to kotlin phase II #25491
yunhanw-google
merged 2 commits into
project-chip:master
from
yufengwangca:pr/kotlin/pairing
Mar 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple and
lazarkov
March 6, 2023 15:48
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yunhanw-google
March 6, 2023 15:48
PR #25491: Size comparison from 7e7b7af to d7ae990 Full report (2 builds for cc32xx, mbed)
|
g-coppock
suggested changes
Mar 6, 2023
...ava-matter-controller/java/src/com/matter/controller/commands/pairing/CloseSessionCommand.kt
Show resolved
Hide resolved
...ava-matter-controller/java/src/com/matter/controller/commands/pairing/DiscoveryFilterType.kt
Outdated
Show resolved
Hide resolved
...-matter-controller/java/src/com/matter/controller/commands/pairing/PairAddressPaseCommand.kt
Outdated
Show resolved
Hide resolved
...es/java-matter-controller/java/src/com/matter/controller/commands/pairing/PairCodeCommand.kt
Show resolved
Hide resolved
...atter-controller/java/src/com/matter/controller/commands/pairing/PairOnNetworkLongCommand.kt
Outdated
Show resolved
Hide resolved
...les/java-matter-controller/java/src/com/matter/controller/commands/pairing/PairingCommand.kt
Outdated
Show resolved
Hide resolved
...les/java-matter-controller/java/src/com/matter/controller/commands/pairing/PairingCommand.kt
Outdated
Show resolved
Hide resolved
...les/java-matter-controller/java/src/com/matter/controller/commands/pairing/PairingCommand.kt
Outdated
Show resolved
Hide resolved
...les/java-matter-controller/java/src/com/matter/controller/commands/pairing/PairingCommand.kt
Outdated
Show resolved
Hide resolved
...es/java-matter-controller/java/src/com/matter/controller/commands/pairing/PairingModeType.kt
Outdated
Show resolved
Hide resolved
g-coppock
approved these changes
Mar 7, 2023
...les/java-matter-controller/java/src/com/matter/controller/commands/pairing/PairingCommand.kt
Outdated
Show resolved
Hide resolved
...les/java-matter-controller/java/src/com/matter/controller/commands/pairing/PairingCommand.kt
Outdated
Show resolved
Hide resolved
...les/java-matter-controller/java/src/com/matter/controller/commands/pairing/PairingCommand.kt
Show resolved
Hide resolved
PR #25491: Size comparison from 2a6f4ef to f34fce7 Increases (3 builds for bl702, cc13x2_26x2)
Decreases (4 builds for bl602, cc13x2_26x2, cc32xx, qpg)
Full report (16 builds for bl602, bl702, cc13x2_26x2, cc32xx, linux, qpg)
|
yunhanw-google
approved these changes
Mar 7, 2023
andy31415
approved these changes
Mar 7, 2023
PR #25491: Size comparison from c69e90d to d456ce5 Increases (4 builds for bl602, cc13x2_26x2, psoc6)
Decreases (6 builds for bl602, bl702, cc13x2_26x2, cyw30739, psoc6)
Full report (30 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
yunhanw-google
approved these changes
Mar 8, 2023
joonhaengHeo
approved these changes
Mar 8, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…t-chip#25491) * [java-matter-controller] Convert from java to kotlin phase II * Address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert from java to kotlin phase II
Fix: Convert java matter controller test program from java version into kotlin version #25253