-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JAVA/JNI Invoke command API #25476
Merged
yunhanw-google
merged 3 commits into
project-chip:master
from
yunhanw-google:feature/java-im-invoke
Mar 7, 2023
Merged
Add JAVA/JNI Invoke command API #25476
yunhanw-google
merged 3 commits into
project-chip:master
from
yunhanw-google:feature/java-im-invoke
Mar 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunhanw-google
force-pushed
the
feature/java-im-invoke
branch
from
March 6, 2023 05:41
257edcd
to
e0e8fa7
Compare
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple and
kcoppock
March 6, 2023 05:41
yunhanw-google
force-pushed
the
feature/java-im-invoke
branch
from
March 6, 2023 05:50
e0e8fa7
to
08a3e36
Compare
PR #25476: Size comparison from 32fb896 to 08a3e36 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
g-coppock
suggested changes
Mar 6, 2023
...roller/java/src/com/matter/controller/commands/pairing/PairOnNetworkLongImInvokeCommand.java
Outdated
Show resolved
Hide resolved
...roller/java/src/com/matter/controller/commands/pairing/PairOnNetworkLongImInvokeCommand.java
Outdated
Show resolved
Hide resolved
src/controller/java/src/chip/devicecontroller/InvokeCallbackJni.java
Outdated
Show resolved
Hide resolved
src/controller/java/src/chip/devicecontroller/model/InvokeElement.java
Outdated
Show resolved
Hide resolved
src/controller/java/src/chip/devicecontroller/model/InvokeElement.java
Outdated
Show resolved
Hide resolved
src/controller/java/src/chip/devicecontroller/model/InvokeElement.java
Outdated
Show resolved
Hide resolved
src/controller/java/src/chip/devicecontroller/model/InvokeElement.java
Outdated
Show resolved
Hide resolved
yunhanw-google
force-pushed
the
feature/java-im-invoke
branch
from
March 6, 2023 18:56
a63953c
to
1377a13
Compare
g-coppock
approved these changes
Mar 6, 2023
yufengwangca
approved these changes
Mar 6, 2023
PR #25476: Size comparison from d44b6a6 to 1377a13 Decreases (1 build for qpg)
Full report (3 builds for cc32xx, qpg)
|
yunhanw-google
force-pushed
the
feature/java-im-invoke
branch
from
March 6, 2023 20:20
1377a13
to
4f0de24
Compare
andy31415
approved these changes
Mar 6, 2023
joonhaengHeo
approved these changes
Mar 7, 2023
jmartinez-silabs
approved these changes
Mar 7, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* Add Java/JNI Invoke command API * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- Add generic IM Invoke API which takes concrete command path and arguments with tlv blob format, when receiving invoke response, we would store data as tlv and json format, similar to report data in read/subscribe interaction.
-- Add initial IM write test in java matter controller test example,
next step is to integrate kotlin tlvwriter/tlvreader, and refactor this test command to accept the customized parameters for command path and arguments.