Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JAVA/JNI Invoke command API #25476

Merged

Conversation

yunhanw-google
Copy link
Contributor

-- Add generic IM Invoke API which takes concrete command path and arguments with tlv blob format, when receiving invoke response, we would store data as tlv and json format, similar to report data in read/subscribe interaction.
-- Add initial IM write test in java matter controller test example,

next step is to integrate kotlin tlvwriter/tlvreader, and refactor this test command to accept the customized parameters for command path and arguments.

@yunhanw-google yunhanw-google force-pushed the feature/java-im-invoke branch from e0e8fa7 to 08a3e36 Compare March 6, 2023 05:50
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

PR #25476: Size comparison from 32fb896 to 08a3e36

Increases (1 build for cc32xx)
platform target config section 32fb896 08a3e36 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20262927 20262928 1 0.0
Full report (1 build for cc32xx)
platform target config section 32fb896 08a3e36 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643465 643465 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930213 930213 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 300024 300024 0 0.0
.debug_info 20262927 20262928 1 0.0
.debug_line 2657822 2657822 0 0.0
.debug_loc 2800026 2800026 0 0.0
.debug_ranges 282240 282240 0 0.0
.debug_str 3023883 3023883 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256560 256560 0 0.0
.text 535412 535412 0 0.0

@yunhanw-google yunhanw-google enabled auto-merge (squash) March 6, 2023 19:13
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

PR #25476: Size comparison from d44b6a6 to 1377a13

Decreases (1 build for qpg)
platform target config section d44b6a6 1377a13 change % change
qpg lock-app qpg6105+debug (read/write) 1118868 1118860 -8 -0.0
.text 565968 565960 -8 -0.0
Full report (3 builds for cc32xx, qpg)
platform target config section d44b6a6 1377a13 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643465 643465 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930213 930213 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 300024 300024 0 0.0
.debug_info 20262928 20262928 0 0.0
.debug_line 2657822 2657822 0 0.0
.debug_loc 2800026 2800026 0 0.0
.debug_ranges 282240 282240 0 0.0
.debug_str 3023883 3023883 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256560 256560 0 0.0
.text 535412 535412 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151820 1151820 0 0.0
.bss 99812 99812 0 0.0
.data 852 852 0 0.0
.text 598916 598916 0 0.0
lock-app qpg6105+debug (read/write) 1118868 1118860 -8 -0.0
.bss 96292 96292 0 0.0
.data 864 864 0 0.0
.text 565968 565960 -8 -0.0

@yunhanw-google yunhanw-google disabled auto-merge March 6, 2023 19:45
@yunhanw-google yunhanw-google force-pushed the feature/java-im-invoke branch from 1377a13 to 4f0de24 Compare March 6, 2023 20:20
@yunhanw-google yunhanw-google enabled auto-merge (squash) March 6, 2023 20:21
@yunhanw-google yunhanw-google merged commit 37c52c4 into project-chip:master Mar 7, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
* Add Java/JNI Invoke command API

* address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants