add invoke element in java controller #25470

yunhanw-google · 2023-03-03T22:54:34Z

--Add invoke element in java controller

src/controller/java/src/chip/devicecontroller/model/AttributeWriteRequest.java

src/controller/java/src/chip/devicecontroller/model/InvokeRequest.java

github-actions · 2023-03-03T23:18:10Z

PR #25470: Size comparison from 105b98b to bc2088a

Decreases (1 build for cc32xx)

platform	target	config	section	`105b98b`	`bc2088a`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20262928	20262927	-1	-0.0

Full report (1 build for cc32xx)

platform	target	config	section	`105b98b`	`bc2088a`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0	0.0
			(read only)	643465	643465	0	0.0
			(read/write)	203688	203688	0	0.0
			.ARM.attributes	44	44	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	197088	197088	0	0.0
			.comment	194	194	0	0.0
			.data	1480	1480	0	0.0
			.debug_abbrev	930213	930213	0	0.0
			.debug_aranges	87336	87336	0	0.0
			.debug_frame	300024	300024	0	0.0
			.debug_info	20262928	20262927	-1	-0.0
			.debug_line	`2657820`	`2657820`	0	0.0
			.debug_loc	2800026	2800026	0	0.0
			.debug_ranges	282240	282240	0	0.0
			.debug_str	3023883	3023883	0	0.0
			.ramVecs	780	780	0	0.0
			.resetVecs	64	64	0	0.0
			.rodata	105929	105929	0	0.0
			.shstrtab	232	232	0	0.0
			.stab	204	204	0	0.0
			.stabstr	441	441	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	378514	378514	0	0.0
			.symtab	256560	256560	0	0.0
			.text	535412	535412	0	0.0

yufengwangca · 2023-03-04T00:45:54Z

LGTM, provided kevin's left comments are addressed

github-actions · 2023-03-04T00:55:38Z

PR #25470: Size comparison from 105b98b to 4d1dc14

Increases (2 builds for nrfconnect, qpg)

platform	target	config	section	`105b98b`	`4d1dc14`	change
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	text	808256	808260	4
qpg	lighting-app	qpg6105+debug	(read/write)	`1151844`	1151852	8
			.text	598940	598948	8

Full report (9 builds for cc32xx, linux, mbed, nrfconnect, qpg)

platform	target	config	section	`105b98b`	`4d1dc14`	change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	643465	643465	0
			(read/write)	203688	203688	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197088	197088	0
			.comment	194	194	0
			.data	1480	1480	0
			.debug_abbrev	930213	930213	0
			.debug_aranges	87336	87336	0
			.debug_frame	300024	300024	0
			.debug_info	20262928	20262928	0
			.debug_line	`2657820`	`2657820`	0
			.debug_loc	2800026	2800026	0
			.debug_ranges	282240	282240	0
			.debug_str	3023883	3023883	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	105929	105929	0
			.shstrtab	232	232	0
			.stab	204	204	0
			.stabstr	441	441	0
			.stack	2048	2048	0
			.strtab	378514	378514	0
			.symtab	256560	256560	0
			.text	535412	535412	0
linux	chip-tool-ipv6only	arm64	(read only)	12138436	12138436	0
			(read/write)	733448	733448	0
			.bss	34296	34296	0
			.data	3008	3008	0
			.data.rel.ro	675552	675552	0
			.dynamic	560	560	0
			.got	15376	15376	0
			.init	24	24	0
			.init_array	216	216	0
			.rodata	587188	587188	0
			.text	9810628	9810628	0
	thermostat-no-ble	arm64	(read only)	2520500	2520500	0
			(read/write)	145224	145224	0
			.bss	56344	56344	0
			.data	1784	1784	0
			.data.rel.ro	77688	77688	0
			.dynamic	560	560	0
			.got	5360	5360	0
			.init	24	24	0
			.init_array	432	432	0
			.rodata	150784	150784	0
			.text	2107328	2107328	0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0
			(read/write)	`2467384`	`2467384`	0
			.bss	215804	215804	0
			.data	5880	5880	0
			.text	1430028	1430028	0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read only)	4	4	0
			(read/write)	1167876	1167876	0
			bss	143423	143423	0
			rodata	136352	136352	0
			text	808256	808260	4
	all-clusters-minimal-app	nrf52840dk_nrf52840	(read only)	4	4	0
			(read/write)	`1112896`	`1112896`	0
			bss	142579	142579	0
			rodata	113196	113196	0
			text	777404	777404	0
	all-clusters-app	nrf7002dk_nrf5340_cpuapp	(read only)	4	4	0
			(read/write)	1372880	1372880	0
			bss	105902	105902	0
			rodata	213740	213740	0
			text	767744	767744	0
qpg	lighting-app	qpg6105+debug	(read/write)	`1151844`	1151852	8
			.bss	99812	99812	0
			.data	852	852	0
			.text	598940	598948	8
	lock-app	qpg6105+debug	(read/write)	`1118892`	`1118892`	0
			.bss	96292	96292	0
			.data	864	864	0
			.text	565992	565992	0

github-actions · 2023-03-04T03:50:05Z

PR #25470: Size comparison from aa99d09 to 3d68ea6

Increases (1 build for cc32xx)

platform	target	config	section	`aa99d09`	`3d68ea6`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20262927	20262928	1	0.0

Full report (1 build for cc32xx)

platform	target	config	section	`aa99d09`	`3d68ea6`	change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	643465	643465	0
			(read/write)	203688	203688	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197088	197088	0
			.comment	194	194	0
			.data	1480	1480	0
			.debug_abbrev	930213	930213	0
			.debug_aranges	87336	87336	0
			.debug_frame	300024	300024	0
			.debug_info	20262927	20262928	1
			.debug_line	`2657822`	`2657822`	0
			.debug_loc	2800026	2800026	0
			.debug_ranges	282240	282240	0
			.debug_str	3023883	3023883	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	105929	105929	0
			.shstrtab	232	232	0
			.stab	204	204	0
			.stabstr	441	441	0
			.stack	2048	2048	0
			.strtab	378514	378514	0
			.symtab	256560	256560	0
			.text	535412	535412	0

github-actions · 2023-03-04T05:50:42Z

PR #25470: Size comparison from aa99d09 to fd370e1

Increases (1 build for cc32xx)

platform	target	config	section	`aa99d09`	`fd370e1`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20262927	20262928	1	0.0

Full report (1 build for cc32xx)

platform	target	config	section	`aa99d09`	`fd370e1`	change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	643465	643465	0
			(read/write)	203688	203688	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197088	197088	0
			.comment	194	194	0
			.data	1480	1480	0
			.debug_abbrev	930213	930213	0
			.debug_aranges	87336	87336	0
			.debug_frame	300024	300024	0
			.debug_info	20262927	20262928	1
			.debug_line	`2657822`	`2657822`	0
			.debug_loc	2800026	2800026	0
			.debug_ranges	282240	282240	0
			.debug_str	3023883	3023883	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	105929	105929	0
			.shstrtab	232	232	0
			.stab	204	204	0
			.stabstr	441	441	0
			.stack	2048	2048	0
			.strtab	378514	378514	0
			.symtab	256560	256560	0
			.text	535412	535412	0

rename the invoke request to invoke element since this class would be used in request and response.

github-actions · 2023-03-04T08:17:11Z

PR #25470: Size comparison from aa99d09 to c5d0427

Full report (1 build for cc32xx)

platform	target	config	section	`aa99d09`	`c5d0427`
cc32xx	lock	CC3235SF_LAUNCHXL		0	0
			(read only)	643465	643465
			(read/write)	203688	203688
			.ARM.attributes	44	44
			.ARM.exidx	8	8
			.bss	197088	197088
			.comment	194	194
			.data	1480	1480
			.debug_abbrev	930213	930213
			.debug_aranges	87336	87336
			.debug_frame	300024	300024
			.debug_info	20262927	20262927
			.debug_line	`2657822`	`2657822`
			.debug_loc	2800026	2800026
			.debug_ranges	282240	282240
			.debug_str	3023883	3023883
			.ramVecs	780	780
			.resetVecs	64	64
			.rodata	105929	105929
			.shstrtab	232	232
			.stab	204	204
			.stabstr	441	441
			.stack	2048	2048
			.strtab	378514	378514
			.symtab	256560	256560
			.text	535412	535412

src/controller/java/src/chip/devicecontroller/model/InvokeElement.java

github-actions bot added the controller label Mar 3, 2023

yunhanw-google force-pushed the feature/InvokeRequest branch from 6f8461e to bc2088a Compare March 3, 2023 22:57

g-coppock approved these changes Mar 3, 2023

View reviewed changes

src/controller/java/src/chip/devicecontroller/model/AttributeWriteRequest.java Outdated Show resolved Hide resolved

src/controller/java/src/chip/devicecontroller/model/InvokeRequest.java Outdated Show resolved Hide resolved

yufengwangca approved these changes Mar 4, 2023

View reviewed changes

yunhanw-google force-pushed the feature/InvokeRequest branch from 4d1dc14 to 3c8904f Compare March 4, 2023 03:16

yunhanw-google enabled auto-merge (squash) March 4, 2023 03:16

add invoke request in java controoler

1023101

yunhanw-google force-pushed the feature/InvokeRequest branch from 3c8904f to 1023101 Compare March 4, 2023 03:18

pullapprove bot requested review from amitnj, anush-apple, arkq, Byungjoo-Lee, bzbarsky-apple, carol-apple, chrisdecenzo, chshu, chulspro, cliffamzn, Damian-Nordic, dhrishi, electrocucaracha, franck-apple, gjc13, harsha-rajendran, hawk248, jelderton and jepenven-silabs March 4, 2023 03:19

pullapprove bot requested review from msandstedt, nivi-apple, pjzander-signify, saurabhst, selissia, sharadb-amazon, tecimovic, vijs, vivien-apple, woody-apple and xylophone21 March 4, 2023 03:19

pullapprove bot added the review - pending label Mar 4, 2023

yunhanw-google force-pushed the feature/InvokeRequest branch from 1023101 to 3d68ea6 Compare March 4, 2023 03:34

yunhanw-google force-pushed the feature/InvokeRequest branch 2 times, most recently from a152600 to fd370e1 Compare March 4, 2023 05:37

yunhanw-google changed the title ~~add invoke request in java controoler~~ add invoke element in java controoler Mar 4, 2023

yunhanw-google force-pushed the feature/InvokeRequest branch from fd370e1 to d9f0805 Compare March 4, 2023 08:05

move the invoke request to invoke element

c5d0427

rename the invoke request to invoke element since this class would be used in request and response.

yunhanw-google force-pushed the feature/InvokeRequest branch from d9f0805 to c5d0427 Compare March 4, 2023 08:06

cliffamzn reviewed Mar 4, 2023

View reviewed changes

src/controller/java/src/chip/devicecontroller/model/InvokeElement.java Show resolved Hide resolved

cliffamzn approved these changes Mar 4, 2023

View reviewed changes

pullapprove bot added review - approved and removed review - pending labels Mar 4, 2023

yunhanw-google mentioned this pull request Mar 4, 2023

Add javadoc for invokeElement #25473

Open

yunhanw-google merged commit 32fb896 into project-chip:master Mar 4, 2023

yunhanw-google changed the title ~~add invoke element in java controoler~~ add invoke element in java controller Mar 4, 2023

lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023

add invoke request in java controoler (project-chip#25470)

8da3374

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add invoke element in java controller #25470

add invoke element in java controller #25470

yunhanw-google commented Mar 3, 2023 •

edited

Loading

github-actions bot commented Mar 3, 2023

yufengwangca commented Mar 4, 2023

github-actions bot commented Mar 4, 2023

github-actions bot commented Mar 4, 2023

github-actions bot commented Mar 4, 2023

github-actions bot commented Mar 4, 2023

add invoke element in java controller #25470

add invoke element in java controller #25470

Conversation

yunhanw-google commented Mar 3, 2023 • edited Loading

github-actions bot commented Mar 3, 2023

yufengwangca commented Mar 4, 2023

github-actions bot commented Mar 4, 2023

github-actions bot commented Mar 4, 2023

github-actions bot commented Mar 4, 2023

github-actions bot commented Mar 4, 2023

yunhanw-google commented Mar 3, 2023 •

edited

Loading