Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace kotlinx.android.parcel package with kotlinx.parcelize #25422

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Replace kotlinx.android.parcel package with kotlinx.parcelize #25422

merged 1 commit into from
Mar 2, 2023

Conversation

yufengwangca
Copy link
Contributor

We have following warning when build Android CHIPTool:

2023-02-27 19:04:33 INFO w: /home/yufengw/connectedhomeip/examples/android/CHIPTool/app/src/main/java/com/google/chip/chiptool/setuppayloadscanner/QrCodeInfo.kt: (7, 1): Parcelize annotations from package 'kotlinx.android.parcel' are deprecated. Change package to 'kotlinx.parcelize'

The kotlinx.android.parcel package has been deprecated in favor of kotlinx.parcelize. kotlinx.parcelize provides a more efficient and flexible way to serialize and deserialize Kotlin classes, and is not limited to just Android use cases. It uses code generation to create Parcelable implementations at compile time, instead of relying on reflection at runtime like kotlinx.android.parcel did.

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

PR #25422: Size comparison from 1a1d0c3 to 6225f79

Increases (1 build for cc32xx)
platform target config section 1a1d0c3 6225f79 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20262923 2026292 1 0.0
Full report (4 builds for cc32xx, mbed, qpg)
platform target config section 1a1d0c3 6225f79 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643465 643465 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930213 930213 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 300024 300024 0 0.0
.debug_info 20262923 2026292 1 0.0
.debug_line 2657815 2657815 0 0.0
.debug_loc 2800026 2800026 0 0.0
.debug_ranges 282240 282240 0 0.0
.debug_str 3023883 3023883 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256560 256560 0 0.0
.text 535412 535412 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467384 2467384 0 0.0
.bss 215804 215804 0 0.0
.data 5880 5880 0 0.0
.text 1430028 1430028 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151684 1151684 0 0.0
.bss 99804 99804 0 0.0
.data 852 852 0 0.0
.text 598780 598780 0 0.0
lock-app qpg6105+debug (read/write) 1118892 1118892 0 0.0
.bss 96292 96292 0 0.0
.data 864 864 0 0.0
.text 565992 565992 0 0.0

@andy31415 andy31415 merged commit 78f5d63 into project-chip:master Mar 2, 2023
@yufengwangca yufengwangca deleted the pr/example/android branch March 2, 2023 16:00
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants