-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Support Manual Pairing Code #25333
Merged
andy31415
merged 4 commits into
project-chip:master
from
joonhaengHeo:support_android_manual_pairing_code
Mar 1, 2023
Merged
[Android] Support Manual Pairing Code #25333
andy31415
merged 4 commits into
project-chip:master
from
joonhaengHeo:support_android_manual_pairing_code
Mar 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple and
lazarkov
February 27, 2023 01:47
pullapprove
bot
requested review from
mspang,
nivi-apple,
pjzander-signify,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
February 27, 2023 01:47
PR #25333: Size comparison from 3b80154 to af1d334 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
yunhanw-google
approved these changes
Feb 28, 2023
andy31415
reviewed
Feb 28, 2023
...d/CHIPTool/app/src/main/java/com/google/chip/chiptool/setuppayloadscanner/BarcodeFragment.kt
Outdated
Show resolved
Hide resolved
PR #25333: Size comparison from 3957377 to b43129e Increases (1 build for cc13x2_26x2)
Decreases (5 builds for bl602, bl702, cc13x2_26x2, cc32xx, qpg)
Full report (19 builds for bl602, bl702, cc13x2_26x2, cc32xx, k32w, linux, qpg)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* Support Manual Pairing Code in Android * Modify some errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For commissioning test using manual pairing code, some Android UI is changed.