Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-fabric-filtered reads of Group Key Management attributes. #25319

Merged

Conversation

bzbarsky-apple
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple commented Feb 24, 2023

We were only returning the entries for the accessing fabric, not for all fabrics.

Fixes #23322

We were only returning the entries for the accessing fabric, not for
all fabrics.

Fixes project-chip#23322
@github-actions
Copy link

PR #25319: Size comparison from 95772ae to 9090931

Increases above 0.2%:

platform target config section 95772ae 9090931 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_ranges 281768 282480 712 0.3
Increases (1 build for cc32xx)
platform target config section 95772ae 9090931 change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 642681 643497 816 0.1
.debug_abbrev 930077 930099 22 0.0
.debug_frame 299816 299820 4 0.0
.debug_info 20256907 20260684 3777 0.0
.debug_line 2656086 2657644 1558 0.1
.debug_loc 2797535 2800203 2668 0.1
.debug_ranges 281768 282480 712 0.3
.symtab 256256 256320 64 0.0
.text 534788 535604 816 0.2
Decreases (1 build for cc32xx)
platform target config section 95772ae 9090931 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_str 3023369 3023367 -2 -0.0
Full report (1 build for cc32xx)
platform target config section 95772ae 9090931 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642681 643497 816 0.1
(read/write) 203672 203672 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197072 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930077 930099 22 0.0
.debug_aranges 87280 87280 0 0.0
.debug_frame 299816 299820 4 0.0
.debug_info 20256907 20260684 3777 0.0
.debug_line 2656086 2657644 1558 0.1
.debug_loc 2797535 2800203 2668 0.1
.debug_ranges 281768 282480 712 0.3
.debug_str 3023369 3023367 -2 -0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105769 105769 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256256 256320 64 0.0
.text 534788 535604 816 0.2

@pullapprove pullapprove bot requested a review from sharadb-amazon February 28, 2023 02:55
@jmartinez-silabs jmartinez-silabs merged commit a66e9fc into project-chip:master Mar 7, 2023
@bzbarsky-apple bzbarsky-apple deleted the fix-group-key-reads branch March 7, 2023 02:29
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
…oject-chip#25319)

We were only returning the entries for the accessing fabric, not for
all fabrics.

Fixes project-chip#23322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] GroupKeyManagement ignores fabricFiltered request
4 participants