-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix non-fabric-filtered reads of Group Key Management attributes. #25319
Merged
jmartinez-silabs
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-group-key-reads
Mar 7, 2023
Merged
Fix non-fabric-filtered reads of Group Key Management attributes. #25319
jmartinez-silabs
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-group-key-reads
Mar 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple and
lazarkov
February 24, 2023 23:45
pullapprove
bot
requested review from
mspang,
nivi-apple,
pjzander-signify,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
February 24, 2023 23:45
We were only returning the entries for the accessing fabric, not for all fabrics. Fixes project-chip#23322
bzbarsky-apple
force-pushed
the
fix-group-key-reads
branch
from
February 24, 2023 23:46
99d14b5
to
9090931
Compare
PR #25319: Size comparison from 95772ae to 9090931 Increases above 0.2%:
Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
tcarmelveilleux
approved these changes
Feb 28, 2023
cliffamzn
approved these changes
Feb 28, 2023
jmartinez-silabs
approved these changes
Mar 7, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…oject-chip#25319) We were only returning the entries for the accessing fabric, not for all fabrics. Fixes project-chip#23322
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were only returning the entries for the accessing fabric, not for all fabrics.
Fixes #23322