Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Convert the last java file in Android CHIPTool to kotlin #25236

Merged
merged 2 commits into from
Feb 22, 2023
Merged

[Android] Convert the last java file in Android CHIPTool to kotlin #25236

merged 2 commits into from
Feb 22, 2023

Conversation

yufengwangca
Copy link
Contributor

Convert the last java file in Android CHIPTool to kotlin.

@yufengwangca yufengwangca changed the title [Android] Convert NetworkCredentialsParcelable.java to NetworkCredentialsParcel… [Android] Convert the last java file in Android CHIPTool to kotlin Feb 22, 2023
@github-actions
Copy link

PR #25236: Size comparison from cad990f to 4b7fa20

Full report (1 build for cc32xx)
platform target config section cad990f 4b7fa20 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642545 642545 0 0.0
(read/write) 203664 203664 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197064 197064 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930168 930168 0 0.0
.debug_aranges 87272 87272 0 0.0
.debug_frame 299752 299752 0 0.0
.debug_info 20254060 20254060 0 0.0
.debug_line 2655143 2655143 0 0.0
.debug_loc 2795383 2795383 0 0.0
.debug_ranges 281592 281592 0 0.0
.debug_str 3017876 3017876 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105817 105817 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377610 377610 0 0.0
.symtab 256144 256144 0 0.0
.text 534604 534604 0 0.0

@github-actions
Copy link

github-actions bot commented Feb 22, 2023 •
edited
Loading

PR #25236: Size comparison from fd74ca2 to 52b48d8

Increases (9 builds for bl702, cc32xx, psoc6, telink)
platform target config section fd74ca2 52b48d8 change % change
bl702 lighting-app bl702 .debug_info 40594484 40594485 1 0.0
.text 954966 954968 2 0.0
bl702+rpc .debug_info 45006769 45006771 2 0.0
.text 1032374 1032378 4 0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20254045 20254046 1 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27970776 27970777 1 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 27515375 27515376 1 0.0
telink all-clusters-app tlsr9518adk80d text 687174 687176 2 0.0
all-clusters-minimal-app tlsr9518adk80d text 648574 648576 2 0.0
contact-sensor-app tlsr9518adk80d (read/write) 856016 856024 8 0.0
text 578924 578926 2 0.0
lighting-app tlsr9518adk80d (read/write) 950448 950456 8 0.0
text 659388 659392 4 0.0
Decreases (3 builds for k32w, telink)
platform target config section fd74ca2 52b48d8 change % change
k32w light k32w0+release (read/write) 669012 668996 -16 -0.0
.text 570480 570464 -16 -0.0
telink ota-requestor-app tlsr9518adk80d (read/write) 883308 883300 -8 -0.0
text 602834 602832 -2 -0.0
thermostat tlsr9518adk80d (read/write) 875776 875768 -8 -0.0
text 594344 594340 -4 -0.0
Full report (27 builds for bl602, bl702, cc32xx, cyw30739, k32w, linux, mbed, psoc6, qpg, telink)
platform target config section fd74ca2 52b48d8 change % change
bl602 lighting-app bl602 (read/write) 1349554 1349554 0 0.0
.bss 94666 94666 0 0.0
.data 9752 9752 0 0.0
.text 1025618 1025618 0 0.0
bl602+rpc (read/write) 1394986 1394986 0 0.0
.bss 102714 102714 0 0.0
.data 10144 10144 0 0.0
.text 1056552 1056552 0 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1187907 1187907 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69777 69777 0 0.0
.bss_psram 30064 30064 0 0.0
.comment 48 48 0 0.0
.data 4080 4080 0 0.0
.debug_abbrev 1551744 1551744 0 0.0
.debug_aranges 134240 134240 0 0.0
.debug_frame 492132 492132 0 0.0
.debug_info 40594484 40594485 1 0.0
.debug_line 5277256 5277256 0 0.0
.debug_loc 3415724 3415724 0 0.0
.debug_ranges 371928 371928 0 0.0
.debug_str 3574444 3574444 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107904 107904 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 574062 574062 0 0.0
.symtab 173600 173600 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
954966 954968 2 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1281039 1281039 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77825 77825 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4624 4624 0 0.0
.debug_abbrev 1699975 1699975 0 0.0
.debug_aranges 142480 142480 0 0.0
.debug_frame 519896 519896 0 0.0
.debug_info 45006769 45006771 2 0.0
.debug_line 5676190 5676190 0 0.0
.debug_loc 3612722 3612722 0 0.0
.debug_ranges 395704 395704 0 0.0
.debug_str 3977981 3977981 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 122544 122544 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 635126 635126 0 0.0
.symtab 192064 192064 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1032374 1032378 4 0.0
cc32xx lock CC3235SF_LAUNCHXL (read only) 642545 642545 0 0.0
(read/write) 203664 203664 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197064 197064 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930168 930168 0 0.0
.debug_aranges 87272 87272 0 0.0
.debug_frame 299752 299752 0 0.0
.debug_info 20254045 20254046 1 0.0
.debug_line 2655138 2655138 0 0.0
.debug_loc 2795342 2795342 0 0.0
.debug_ranges 281592 281592 0 0.0
.debug_str 3017877 3017877 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105817 105817 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377630 377630 0 0.0
.symtab 256192 256192 0 0.0
.text 0 0 0 0.0
534604 534604 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586138 586138 0 0.0
.app_xip_area 463036 463036 0 0.0
.bss 65544 65544 0 0.0
.data 740 740 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590066 590066 0 0.0
.app_xip_area 461668 461668 0 0.0
.bss 70832 70832 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 551102 551102 0 0.0
.app_xip_area 433496 433496 0 0.0
.bss 60088 60088 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w contact k32w0+release (read/write) 669928 669928 0 0.0
.bss 77548 77548 0 0.0
.data 2204 2204 0 0.0
.text 571064 571064 0 0.0
light k32w0+release (read/write) 669012 668996 -16 -0.0
.bss 77228 77228 0 0.0
.data 2192 2192 0 0.0
.text 570480 570464 -16 -0.0
lock k32w0+release (read/write) 625640 625640 0 0.0
.bss 75356 75356 0 0.0
.data 2136 2136 0 0.0
.text 545420 545420 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12061684 12061684 0 0.0
(read/write) 729224 729224 0 0.0
.bss 34136 34136 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 671552 671552 0 0.0
.dynamic 560 560 0 0.0
.got 15328 15328 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 585972 585972 0 0.0
.text 9745156 9745156 0 0.0
thermostat-no-ble arm64 (read only) 2515692 2515692 0 0.0
(read/write) 145048 145048 0 0.0
.bss 56312 56312 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 77568 77568 0 0.0
.dynamic 560 560 0 0.0
.got 5336 5336 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150728 150728 0 0.0
.text 2102896 2102896 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2466784 2466784 0 0.0
.bss 215780 215780 0 0.0
.data 5880 5880 0 0.0
.text 1429428 1429428 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 0 0 0 0.0
(read only) 841024 841024 0 0.0
(read/write) 1761044 1761044 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189680 189680 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2640 2640 0 0.0
.debug_abbrev 1253581 1253581 0 0.0
.debug_aranges 111392 111392 0 0.0
.debug_frame 374356 374356 0 0.0
.debug_info 27970776 27970777 1 0.0
.debug_line 3790186 3790186 0 0.0
.debug_loc 3691408 3691408 0 0.0
.debug_ranges 363408 363408 0 0.0
.debug_str 3527169 3527169 0 0.0
.heap 841024 841024 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 580696 580696 0 0.0
.symtab 425568 425568 0 0.0
.text 1560336 1560336 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 0 0 0 0.0
(read only) 841840 841840 0 0.0
(read/write) 1701404 1701404 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188872 188872 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2632 2632 0 0.0
.debug_abbrev 1238914 1238914 0 0.0
.debug_aranges 110624 110624 0 0.0
.debug_frame 376692 376692 0 0.0
.debug_info 27515375 27515376 1 0.0
.debug_line 3797685 3797685 0 0.0
.debug_loc 3674610 3674610 0 0.0
.debug_ranges 361344 361344 0 0.0
.debug_str 3514291 3514291 0 0.0
.heap 841840 841840 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 540405 540405 0 0.0
.symtab 410480 410480 0 0.0
.text 1501512 1501512 0 0.0
.zero.table 8 8 0 0.0
light cy8ckit_062s2_43012 0 0 0 0.0
(read only) 850096 850096 0 0.0
(read/write) 1615132 1615132 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180784 180784 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1074256 1074256 0 0.0
.debug_aranges 102832 102832 0 0.0
.debug_frame 346984 346984 0 0.0
.debug_info 22857703 22857703 0 0.0
.debug_line 3350622 3350622 0 0.0
.debug_loc 3350184 3350184 0 0.0
.debug_ranges 319864 319864 0 0.0
.debug_str 3313037 3313037 0 0.0
.heap 850096 850096 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 476122 476122 0 0.0
.symtab 378464 378464 0 0.0
.text 1423496 1423496 0 0.0
.zero.table 8 8 0 0.0
lock cy8ckit_062s2_43012 0 0 0 0.0
(read only) 845120 845120 0 0.0
(read/write) 1648804 1648804 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185744 185744 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2480 2480 0 0.0
.debug_abbrev 1076165 1076165 0 0.0
.debug_aranges 103232 103232 0 0.0
.debug_frame 348740 348740 0 0.0
.debug_info 23109042 23109042 0 0.0
.debug_line 3352729 3352729 0 0.0
.debug_loc 3374553 3374553 0 0.0
.debug_ranges 322416 322416 0 0.0
.debug_str 3331848 3331848 0 0.0
.heap 845120 845120 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 479846 479846 0 0.0
.symtab 380640 380640 0 0.0
.text 1452192 1452192 0 0.0
.zero.table 8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151372 1151372 0 0.0
.bss 99796 99796 0 0.0
.data 852 852 0 0.0
.text 598468 598468 0 0.0
lock-app qpg6105+debug (read/write) 1118356 1118356 0 0.0
.bss 96284 96284 0 0.0
.data 864 864 0 0.0
.text 565456 565456 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1016424 1016424 0 0.0
bss 97748 97748 0 0.0
text 687174 687176 2 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 951900 951900 0 0.0
bss 96800 96800 0 0.0
text 648574 648576 2 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 856016 856024 8 0.0
bss 88968 88968 0 0.0
text 578924 578926 2 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 871736 871736 0 0.0
bss 89052 89052 0 0.0
text 592930 592930 0 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 950448 950456 8 0.0
bss 97176 97176 0 0.0
text 659388 659392 4 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 883308 883300 -8 -0.0
bss 89980 89980 0 0.0
text 602834 602832 -2 -0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 875776 875768 -8 -0.0
bss 90444 90444 0 0.0
text 594344 594340 -4 -0.0

@github-actions
Copy link

PR #25236: Size comparison from c6cadc8 to 509ae50

Decreases (1 build for cc32xx)
platform target config section c6cadc8 509ae50 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20254045 20254044 -1 -0.0
Full report (1 build for cc32xx)
platform target config section c6cadc8 509ae50 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642545 642545 0 0.0
(read/write) 203664 203664 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197064 197064 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930168 930168 0 0.0
.debug_aranges 87272 87272 0 0.0
.debug_frame 299752 299752 0 0.0
.debug_info 20254045 20254044 -1 -0.0
.debug_line 2655138 2655138 0 0.0
.debug_loc 2795342 2795342 0 0.0
.debug_ranges 281592 281592 0 0.0
.debug_str 3017877 3017877 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105817 105817 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377630 377630 0 0.0
.symtab 256192 256192 0 0.0
.text 534604 534604 0 0.0

@yufengwangca yufengwangca merged commit a786665 into project-chip:master Feb 22, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@yufengwangca
[Android] Convert the last java file in Android CHIPTool to kotlin (p…
8f7214c 
…roject-chip#25236)

* Convert NetworkCredentialsParcelable.java to NetworkCredentialsParcelable.kt

* Address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees

@yufengwangca yufengwangca

Labels
examples review - approved
Projects
No open projects
Java Matter Controller Test
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yufengwangca @andy31415 @yunhanw-google @bzbarsky-apple