Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete android_binary build rule #25175

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Remove obsolete android_binary build rule #25175

merged 1 commit into from
Feb 21, 2023

Conversation

yufengwangca
Copy link
Contributor

Android app now use gradle build system to package Android app, example built from android_binary build rule can not run on Android directly. This build rule is not in use, and obsolete.

@github-actions
Copy link

PR #25175: Size comparison from 97b5370 to c9ebdc0

Increases (2 builds for cc32xx, qpg)
platform target config section 97b5370 c9ebdc0 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20360343 20360344 1 0.0
qpg lock-app qpg6105+debug (read/write) 1118196 1118204 8 0.0
.text 565296 565304 8 0.0
Full report (5 builds for cc32xx, linux, qpg)
platform target config section 97b5370 c9ebdc0 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642217 642217 0 0.0
(read/write) 203696 203696 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197096 197096 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 934242 934242 0 0.0
.debug_aranges 87448 87448 0 0.0
.debug_frame 300212 300212 0 0.0
.debug_info 20360343 20360344 1 0.0
.debug_line 2661062 2661062 0 0.0
.debug_loc 2797107 2797107 0 0.0
.debug_ranges 281744 281744 0 0.0
.debug_str 3019502 3019502 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105705 105705 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377379 377379 0 0.0
.symtab 256048 256048 0 0.0
.text 534392 534392 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12060708 12060708 0 0.0
(read/write) 729224 729224 0 0.0
.bss 34136 34136 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 671552 671552 0 0.0
.dynamic 560 560 0 0.0
.got 15328 15328 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 585780 585780 0 0.0
.text 9744372 9744372 0 0.0
thermostat-no-ble arm64 (read only) 2516220 2516220 0 0.0
(read/write) 145096 145096 0 0.0
.bss 56312 56312 0 0.0
.data 1832 1832 0 0.0
.data.rel.ro 77568 77568 0 0.0
.dynamic 560 560 0 0.0
.got 5336 5336 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 151320 151320 0 0.0
.text 2102752 2102752 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1150636 1150636 0 0.0
.bss 99820 99820 0 0.0
.data 852 852 0 0.0
.text 597732 597732 0 0.0
lock-app qpg6105+debug (read/write) 1118196 1118204 8 0.0
.bss 96316 96316 0 0.0
.data 864 864 0 0.0
.text 565296 565304 8 0.0

@pullapprove pullapprove bot requested a review from nivi-apple February 21, 2023 18:13
@bzbarsky-apple bzbarsky-apple merged commit 3b4bc45 into project-chip:master Feb 21, 2023
@yufengwangca yufengwangca deleted the pr/android/cleanup branch February 21, 2023 19:02
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants