-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to set event UserIndex and Credential in SDK and add to Linux Lock app. #25133
Merged
yufengwangca
merged 2 commits into
project-chip:master
from
krypton36:FixEventNotificationLock
Feb 17, 2023
Merged
Add ability to set event UserIndex and Credential in SDK and add to Linux Lock app. #25133
yufengwangca
merged 2 commits into
project-chip:master
from
krypton36:FixEventNotificationLock
Feb 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
February 16, 2023 19:03
pullapprove
bot
requested review from
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
February 16, 2023 19:03
krypton36
changed the title
Resolve event notifications from lock when setting the lock state.
Add ability to set event UserIndex and Credential in SDK and add to Linux Lock app.
Feb 16, 2023
bzbarsky-apple
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
bzbarsky-apple
added
the
door lock
Issues in the Door Lock cluster or example apps
label
Feb 16, 2023
krypton36
force-pushed
the
FixEventNotificationLock
branch
from
February 16, 2023 19:58
4a9ab99
to
7c34d45
Compare
jrhees-cae
suggested changes
Feb 16, 2023
PR #25133: Size comparison from e08d4e5 to 7c34d45 Increases (11 builds for bl702, cc13x2_26x2, cc32xx, cyw30739, psoc6, qpg)
Decreases (15 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, k32w, psoc6, qpg)
Full report (26 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, k32w, linux, psoc6, qpg)
|
krypton36
force-pushed
the
FixEventNotificationLock
branch
2 times, most recently
from
February 17, 2023 03:08
74f0885
to
e022273
Compare
krypton36
force-pushed
the
FixEventNotificationLock
branch
from
February 17, 2023 03:14
e022273
to
6069462
Compare
PR #25133: Size comparison from 5f058f9 to 6069462 Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (2 builds for cc32xx, mbed)
|
bzbarsky-apple
force-pushed
the
FixEventNotificationLock
branch
from
February 17, 2023 03:59
7ce9b4a
to
e3ffb8d
Compare
PR #25133: Size comparison from cf83805 to e3ffb8d Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
jrhees-cae
approved these changes
Feb 17, 2023
andy31415
approved these changes
Feb 17, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…inux Lock app. (project-chip#25133) * Resolve event notifications from lock when setting the lock state. * Fix Linux build issue. --------- Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info:
SDK does not support the ability for a Lock-App to set the event information for the required data and is hard coded here. This PR updates the SDK to allow setting the UserIndex and Credentials as parameters when setting the lock state as per spec.
Summary: