Do not include endpoint config in types_stub.h #25128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re directly referenced there
andy31415
changed the title
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
kcoppock,
kkasperczyk-no and
ksperling-apple
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yunhanw-google
|
PR #25128: Size comparison from 6a3bbe0 to 0013be0 Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
|
PR #25128: Size comparison from 1fd5c53 to b473d37 Increases (3 builds for bl702, cc32xx)
Decreases (1 build for bl702)
Full report (10 builds for bl602, bl702, cc32xx, linux, mbed, qpg)
|
bzbarsky-apple
requested changes
Feb 17, 2023
src/app/clusters/application-basic-server/application-basic-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/application-launcher-server/application-launcher-server.cpp
Outdated
Show resolved
Hide resolved
bzbarsky-apple
approved these changes
Feb 17, 2023
|
PR #25128: Size comparison from 1fd5c53 to 2e73fb5 Increases above 0.2%:
Increases (5 builds for bl602, bl702, mbed)
Decreases (5 builds for bl602, bl702, mbed)
Full report (5 builds for bl602, bl702, mbed)
|
tcarmelveilleux
approved these changes
Feb 17, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* Remove endpoint config from types. Add it to binding tables as they are directly referenced there * Mass addition of gen_config header whenever endpoint count was being fetched * Undo all changes except type_stubs. This is to create a tool that auto-adds headers * Added app/util/config.h whenever gen_config or endpoint_config bits seemed to be used * Restyle * Remove duplicate include based on code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including data types should not have a sideffect of including / depending on app-specific endpoint configuration.
This removes endpoint_config/gen_config from types_stub and starded adding direct includes where these seem needed (probably not exhausinve, relying on CI to test compilation for now).
Without this change, Accessors.h is not directly usable without depending on a codegen bit because of a dependency of
Accessors.h -> af-types.h -> types_stub.h -> endpoint_config.haf-types.hseemed to want some of gen/endpoint config flags (specifically to define structures depending on what clusters are selected), changed this like:- removed some unused clusters
- moved scenese table entry to scenes.h