Light UI updates - add level and color control UI Information #25027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and this is NOT interactive
… could be re-used across apps
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
jtung-apple
pullapprove
bot
requested review from
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
pjzander-signify,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #25027: Size comparison from 9508b52 to 25eb078 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
bzbarsky-apple
requested changes
Feb 13, 2023
bzbarsky-apple
approved these changes
Feb 13, 2023
|
PR #25027: Size comparison from 9508b52 to 62c917a Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…t-chip#25027) * Switch light from checkbox to label - checkbox implies interactivity and this is NOT interactive * Split out logic for qr code drawing. I imagine eventually each window could be re-used across apps * Add level control status * Report remaining time for level movement * More ui * Restyle * Start moving towards accessor interfaces * Switch the rest to accessors api * Removed some includes ... only need accessors * One more include remove * Restyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added UI for level control and some color control information.
Saw the values moving as timed interactions were triggered.
Also learned that hue-saturation vs x-y are completely independent (is this really expected?) and not persisted across reboots. Looks like a useful debug tool.