Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Window App ZAP File #24980

Conversation

emargolis
Copy link
Contributor

  • Removed General Diagnostics Cluster optional events, which are only implemented in the All Cluster, Lighting and Lock App examples.
  • Removed Software Diagnostics Cluster event, which is only implemented in the All Clusters App example.
  • Removed all Thread Network Diagnostics Cluster events, which are currently not implemented in the SDK at all.

Fixes #24946

  - Removed General Diagnostics Cluster optional events, which
    are only implemented in the All Cluster, Lighting and Lock App examples.
  - Removed Software Diagnostics Cluster event, which is only
    implemented in the All Clusters App example.
  - Removed all Thread Network Diagnostics Cluster events, which
    are currently not implemented in the SDK at all.
@github-actions
Copy link

PR #24980: Size comparison from 5ad70f6 to f68b474

Increases (1 build for cc32xx)
platform target config section 5ad70f6 f68b474 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20194394 20194395 1 0.0
Full report (2 builds for cc32xx, mbed)
platform target config section 5ad70f6 f68b474 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640233 640233 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928439 928439 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20194394 20194395 1 0.0
.debug_line 2649797 2649797 0 0.0
.debug_loc 2785922 2785922 0 0.0
.debug_ranges 280720 280720 0 0.0
.debug_str 3001474 3001474 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105585 105585 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375840 375840 0 0.0
.symtab 255856 255856 0 0.0
.text 532524 532524 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2464576 2464576 0 0.0
.bss 215892 215892 0 0.0
.data 5880 5880 0 0.0
.text 1427220 1427220 0 0.0

Copy link
Contributor

@andy31415 andy31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am surprised codegen still passes without any matter file changes.

Guessing this needs matter support for reporting what events are being reported...

@andy31415 andy31415 merged commit 377e8e8 into project-chip:master Feb 10, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
- Removed General Diagnostics Cluster optional events, which
    are only implemented in the All Cluster, Lighting and Lock App examples.
  - Removed Software Diagnostics Cluster event, which is only
    implemented in the All Clusters App example.
  - Removed all Thread Network Diagnostics Cluster events, which
    are currently not implemented in the SDK at all.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Window app now violates spec, claims to support events it does not actually support
3 participants