-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Window App ZAP File #24980
Merged
andy31415
merged 1 commit into
project-chip:master
from
emargolis:emargolis/feature/examples/enable-events-for-window-app-updated
Feb 10, 2023
Merged
Updated Window App ZAP File #24980
andy31415
merged 1 commit into
project-chip:master
from
emargolis:emargolis/feature/examples/enable-events-for-window-app-updated
Feb 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed General Diagnostics Cluster optional events, which are only implemented in the All Cluster, Lighting and Lock App examples. - Removed Software Diagnostics Cluster event, which is only implemented in the All Clusters App example. - Removed all Thread Network Diagnostics Cluster events, which are currently not implemented in the SDK at all.
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mrjerryjohns
February 10, 2023 18:19
pullapprove
bot
requested review from
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
February 10, 2023 18:19
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
mspang,
pjzander-signify,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
February 10, 2023 18:19
PR #24980: Size comparison from 5ad70f6 to f68b474 Increases (1 build for cc32xx)
Full report (2 builds for cc32xx, mbed)
|
bzbarsky-apple
approved these changes
Feb 10, 2023
andy31415
approved these changes
Feb 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am surprised codegen still passes without any matter file changes.
Guessing this needs matter support for reporting what events are being reported...
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
- Removed General Diagnostics Cluster optional events, which are only implemented in the All Cluster, Lighting and Lock App examples. - Removed Software Diagnostics Cluster event, which is only implemented in the All Clusters App example. - Removed all Thread Network Diagnostics Cluster events, which are currently not implemented in the SDK at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24946