-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] Fix host setup failure on mac and some build docs #24973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On mac, we can download the gdbgui wheels as binary
github-actions
bot
added
documentation
Improvements or additions to documentation
scripts
labels
Feb 10, 2023
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
February 10, 2023 14:06
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yunhanw-google
February 10, 2023 14:06
pullapprove
bot
added
review - pending
and removed
documentation
Improvements or additions to documentation
scripts
labels
Feb 10, 2023
@andy31415 I took a suggestion from #23477 (comment) |
andy31415
approved these changes
Feb 10, 2023
PR #24973: Size comparison from 36735ed to 1b882fa Increases (3 builds for bl702, psoc6)
Decreases (6 builds for bl602, bl702, cc32xx, psoc6)
Full report (19 builds for bl602, bl702, cc32xx, cyw30739, k32w, linux, psoc6, qpg)
|
bzbarsky-apple
approved these changes
Feb 10, 2023
github-actions
bot
added
documentation
Improvements or additions to documentation
scripts
labels
Feb 10, 2023
PR #24973: Size comparison from 36735ed to 91af0f5 Decreases (1 build for nrfconnect)
Full report (5 builds for cc32xx, mbed, nrfconnect)
|
dhrishi
approved these changes
Feb 11, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…ip#24973) * [ESP32] Restrict only gdbgui to x64 linux On mac, we can download the gdbgui wheels as binary * [ESP32] Documentation changes * address review comments * restyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #24734 (comment)
This may also fix #24816
Change Overview
#22071 restricted
requirements.esp32.txt
to only linux platform and hence dependencies required to build the ESP32 examples are not installed on mac.Restrictions were added because building wheels for
gevent
(dependency ofgdbgui
) failed.Removed the platform restrictions for all the dependencies other than
gdbgui
. Added some documentation around how to installgdbgui
on mac.And some doc fixes.
Testing